diff options
| author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-17 06:31:44 +0000 |
|---|---|---|
| committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-17 06:31:44 +0000 |
| commit | edcca49267770144ca98eb056278a8c45330e8a5 (patch) | |
| tree | be111a4bee34bd07c3b4b8316604828036418032 | |
| parent | 5299cb97b9f7a9e7fdf4eecda57be21de34c11cf (diff) | |
| download | chromium_src-edcca49267770144ca98eb056278a8c45330e8a5.zip chromium_src-edcca49267770144ca98eb056278a8c45330e8a5.tar.gz chromium_src-edcca49267770144ca98eb056278a8c45330e8a5.tar.bz2 | |
Experiment: enable TCMalloc on Linux by default.
Will revert after looking at the Linux memory bot and perf cycler.
TBR=willchan
Review URL: http://codereview.chromium.org/403002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32158 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | base/base.gyp | 28 | ||||
| -rw-r--r-- | base/leak_annotations.h | 2 | ||||
| -rw-r--r-- | build/common.gypi | 2 | ||||
| -rwxr-xr-x | chrome/chrome.gyp | 8 | ||||
| -rw-r--r-- | webkit/tools/test_shell/test_shell.gyp | 8 |
5 files changed, 27 insertions, 21 deletions
diff --git a/base/base.gyp b/base/base.gyp index 51aa6c8..562de8c 100644 --- a/base/base.gyp +++ b/base/base.gyp @@ -384,30 +384,12 @@ [ 'OS == "linux" or OS == "freebsd"', { 'sources/': [ ['exclude', '_(mac|win|chromeos)\\.cc$'], ['exclude', '\\.mm?$' ] ], - 'variables' : { - 'linux_use_heapchecker%' : 0, - }, 'conditions': [ [ 'chromeos==1 or toolkit_views==1', { 'sources/': [ ['include', '_chromeos\\.cc$'] ] }, ], - [ 'linux_use_heapchecker==1', { - 'defines': [ - 'LINUX_USE_HEAPCHECKER', - ], - 'direct_dependent_settings': { - 'defines': [ - 'LINUX_USE_HEAPCHECKER', - ], - }, - }, - ], - # linux_use_heapchecker==1 implies linux_use_tcmalloc=1. - [ 'linux_use_tcmalloc==1 or linux_use_heapchecker==1', { - 'dependencies': [ - '../third_party/tcmalloc/tcmalloc.gyp:tcmalloc', - ], + [ 'linux_use_tcmalloc==1', { 'defines': [ 'LINUX_USE_TCMALLOC', ], @@ -690,6 +672,14 @@ 'file_version_info_unittest.cc', 'worker_pool_linux_unittest.cc', ], + 'conditions': [ + [ 'linux_use_tcmalloc==1', { + 'dependencies': [ + '../third_party/tcmalloc/tcmalloc.gyp:tcmalloc', + ], + }, + ], + ], 'dependencies': [ '../build/linux/system.gyp:gtk', '../build/linux/system.gyp:nss', diff --git a/base/leak_annotations.h b/base/leak_annotations.h index aa57dff..7e652a5 100644 --- a/base/leak_annotations.h +++ b/base/leak_annotations.h @@ -5,7 +5,7 @@ #ifndef BASE_LEAK_ANNOTATIONS_H_ #define BASE_LEAK_ANNOTATIONS_H_ -#if defined(LINUX_USE_TCMALLOC) && defined(LINUX_USE_HEAPCHECKER) +#if defined(LINUX_USE_TCMALLOC) #include "third_party/tcmalloc/heap-checker.h" diff --git a/build/common.gypi b/build/common.gypi index 4652db4..90b9234 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -182,7 +182,7 @@ 'linux_strip_binary%': 0, # Enable TCMalloc. - 'linux_use_tcmalloc%': 0, + 'linux_use_tcmalloc%': 1, # Set to select the Title Case versions of strings in GRD files. 'use_titlecase_in_grd_files%': 0, diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp index 4b3b096..2da3418 100755 --- a/chrome/chrome.gyp +++ b/chrome/chrome.gyp @@ -3583,6 +3583,14 @@ 'message': 'Generating manpage' }, ], + 'conditions': [ + [ 'linux_use_tcmalloc==1', { + 'dependencies': [ + '../third_party/tcmalloc/tcmalloc.gyp:tcmalloc', + ], + }, + ], + ], 'dependencies': [ # On Linux, link the dependencies (libraries) that make up actual # Chromium functionality directly into the executable. diff --git a/webkit/tools/test_shell/test_shell.gyp b/webkit/tools/test_shell/test_shell.gyp index f805b09..9baad37 100644 --- a/webkit/tools/test_shell/test_shell.gyp +++ b/webkit/tools/test_shell/test_shell.gyp @@ -290,6 +290,14 @@ ], }], ['OS=="linux"', { + 'conditions': [ + [ 'linux_use_tcmalloc==1', { + 'dependencies': [ + '../../../third_party/tcmalloc/tcmalloc.gyp:tcmalloc', + ], + }, + ], + ], 'dependencies': [ '../../../build/linux/system.gyp:gtk', 'test_shell_resources', |