diff options
| author | nednguyen@google.com <nednguyen@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-09 22:22:12 +0000 |
|---|---|---|
| committer | nednguyen@google.com <nednguyen@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-09 22:22:12 +0000 |
| commit | 3fa10ff21ec5a8c4c7183a34ec1f9b78e43a8706 (patch) | |
| tree | bb071f46d57e8eaf11421b0a7c3540139b1d57f5 | |
| parent | bd386e6e24cae63b34d8b1b0693dd07b61573690 (diff) | |
| download | chromium_src-3fa10ff21ec5a8c4c7183a34ec1f9b78e43a8706.zip chromium_src-3fa10ff21ec5a8c4c7183a34ec1f9b78e43a8706.tar.gz chromium_src-3fa10ff21ec5a8c4c7183a34ec1f9b78e43a8706.tar.bz2 | |
Update network to use results.AddValue(...)
BUG=391943
Review URL: https://codereview.chromium.org/377333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282144 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | tools/perf/metrics/network.py | 26 |
1 files changed, 18 insertions, 8 deletions
diff --git a/tools/perf/metrics/network.py b/tools/perf/metrics/network.py index ae84270..f9d4ffb 100644 --- a/tools/perf/metrics/network.py +++ b/tools/perf/metrics/network.py @@ -14,6 +14,7 @@ from telemetry.page import page_measurement # All network metrics are Chrome only for now. from telemetry.core.backends.chrome import inspector_network from telemetry.timeline import recording_options +from telemetry.value import scalar class NetworkMetricException(page_measurement.MeasurementFailure): @@ -167,10 +168,14 @@ class NetworkMetric(Metric): logging.warning('original content length (%d) is less than content ' 'lenght(%d) for resource %s', ocl, cl, resource) if self.add_result_for_resource: - results.Add('resource_data_saving_' + resource_signature, - 'percent', resp.data_saving_rate * 100) - results.Add('resource_original_content_length_' + resource_signature, - 'bytes', ocl) + results.AddValue(scalar.ScalarValue( + results.current_page, + 'resource_data_saving_' + resource_signature, 'percent', + resp.data_saving_rate * 100)) + results.AddValue(scalar.ScalarValue( + results.current_page, + 'resource_original_content_length_' + resource_signature, 'bytes', + ocl)) original_content_length += ocl else: original_content_length += cl @@ -179,13 +184,18 @@ class NetworkMetric(Metric): 'resource_content_length_' + resource_signature, 'bytes', cl) content_length += cl - results.Add('content_length', 'bytes', content_length) - results.Add('original_content_length', 'bytes', original_content_length) + results.AddValue(scalar.ScalarValue( + results.current_page, 'content_length', 'bytes', content_length)) + results.AddValue(scalar.ScalarValue( + results.current_page, 'original_content_length', 'bytes', + original_content_length)) if self.compute_data_saving: if (original_content_length > 0 and original_content_length >= content_length): saving = (float(original_content_length-content_length) * 100 / original_content_length) - results.Add('data_saving', 'percent', saving) + results.AddValue(scalar.ScalarValue( + results.current_page, 'data_saving', 'percent', saving)) else: - results.Add('data_saving', 'percent', 0.0) + results.AddValue(scalar.ScalarValue( + results.current_page, 'data_saving', 'percent', 0.0)) |