diff options
| author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-03 16:27:19 +0000 |
|---|---|---|
| committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-03 16:27:19 +0000 |
| commit | 08bb7500c4583bb641717819ade7af8e520e92cb (patch) | |
| tree | 2555d19c6285170fed572711cd9ddcac1bd53d53 | |
| parent | 68666b4792122c191ea051fe7fbfad138892c3ad (diff) | |
| download | chromium_src-08bb7500c4583bb641717819ade7af8e520e92cb.zip chromium_src-08bb7500c4583bb641717819ade7af8e520e92cb.tar.gz chromium_src-08bb7500c4583bb641717819ade7af8e520e92cb.tar.bz2 | |
Fix the inactive Manage Extension link.
The button was not receiving click events because the bubble was closing when you'd try to click it. Changing to <button> fixes that.
BUG=367043
Review URL: https://codereview.chromium.org/257183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268071 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/resources/options/controlled_setting.js | 3 | ||||
| -rw-r--r-- | chrome/browser/resources/options/options.html | 4 |
2 files changed, 4 insertions, 3 deletions
diff --git a/chrome/browser/resources/options/controlled_setting.js b/chrome/browser/resources/options/controlled_setting.js index cdc2205..5ac42d9 100644 --- a/chrome/browser/resources/options/controlled_setting.js +++ b/chrome/browser/resources/options/controlled_setting.js @@ -171,7 +171,8 @@ cr.define('options', function() { path: '?id=' + extensionId}); }; - var disableButton = extensionContainer.querySelector('button'); + var disableButton = extensionContainer.querySelector( + '.controlled-setting-bubble-extension-disable-button'); disableButton.onclick = function() { chrome.send('disableExtension', [extensionId]); }; diff --git a/chrome/browser/resources/options/options.html b/chrome/browser/resources/options/options.html index 1115884..f99f773 100644 --- a/chrome/browser/resources/options/options.html +++ b/chrome/browser/resources/options/options.html @@ -166,8 +166,8 @@ <div class="controlled-setting-bubble-extension-name"></div> </div> <div class="controlled-setting-bubble-content-row"> - <div class="controlled-setting-bubble-extension-manage-link link-button" - i18n-content="controlledSettingManageExtension"></div> + <button class="controlled-setting-bubble-extension-manage-link link-button" + i18n-content="controlledSettingManageExtension"></button> <button class='controlled-setting-bubble-extension-disable-button' i18n-content="controlledSettingDisableExtension"></button> </div> |