summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjennb@chromium.org <jennb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-04-15 17:04:29 +0000
committerjennb@chromium.org <jennb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-04-15 17:04:29 +0000
commitdf2a354dc4699e7c574dfbe36143ff0e4ddce361 (patch)
tree5a626df3812ae96c2d02cf88f2af243be2a46ad8
parentbab728486ea14ef1271f74779fc52995824f7014 (diff)
downloadchromium_src-df2a354dc4699e7c574dfbe36143ff0e4ddce361.zip
chromium_src-df2a354dc4699e7c574dfbe36143ff0e4ddce361.tar.gz
chromium_src-df2a354dc4699e7c574dfbe36143ff0e4ddce361.tar.bz2
Flesh out a bit more of Panel class.
BUG=None TEST=None Review URL: http://codereview.chromium.org/6860002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81757 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/ui/browser_window.h7
-rw-r--r--chrome/browser/ui/panels/panel.cc5
-rw-r--r--chrome/browser/ui/panels/panel.h7
3 files changed, 8 insertions, 11 deletions
diff --git a/chrome/browser/ui/browser_window.h b/chrome/browser/ui/browser_window.h
index 83e6308..5fa6ddf 100644
--- a/chrome/browser/ui/browser_window.h
+++ b/chrome/browser/ui/browser_window.h
@@ -334,13 +334,6 @@ class BrowserWindow {
// Construct a BrowserWindow implementation for the specified |browser|.
static BrowserWindow* CreateBrowserWindow(Browser* browser);
- // Construct a panel BrowserWindow implementation for the specified |browser|.
- // TODO (jianli): to be implemented.
- static BrowserWindow* CreatePanelBrowserWindow(Browser* browser,
- Panel* panel) {
- return NULL;
- }
-
// Construct a FindBar implementation for the specified |browser|.
static FindBar* CreateFindBar(Browser* browser_window);
diff --git a/chrome/browser/ui/panels/panel.cc b/chrome/browser/ui/panels/panel.cc
index a0ce9fc..ba91026 100644
--- a/chrome/browser/ui/panels/panel.cc
+++ b/chrome/browser/ui/panels/panel.cc
@@ -12,7 +12,7 @@
Panel::Panel(Browser* browser, const gfx::Rect& bounds)
: bounds_(bounds),
minimized_(false) {
- browser_window_.reset(BrowserWindow::CreatePanelBrowserWindow(browser, this));
+ browser_window_.reset(CreateNativePanel(browser, this));
}
Panel::~Panel() {
@@ -173,17 +173,14 @@ void Panel::RotatePaneFocus(bool forwards) {
}
bool Panel::IsBookmarkBarVisible() const {
- NOTIMPLEMENTED();
return false;
}
bool Panel::IsBookmarkBarAnimating() const {
- NOTIMPLEMENTED();
return false;
}
bool Panel::IsTabStripEditable() const {
- NOTIMPLEMENTED();
return false;
}
diff --git a/chrome/browser/ui/panels/panel.h b/chrome/browser/ui/panels/panel.h
index aa8c21c..aabd41c 100644
--- a/chrome/browser/ui/panels/panel.h
+++ b/chrome/browser/ui/panels/panel.h
@@ -127,6 +127,13 @@ class Panel : public BrowserWindow {
virtual void ShowKeyboardOverlay(gfx::NativeWindow owning_window);
#endif
+ // Construct a native panel BrowserWindow implementation for the specified
+ // |browser|.
+ // TODO(jianli): to be implemented in platform-specific files.
+ static BrowserWindow* CreateNativePanel(Browser* browser, Panel* panel) {
+ return NULL;
+ }
+
protected:
virtual void DestroyBrowser();