summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-01-08 08:41:17 +0000
committerjochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-01-08 08:41:17 +0000
commit0211686707bbd64b6e0373fc1d755186eec55959 (patch)
treeae5e37fb259cc7c390070c40ef1e1d9e74984db6
parent4f9571ffebd335384b209baf12e3918122ad0404 (diff)
downloadchromium_src-0211686707bbd64b6e0373fc1d755186eec55959.zip
chromium_src-0211686707bbd64b6e0373fc1d755186eec55959.tar.gz
chromium_src-0211686707bbd64b6e0373fc1d755186eec55959.tar.bz2
Disabel nacl_newlib.run_breakpad_crash_in_syscall_test
BUG=332331 TBR=bbudge@chromium.org Review URL: https://codereview.chromium.org/127813002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243515 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--ppapi/native_client/tests/breakpad_crash_test/nacl.scons31
1 files changed, 16 insertions, 15 deletions
diff --git a/ppapi/native_client/tests/breakpad_crash_test/nacl.scons b/ppapi/native_client/tests/breakpad_crash_test/nacl.scons
index f3ce99a..308e888 100644
--- a/ppapi/native_client/tests/breakpad_crash_test/nacl.scons
+++ b/ppapi/native_client/tests/breakpad_crash_test/nacl.scons
@@ -71,21 +71,22 @@ env.AddNodeToTestSuite(
# This tests a crash that occurs inside a syscall handler.
# Ultimately this should be recognised as a crash caused by untrusted code.
# See http://code.google.com/p/nativeclient/issues/detail?id=579
-node = env.PPAPIBrowserTester(
- 'breakpad_crash_in_syscall_test.out',
- python_tester_script=env.File('crash_dump_tester.py'),
- url='crash_in_syscall.html',
- nmf_names=['crash_in_syscall'],
- files=[GetNexeByName('crash_in_syscall'),
- env.File('crash_in_syscall.html')],
- args=platform_args + ['--expected_crash_dumps=%i' % expected_crash_dumps])
-env.AddNodeToTestSuite(
- node, ['chrome_browser_tests'], 'run_breakpad_crash_in_syscall_test',
- # This test is currently flaky on Win 32 bit on x86, disabling there.
- # See bug: https://code.google.com/p/chromium/issues/detail?id=254583
- is_broken=env.PPAPIBrowserTesterIsBroken() or
- env.Bit('running_on_valgrind') or
- (env.Bit('host_windows') and env.Bit('build_x86_32')))
+# DISABLED due to flakiness (http://crbug.com/332331)
+# node = env.PPAPIBrowserTester(
+# 'breakpad_crash_in_syscall_test.out',
+# python_tester_script=env.File('crash_dump_tester.py'),
+# url='crash_in_syscall.html',
+# nmf_names=['crash_in_syscall'],
+# files=[GetNexeByName('crash_in_syscall'),
+# env.File('crash_in_syscall.html')],
+# args=platform_args + ['--expected_crash_dumps=%i' % expected_crash_dumps])
+# env.AddNodeToTestSuite(
+# node, ['chrome_browser_tests'], 'run_breakpad_crash_in_syscall_test',
+# # This test is currently flaky on Win 32 bit on x86, disabling there.
+# # See bug: https://code.google.com/p/chromium/issues/detail?id=254583
+# is_broken=env.PPAPIBrowserTesterIsBroken() or
+# env.Bit('running_on_valgrind') or
+# (env.Bit('host_windows') and env.Bit('build_x86_32')))
# Crashes in untrusted code should not produce crash dumps.
node = env.PPAPIBrowserTester(