Mac: Draw entire Bookmark Bar every time to match API expectations.

NtpBackgroundUtil::PaintBackgroundDetachedMode() expects to draw
the entire bookmark bar on every expose; all of its internal math
is based on the assumption that the incoming area is zero-based and
is the whole bookmark bar area.

TEST=(Repo instructions in bug)
BUG=25655

Review URL: http://codereview.chromium.org/401005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32115 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 12 insertions, 2 deletions

diff --git a/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm b/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm
index 1a9b7ce..d327170 100644
--- a/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm
+++ b/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm
@@ -50,8 +50,18 @@ const CGFloat kBorderRadius = 3.0;
   {
     // CanvasPaint draws to the NSGraphicsContext during its destructor, so
     // explicitly scope this.
-    gfx::CanvasPaint canvas(rect, true);
-    gfx::Rect area(0, 0, NSWidth(rect), NSHeight(rect));
+    //
+    // Paint the entire bookmark bar, even if the damage rect is much smaller
+    // because PaintBackgroundDetachedMode() assumes that area's origin is
+    // (0, 0) and that its size is the size of the bookmark bar.
+    //
+    // In practice, this sounds worse than it is because redraw time is still
+    // minimal compared to the pause between frames of animations. We were
+    // already repainting the rest of the bookmark bar below without setting a
+    // clip area, anyway. Also, the only time we weren't asked to redraw the
+    // whole bookmark bar is when the find bar is drawn over it.
+    gfx::CanvasPaint canvas(bounds, true);
+    gfx::Rect area(0, 0, NSWidth(bounds), NSHeight(bounds));
 
     NtpBackgroundUtil::PaintBackgroundDetachedMode(themeProvider, &canvas,
         area, [controller_ currentTabContentsHeight]);