diff options
| author | mark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-24 14:59:13 +0000 |
|---|---|---|
| committer | mark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-24 14:59:13 +0000 |
| commit | 081c03452bb7d97b138bed3ccc7cbe0903eae05c (patch) | |
| tree | 9f76ed33e86a3a7d3912d5bfac8c9c869be2beb5 | |
| parent | 50ea80760daa8f09aebfa13ac058ce879aab85bb (diff) | |
| download | chromium_src-081c03452bb7d97b138bed3ccc7cbe0903eae05c.zip chromium_src-081c03452bb7d97b138bed3ccc7cbe0903eae05c.tar.gz chromium_src-081c03452bb7d97b138bed3ccc7cbe0903eae05c.tar.bz2 | |
Turn off PIE when building for Valgrind.
BUG=90221, 93551
TEST=Valgrind
Review URL: http://codereview.chromium.org/7724002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98046 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | build/common.gypi | 14 | ||||
| -rwxr-xr-x | build/mac/change_mach_o_flags_from_xcode.sh | 1 |
2 files changed, 15 insertions, 0 deletions
diff --git a/build/common.gypi b/build/common.gypi index b6b179a..c8c37bd 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -1688,10 +1688,24 @@ # relativization during dict merging. 'change_mach_o_flags_path': 'mac/change_mach_o_flags_from_xcode.sh', + 'change_mach_o_flags_options': [ + ], + 'target_conditions': [ + ['release_valgrind_build==1', { + 'change_mach_o_flags_options': [ + # Turn off PIE when building for Valgrind because + # Valgrind doesn't understand slide. TODO: Make + # Valgrind on Mac OS X understand slide, and get rid + # of the Valgrind check. + '--no-pie', + ], + }], + ], }, 'postbuild_name': 'Change Mach-O Flags', 'action': [ '<(change_mach_o_flags_path)', + '>@(change_mach_o_flags_options)', ], }, ], diff --git a/build/mac/change_mach_o_flags_from_xcode.sh b/build/mac/change_mach_o_flags_from_xcode.sh index ab3ee49..1824f8d 100755 --- a/build/mac/change_mach_o_flags_from_xcode.sh +++ b/build/mac/change_mach_o_flags_from_xcode.sh @@ -11,4 +11,5 @@ set -e exec "$(dirname "${0}")/change_mach_o_flags.py" \ + "${@}" \ "${BUILT_PRODUCTS_DIR}/${EXECUTABLE_PATH}" |