diff options
| author | amit@chromium.org <amit@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-02 20:41:38 +0000 |
|---|---|---|
| committer | amit@chromium.org <amit@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-02 20:41:38 +0000 |
| commit | 0fd887ce3699d1ea34bef0c7d53e26f2bd5f7706 (patch) | |
| tree | ab4aaa1d9b3fa3385dc00cf7e000698d87e82a12 | |
| parent | 3c3409d373ad97de23f29e8fa2d6afa3cf0aa113 (diff) | |
| download | chromium_src-0fd887ce3699d1ea34bef0c7d53e26f2bd5f7706.zip chromium_src-0fd887ce3699d1ea34bef0c7d53e26f2bd5f7706.tar.gz chromium_src-0fd887ce3699d1ea34bef0c7d53e26f2bd5f7706.tar.bz2 | |
More false positive crashes crash report suppressions.
Collect crash dump in the ReportData and ReportResult code path
only if chrome frame is directly at fault. We are getting too
much noise since this is high frequency intercept and quite
popular code path for crashes.
BUG=51488,44463
TEST=none
Review URL: http://codereview.chromium.org/3295008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58397 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome_frame/protocol_sink_wrap.cc | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/chrome_frame/protocol_sink_wrap.cc b/chrome_frame/protocol_sink_wrap.cc index a7ec991..f0f358e 100644 --- a/chrome_frame/protocol_sink_wrap.cc +++ b/chrome_frame/protocol_sink_wrap.cc @@ -456,12 +456,16 @@ HRESULT ProtData::ReportProgress(IInternetProtocolSink* delegate, return S_OK; } + // We are just pass through at this point, avoid false positive crash reports. + ExceptionBarrierReportOnlyModule barrier; return delegate->ReportProgress(status_code, status_text); } HRESULT ProtData::ReportData(IInternetProtocolSink* delegate, DWORD flags, ULONG progress, ULONG max_progress) { if (renderer_type_ != UNDETERMINED) { + // We are just pass through now, avoid false positive crash reports. + ExceptionBarrierReportOnlyModule barrier; return delegate->ReportData(flags, progress, max_progress); } |