summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authortfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-01-21 03:20:33 +0000
committertfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-01-21 03:20:33 +0000
commit10162ad19beb8c6cdd225e5d40e9db3ca0ad42e5 (patch)
tree43a89e65f0b4b0940f47a5f0f81c171d34150cf3
parentc622a9e126c0d8e14b4ae7ef4e2bce25f8930103 (diff)
downloadchromium_src-10162ad19beb8c6cdd225e5d40e9db3ca0ad42e5.zip
chromium_src-10162ad19beb8c6cdd225e5d40e9db3ca0ad42e5.tar.gz
chromium_src-10162ad19beb8c6cdd225e5d40e9db3ca0ad42e5.tar.bz2
bookmarks: Forward declare some classes in header files when possible.
BUG=144783 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11959042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177885 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/bookmarks/bookmark_storage.cc1
-rw-r--r--chrome/browser/bookmarks/bookmark_storage.h2
-rw-r--r--chrome/browser/bookmarks/recently_used_folders_combo_model.h7
-rw-r--r--chrome/browser/bookmarks/recently_used_folders_combo_model_unittest.cc1
4 files changed, 8 insertions, 3 deletions
diff --git a/chrome/browser/bookmarks/bookmark_storage.cc b/chrome/browser/bookmarks/bookmark_storage.cc
index d5aa1fd..c4dee86 100644
--- a/chrome/browser/bookmarks/bookmark_storage.cc
+++ b/chrome/browser/bookmarks/bookmark_storage.cc
@@ -13,6 +13,7 @@
#include "base/metrics/histogram.h"
#include "base/time.h"
#include "chrome/browser/bookmarks/bookmark_codec.h"
+#include "chrome/browser/bookmarks/bookmark_index.h"
#include "chrome/browser/bookmarks/bookmark_model.h"
#include "chrome/common/chrome_constants.h"
#include "chrome/common/startup_metric_utils.h"
diff --git a/chrome/browser/bookmarks/bookmark_storage.h b/chrome/browser/bookmarks/bookmark_storage.h
index e773df2..a8dca16 100644
--- a/chrome/browser/bookmarks/bookmark_storage.h
+++ b/chrome/browser/bookmarks/bookmark_storage.h
@@ -8,8 +8,8 @@
#include "base/files/important_file_writer.h"
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
-#include "chrome/browser/bookmarks/bookmark_index.h"
+class BookmarkIndex;
class BookmarkModel;
class BookmarkPermanentNode;
diff --git a/chrome/browser/bookmarks/recently_used_folders_combo_model.h b/chrome/browser/bookmarks/recently_used_folders_combo_model.h
index 96666ff..f446af7 100644
--- a/chrome/browser/bookmarks/recently_used_folders_combo_model.h
+++ b/chrome/browser/bookmarks/recently_used_folders_combo_model.h
@@ -7,10 +7,13 @@
#include <vector>
-#include "base/string16.h"
-#include "chrome/browser/bookmarks/bookmark_model.h"
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
#include "ui/base/models/combobox_model.h"
+class BookmarkModel;
+class BookmarkNode;
+
// Model for the combobox showing the list of folders to choose from. The
// list always contains the bookmark bar, other node and parent. The list
// also contains an extra item that shows the text 'Choose another folder...'.
diff --git a/chrome/browser/bookmarks/recently_used_folders_combo_model_unittest.cc b/chrome/browser/bookmarks/recently_used_folders_combo_model_unittest.cc
index 1e0cf7b..4e72c2e 100644
--- a/chrome/browser/bookmarks/recently_used_folders_combo_model_unittest.cc
+++ b/chrome/browser/bookmarks/recently_used_folders_combo_model_unittest.cc
@@ -6,6 +6,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/utf_string_conversions.h"
+#include "chrome/browser/bookmarks/bookmark_model.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/test/base/testing_profile.h"
#include "content/public/test/test_browser_thread.h"