diff options
| author | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-23 03:28:03 +0000 |
|---|---|---|
| committer | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-23 03:28:03 +0000 |
| commit | 32fcf1f67710a2cc2166a6c181383d8b9c2e60e1 (patch) | |
| tree | d54e82cd1dd05c592e6eb9c2e547d5634e8a2778 | |
| parent | 7a51f3646502ebb1a5fa267d534fd87be38df884 (diff) | |
| download | chromium_src-32fcf1f67710a2cc2166a6c181383d8b9c2e60e1.zip chromium_src-32fcf1f67710a2cc2166a6c181383d8b9c2e60e1.tar.gz chromium_src-32fcf1f67710a2cc2166a6c181383d8b9c2e60e1.tar.bz2 | |
Add comment for fix to issue 95619
The fix is very subtle. We need the comment to ensure we don't accidentally
revert the fix. It's also a helpful reminder that we should try to find a less
brittle solution.
BUG=95619
TEST=None
Review URL: http://codereview.chromium.org/7995015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102436 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/sync/profile_sync_service_harness.cc | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/chrome/browser/sync/profile_sync_service_harness.cc b/chrome/browser/sync/profile_sync_service_harness.cc index 0263557..fb9a7e8 100644 --- a/chrome/browser/sync/profile_sync_service_harness.cc +++ b/chrome/browser/sync/profile_sync_service_harness.cc @@ -1030,6 +1030,9 @@ bool ProfileSyncServiceHarness::EnableEncryptionForType( bool ProfileSyncServiceHarness::WaitForTypeEncryption( syncable::ModelType type) { + // The correctness of this if condition depends on the ordering of its + // sub-expressions. See crbug.com/95619. + // TODO(rlarocque): Figure out a less brittle way of detecting this. if (IsTypeEncrypted(type) && IsSynced() && GetLastSessionSnapshot()->num_conflicting_updates == 0) { |