summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorrafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-03 15:05:25 +0000
committerrafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-03 15:05:25 +0000
commit37b031eccf2c14712b396bd7dca270d1eed20e66 (patch)
treebda61625cc7d160b37bd9e6e6e0e3fb76492a38b
parentbb58e6e839255777617a32a77ccb85a9a06ce041 (diff)
downloadchromium_src-37b031eccf2c14712b396bd7dca270d1eed20e66.zip
chromium_src-37b031eccf2c14712b396bd7dca270d1eed20e66.tar.gz
chromium_src-37b031eccf2c14712b396bd7dca270d1eed20e66.tar.bz2
Marking two OptionsUITests (TwoCommandsOneTab & CommandAgainGoesBackToOptionsTab) as DISALBED because of linux/views crashes
TBR=csilv BUG=48521 TEST= Review URL: http://codereview.chromium.org/4370003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64914 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/dom_ui/options/options_ui_uitest.cc21
1 files changed, 18 insertions, 3 deletions
diff --git a/chrome/browser/dom_ui/options/options_ui_uitest.cc b/chrome/browser/dom_ui/options/options_ui_uitest.cc
index 42d00a3..f534f33 100644
--- a/chrome/browser/dom_ui/options/options_ui_uitest.cc
+++ b/chrome/browser/dom_ui/options/options_ui_uitest.cc
@@ -66,7 +66,16 @@ TEST_F(OptionsUITest, CommandOpensOptionsTab) {
}
// TODO(csilv): Investigate why this fails and fix. http://crbug.com/48521
-TEST_F(OptionsUITest, FLAKY_CommandAgainGoesBackToOptionsTab) {
+// Also, crashing on linux/views.
+#if defined(OS_LINUX) && defined(TOOLKIT_VIEWS)
+#define MAYBE_CommandAgainGoesBackToOptionsTab \
+ DISABLED_CommandAgainGoesBackToOptionsTab
+#else
+#define MAYBE_CommandAgainGoesBackToOptionsTab \
+ FLAKY_CommandAgainGoesBackToOptionsTab
+#endif
+
+TEST_F(OptionsUITest, MAYBE_CommandAgainGoesBackToOptionsTab) {
scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
ASSERT_TRUE(browser.get());
@@ -95,8 +104,14 @@ TEST_F(OptionsUITest, FLAKY_CommandAgainGoesBackToOptionsTab) {
}
// TODO(csilv): Investigate why this fails (sometimes) on 10.5 and fix.
-// http://crbug.com/48521
-TEST_F(OptionsUITest, FLAKY_TwoCommandsOneTab) {
+// http://crbug.com/48521. Also, crashing on linux/views.
+#if defined(OS_LINUX) && defined(TOOLKIT_VIEWS)
+#define MAYBE_TwoCommandsOneTab DISABLED_TwoCommandsOneTab
+#else
+#define MAYBE_TwoComamndsOneTab FLAKY_TwoCommandsOneTab
+#endif
+
+TEST_F(OptionsUITest, MAYBE_TwoCommandsOneTab) {
scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
ASSERT_TRUE(browser.get());