diff options
| author | deanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-04 16:43:56 +0000 |
|---|---|---|
| committer | deanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-04 16:43:56 +0000 |
| commit | 6173e8e444cccad9a74f4680bcdd4122fe258d05 (patch) | |
| tree | ad4d7195f4bf14db153dc866e7c0e924158084c2 | |
| parent | 125c9f57343286534a7fccd3c8ab7e4fd4f42957 (diff) | |
| download | chromium_src-6173e8e444cccad9a74f4680bcdd4122fe258d05.zip chromium_src-6173e8e444cccad9a74f4680bcdd4122fe258d05.tar.gz chromium_src-6173e8e444cccad9a74f4680bcdd4122fe258d05.tar.bz2 | |
Try to fix a Purify UMR error. This isn't great, but it's better than nothing.
BUG=8314
Review URL: http://codereview.chromium.org/39125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10889 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/autocomplete/autocomplete_edit_view_win.cc | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_win.cc b/chrome/browser/autocomplete/autocomplete_edit_view_win.cc index 287cfda..307f502 100644 --- a/chrome/browser/autocomplete/autocomplete_edit_view_win.cc +++ b/chrome/browser/autocomplete/autocomplete_edit_view_win.cc @@ -1826,8 +1826,11 @@ void AutocompleteEditViewWin::EmphasizeURLComponents() { ScopedFreeze freeze(this, text_object_model); ScopedSuspendUndo suspend_undo(text_object_model); - // Save the selection. - CHARRANGE saved_sel; + // Save the selection. Bug 8314: Purify started reporting uninitialized + // memory access in saved_sel. This would suggest that GetSelection(), which + // is calling the rich edit's GetSel() is failing. I'm not sure how or why + // this would happen. For now just initialize the CHARRANGE to be safe. + CHARRANGE saved_sel = {0, 0}; GetSelection(saved_sel); // See whether the contents are a URL with a non-empty host portion, which we |