summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-04-29 19:24:05 +0000
committerbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-04-29 19:24:05 +0000
commit7ae2e5e6e6dbc3e706a0dd2efbe1d923e6406bec (patch)
tree61c40ec61ece2067586cd626baafa8a59672f5e4
parentff0811a8763c69ee59e3e6d0421f2f43ced7d41a (diff)
downloadchromium_src-7ae2e5e6e6dbc3e706a0dd2efbe1d923e6406bec.zip
chromium_src-7ae2e5e6e6dbc3e706a0dd2efbe1d923e6406bec.tar.gz
chromium_src-7ae2e5e6e6dbc3e706a0dd2efbe1d923e6406bec.tar.bz2
Revert 266932 "GN build improvements."
> GN build improvements. > > Fixes a TODO about private symbols on GCC. > > Moves many third party BUILD.gn files from the secondary tree to the main one. > > Fixes the dependencies on Linux so "gn check" passes again. > > BUG=367595 > R=scottmg@chromium.org > > Review URL: https://codereview.chromium.org/256153003 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/257243003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266933 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--components/translate/BUILD.gn2
-rw-r--r--net/third_party/nss/ssl/BUILD.gn4
-rw-r--r--tools/gn/secondary/third_party/expat/BUILD.gn (renamed from third_party/expat/BUILD.gn)2
-rw-r--r--tools/gn/secondary/third_party/libevent/BUILD.gn (renamed from third_party/libevent/BUILD.gn)0
-rw-r--r--tools/gn/secondary/third_party/libxml/BUILD.gn (renamed from third_party/libxml/BUILD.gn)0
-rw-r--r--tools/gn/secondary/third_party/mach_override/BUILD.gn (renamed from third_party/mach_override/BUILD.gn)0
-rw-r--r--tools/gn/secondary/third_party/snappy/BUILD.gn (renamed from third_party/snappy/BUILD.gn)0
-rw-r--r--tools/gn/secondary/third_party/wtl/BUILD.gn (renamed from third_party/wtl/BUILD.gn)0
-rw-r--r--tools/gn/secondary/third_party/zlib/BUILD.gn (renamed from third_party/zlib/BUILD.gn)0
-rw-r--r--ui/events/BUILD.gn1
-rw-r--r--ui/gfx/BUILD.gn5
11 files changed, 3 insertions, 11 deletions
diff --git a/components/translate/BUILD.gn b/components/translate/BUILD.gn
index e3f6042..b6134ad 100644
--- a/components/translate/BUILD.gn
+++ b/components/translate/BUILD.gn
@@ -33,9 +33,7 @@ static_library("translate_core_browser") {
deps = [
":translate_core_common",
"//base",
- "//components/language_usage_metrics",
"//components/resources:components_resources",
- "//net",
"//url",
]
}
diff --git a/net/third_party/nss/ssl/BUILD.gn b/net/third_party/nss/ssl/BUILD.gn
index ae3d2c3..bcc3668 100644
--- a/net/third_party/nss/ssl/BUILD.gn
+++ b/net/third_party/nss/ssl/BUILD.gn
@@ -118,8 +118,8 @@ component("libssl") {
forward_dependent_configs_from = deps
}
- if (!is_win && component_mode == "shared_library") {
- configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
+ if (component_mode == "shared_library") {
+ # TODO(brettw) GCC_SYMBOLS_PRIVATE_EXTERN thing.
}
if (is_clang) {
diff --git a/third_party/expat/BUILD.gn b/tools/gn/secondary/third_party/expat/BUILD.gn
index c58b92e..814c336 100644
--- a/third_party/expat/BUILD.gn
+++ b/tools/gn/secondary/third_party/expat/BUILD.gn
@@ -11,7 +11,7 @@ if (is_linux) {
direct_dependent_configs = [ ":expat_config" ]
}
- # TODO(GYP) Android needs direct dependent includes of
+ # TODO(brettw) Android needs direct dependent includes of
# <android_src>/external/expat/lib
} else {
config("expat_config") {
diff --git a/third_party/libevent/BUILD.gn b/tools/gn/secondary/third_party/libevent/BUILD.gn
index 0e3064a..0e3064a 100644
--- a/third_party/libevent/BUILD.gn
+++ b/tools/gn/secondary/third_party/libevent/BUILD.gn
diff --git a/third_party/libxml/BUILD.gn b/tools/gn/secondary/third_party/libxml/BUILD.gn
index e3f26a1..e3f26a1 100644
--- a/third_party/libxml/BUILD.gn
+++ b/tools/gn/secondary/third_party/libxml/BUILD.gn
diff --git a/third_party/mach_override/BUILD.gn b/tools/gn/secondary/third_party/mach_override/BUILD.gn
index f50d3cc..f50d3cc 100644
--- a/third_party/mach_override/BUILD.gn
+++ b/tools/gn/secondary/third_party/mach_override/BUILD.gn
diff --git a/third_party/snappy/BUILD.gn b/tools/gn/secondary/third_party/snappy/BUILD.gn
index 705cb8a..705cb8a 100644
--- a/third_party/snappy/BUILD.gn
+++ b/tools/gn/secondary/third_party/snappy/BUILD.gn
diff --git a/third_party/wtl/BUILD.gn b/tools/gn/secondary/third_party/wtl/BUILD.gn
index 7ebe9d9..7ebe9d9 100644
--- a/third_party/wtl/BUILD.gn
+++ b/tools/gn/secondary/third_party/wtl/BUILD.gn
diff --git a/third_party/zlib/BUILD.gn b/tools/gn/secondary/third_party/zlib/BUILD.gn
index 323ff86..323ff86 100644
--- a/third_party/zlib/BUILD.gn
+++ b/tools/gn/secondary/third_party/zlib/BUILD.gn
diff --git a/ui/events/BUILD.gn b/ui/events/BUILD.gn
index 31ac30a..a6061ed 100644
--- a/ui/events/BUILD.gn
+++ b/ui/events/BUILD.gn
@@ -41,7 +41,6 @@ component("events_base") {
":dom4_keycode_converter",
"//base",
"//base/third_party/dynamic_annotations",
- "//ui/gfx",
"//ui/gfx/geometry",
]
diff --git a/ui/gfx/BUILD.gn b/ui/gfx/BUILD.gn
index c7c470a..7833945 100644
--- a/ui/gfx/BUILD.gn
+++ b/ui/gfx/BUILD.gn
@@ -456,10 +456,5 @@ if (use_x11) {
]
configs += [ "//build/config/linux:x11" ]
-
- deps = [
- ":gfx_export",
- "//base"
- ]
}
}