summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorcpu@chromium.org <cpu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-09-17 22:31:04 +0000
committercpu@chromium.org <cpu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-09-17 22:31:04 +0000
commit7d7f40d9800413111f4dc3a61a5e1df23c6f513e (patch)
treeb08933b123aea35deff0fb22321c78f791509ff7
parent7c649269e9632280504809633dbf9d7765cdddd1 (diff)
downloadchromium_src-7d7f40d9800413111f4dc3a61a5e1df23c6f513e.zip
chromium_src-7d7f40d9800413111f4dc3a61a5e1df23c6f513e.tar.gz
chromium_src-7d7f40d9800413111f4dc3a61a5e1df23c6f513e.tar.bz2
Prevent extensions from changing the window properties
- Silently ignore the request, returning 'success'. BUG=146504 TEST=see bug Review URL: https://codereview.chromium.org/10913303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157222 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/extensions/api/tabs/tabs.cc8
1 files changed, 8 insertions, 0 deletions
diff --git a/chrome/browser/extensions/api/tabs/tabs.cc b/chrome/browser/extensions/api/tabs/tabs.cc
index 3775511..183d12b 100644
--- a/chrome/browser/extensions/api/tabs/tabs.cc
+++ b/chrome/browser/extensions/api/tabs/tabs.cc
@@ -660,6 +660,14 @@ bool UpdateWindowFunction::RunImpl() {
if (!GetWindowFromWindowID(this, window_id, &controller))
return false;
+#if defined(OS_WIN)
+ // Silently ignore changes on the window for metro mode.
+ if (base::win::IsMetroProcess()) {
+ SetResult(controller->CreateWindowValue());
+ return true;
+ }
+#endif
+
ui::WindowShowState show_state = ui::SHOW_STATE_DEFAULT; // No change.
std::string state_str;
if (update_props->HasKey(keys::kShowStateKey)) {