summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormmenke@chromium.org <mmenke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-02-01 15:02:52 +0000
committermmenke@chromium.org <mmenke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-02-01 15:02:52 +0000
commit88b5a92847caf1a3b90d6b54ea400651be80b21e (patch)
treef66dea64e9ff4d0ae6aa6e219f99eb07177ff9bb
parent3f474580142729e04a288e5c652907c8bdad59ff (diff)
downloadchromium_src-88b5a92847caf1a3b90d6b54ea400651be80b21e.zip
chromium_src-88b5a92847caf1a3b90d6b54ea400651be80b21e.tar.gz
chromium_src-88b5a92847caf1a3b90d6b54ea400651be80b21e.tar.bz2
Adds basic error text for all errors with a 1% or greater
frequency on the dev channel build. The text for most of the errors isn't terribly useful, but the default "Unkown Error" is a little embarrassing. Also nice to get the error descriptions internationalized. BUG=55726 TEST=none Review URL: http://codereview.chromium.org/6392030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73286 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/app/generated_resources.grd36
-rw-r--r--chrome/renderer/localized_error.cc37
2 files changed, 71 insertions, 2 deletions
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index dcf5141..826657f 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -5811,6 +5811,9 @@ Keep your key file in a safe place. You will need it to create new versions of y
<message name="IDS_ERRORPAGES_HEADING_INTERNET_DISCONNECTED" desc="Heading of the error page when the network connection failed.">
Unable to connect to the Internet
</message>
+ <message name="IDS_ERRORPAGES_HEADING_CACHE_MISS" desc="Heading in the error page when we couldn't find a resource in the cache, and cannot fall back to the network.">
+ Cache miss
+ </message>
<message name="IDS_ERRORPAGES_HEADING_CACHE_READ_FAILURE" desc="Heading in the error page when we encountered an error reading from the cache. Generally this happens when the disk cache is corrupted from improper shutdown.">
Cache read error
</message>
@@ -5823,6 +5826,9 @@ Keep your key file in a safe place. You will need it to create new versions of y
<message name="IDS_ERRORPAGES_HEADING_TOO_MANY_REDIRECTS" desc="Heading in the error page when there are too many URL redirects.">
This webpage has a redirect loop
</message>
+ <message name="IDS_ERRORPAGES_HEADING_EMPTY_RESPONSE" desc="Heading in the error page when no data is received.">
+ No data received
+ </message>
<message name="IDS_ERRORPAGES_HEADING_WEAK_SERVER_EPHEMERAL_DH_KEY" desc="Heading of the error page when the server has a weak Diffie-Hellman public key. Diffie-Hellman is a technical term and the conjuction of two names so may be best left untranslated. 'key' here is used as the technical name for a large number with certain mathematical properties that allow it to be used to encrypt and decrypt data. 'weak' here means that the number is too small to resist an exhaustive attempt to find certain mathematical structures in it, the secrecy of which is critical.">
Server has a weak ephemeral Diffie-Hellman public key
</message>
@@ -5902,6 +5908,16 @@ Keep your key file in a safe place. You will need it to create new versions of y
</message>
</if>
+ <message name="IDS_ERRORPAGES_SUMMARY_CACHE_MISS" desc="Summary in the error page when we couldn't find a resource in the cache, and cannot fall back to the network.">
+ The webpage was not found in the cache. Certain resources
+ can only be safely loaded from the cache, such as pages generated
+ from submitted data.
+ <ph name="LINE_BREAK">&lt;br /&gt;&lt;br /&gt;</ph>
+ This error can also be caused by cache corruption due to
+ an improper shutdown.
+ <ph name="LINE_BREAK">&lt;br /&gt;&lt;br /&gt;</ph>
+ If the problem persists, try clearing the cache.
+ </message>
<message name="IDS_ERRORPAGES_SUMMARY_CACHE_READ_FAILURE" desc="Summary in the error page when we encountered an error reading from the cache. Generally this happens when the disk cache is corrupted from improper shutdown.">
To speed up webpages,
<ph name="PRODUCT_NAME">&lt;span jscontent="productName"&gt;&lt;/span&gt;<ex>Google Chrome</ex></ph>
@@ -5929,6 +5945,9 @@ Keep your key file in a safe place. You will need it to create new versions of y
not, it is possibly a server configuration issue and not a problem with your
computer.
</message>
+ <message name="IDS_ERRORPAGES_SUMMARY_EMPTY_RESPONSE" desc="Summary in the error page when no data is received.">
+ Unable to load the webpage because the server sent no data.
+ </message>
<message name="IDS_ERRORPAGES_SUMMARY_WEAK_SERVER_EPHEMERAL_DH_KEY" desc="Summary in the error page when the server has a weak Diffie-Hellman public key">
This error can occur when connecting to a secure (HTTPS) server. It
means that the server is trying to set up a secure connection but, due to
@@ -5967,7 +5986,16 @@ Keep your key file in a safe place. You will need it to create new versions of y
<message name="IDS_ERRORPAGES_DETAILS_TIMED_OUT" desc="The error message displayed when a page takes too long to load.">
The operation timed out.
</message>
- <message name="IDS_ERRORPAGES_DETAILS_CONNECT_FAILED" desc="The error message displayed when we can not reach the web site.">
+ <message name="IDS_ERRORPAGES_DETAILS_CONNECTION_CLOSED" desc="The error message displayed when the server unexpectedly closes a connection.">
+ The server unexpectedly closed the connection.
+ </message>
+ <message name="IDS_ERRORPAGES_DETAILS_CONNECTION_RESET" desc="The error message displayed when a connection was reset.">
+ The connection was reset.
+ </message>
+ <message name="IDS_ERRORPAGES_DETAILS_CONNECTION_REFUSED" desc="The error message displayed a connection attempt is refused.">
+ The server refused the connection.
+ </message>
+ <message name="IDS_ERRORPAGES_DETAILS_CONNECTION_FAILED" desc="The error message displayed when we can not reach the web site.">
The attempt to connect to the server failed.
</message>
<message name="IDS_ERRORPAGES_DETAILS_NAME_NOT_RESOLVED" desc="The error message displayed when a dns look up fails.">
@@ -5988,6 +6016,9 @@ Keep your key file in a safe place. You will need it to create new versions of y
<message name="IDS_ERRORPAGES_DETAILS_CACHE_READ_FAILURE" desc="The error message displayed when we encountered an error reading from the cache. Generally this happens when the disk cache is corrupted from improper shutdown.">
Error reading data from cache.
</message>
+ <message name="IDS_ERRORPAGES_DETAILS_CACHE_MISS" desc="The error message displayed when we couldn't find a resource in the cache, and cannot fall back to the network.">
+ The requested entry was not found in the cache.
+ </message>
<message name="IDS_ERRORPAGES_DETAILS_NETWORK_IO_SUSPENDED" desc="The error message displayed when a page load failed due to the computer entering sleep/suspend mode.">
Network IO suspended.
</message>
@@ -5997,6 +6028,9 @@ Keep your key file in a safe place. You will need it to create new versions of y
<message name="IDS_ERRORPAGES_DETAILS_TOO_MANY_REDIRECTS" desc="The error message displayed when there are too many redirects.">
There were too many redirects.
</message>
+ <message name="IDS_ERRORPAGES_DETAILS_EMPTY_RESPONSE" desc="The error message displayed when no data is received.">
+ The server closed the connection without sending any data.
+ </message>
<message name="IDS_ERRORPAGES_DETAILS_UNKNOWN" desc="The default error message displayed if we don't have a more specific error message.">
Unknown error.
</message>
diff --git a/chrome/renderer/localized_error.cc b/chrome/renderer/localized_error.cc
index 7350b34..9ccc11b 100644
--- a/chrome/renderer/localized_error.cc
+++ b/chrome/renderer/localized_error.cc
@@ -65,11 +65,32 @@ const LocalizedErrorMap net_error_options[] = {
IDS_ERRORPAGES_DETAILS_TIMED_OUT,
SUGGEST_RELOAD,
},
+ {net::ERR_CONNECTION_CLOSED,
+ IDS_ERRORPAGES_TITLE_NOT_AVAILABLE,
+ IDS_ERRORPAGES_HEADING_NOT_AVAILABLE,
+ IDS_ERRORPAGES_SUMMARY_NOT_AVAILABLE,
+ IDS_ERRORPAGES_DETAILS_CONNECTION_CLOSED,
+ SUGGEST_RELOAD,
+ },
+ {net::ERR_CONNECTION_RESET,
+ IDS_ERRORPAGES_TITLE_NOT_AVAILABLE,
+ IDS_ERRORPAGES_HEADING_NOT_AVAILABLE,
+ IDS_ERRORPAGES_SUMMARY_NOT_AVAILABLE,
+ IDS_ERRORPAGES_DETAILS_CONNECTION_RESET,
+ SUGGEST_RELOAD,
+ },
+ {net::ERR_CONNECTION_REFUSED,
+ IDS_ERRORPAGES_TITLE_NOT_AVAILABLE,
+ IDS_ERRORPAGES_HEADING_NOT_AVAILABLE,
+ IDS_ERRORPAGES_SUMMARY_NOT_AVAILABLE,
+ IDS_ERRORPAGES_DETAILS_CONNECTION_REFUSED,
+ SUGGEST_RELOAD,
+ },
{net::ERR_CONNECTION_FAILED,
IDS_ERRORPAGES_TITLE_NOT_AVAILABLE,
IDS_ERRORPAGES_HEADING_NOT_AVAILABLE,
IDS_ERRORPAGES_SUMMARY_NOT_AVAILABLE,
- IDS_ERRORPAGES_DETAILS_CONNECT_FAILED,
+ IDS_ERRORPAGES_DETAILS_CONNECTION_FAILED,
SUGGEST_RELOAD,
},
{net::ERR_NAME_NOT_RESOLVED,
@@ -114,6 +135,13 @@ const LocalizedErrorMap net_error_options[] = {
IDS_ERRORPAGES_DETAILS_FILE_NOT_FOUND,
SUGGEST_NONE,
},
+ {net::ERR_CACHE_MISS,
+ IDS_ERRORPAGES_TITLE_LOAD_FAILED,
+ IDS_ERRORPAGES_HEADING_CACHE_MISS,
+ IDS_ERRORPAGES_SUMMARY_CACHE_MISS,
+ IDS_ERRORPAGES_DETAILS_CACHE_MISS,
+ SUGGEST_RELOAD,
+ },
{net::ERR_CACHE_READ_FAILURE,
IDS_ERRORPAGES_TITLE_LOAD_FAILED,
IDS_ERRORPAGES_HEADING_CACHE_READ_FAILURE,
@@ -135,6 +163,13 @@ const LocalizedErrorMap net_error_options[] = {
IDS_ERRORPAGES_DETAILS_TOO_MANY_REDIRECTS,
SUGGEST_RELOAD | SUGGEST_LEARNMORE,
},
+ {net::ERR_EMPTY_RESPONSE,
+ IDS_ERRORPAGES_TITLE_LOAD_FAILED,
+ IDS_ERRORPAGES_HEADING_EMPTY_RESPONSE,
+ IDS_ERRORPAGES_SUMMARY_EMPTY_RESPONSE,
+ IDS_ERRORPAGES_DETAILS_EMPTY_RESPONSE,
+ SUGGEST_RELOAD,
+ },
{net::ERR_SSL_PROTOCOL_ERROR,
IDS_ERRORPAGES_TITLE_LOAD_FAILED,
IDS_ERRORPAGES_HEADING_SSL_PROTOCOL_ERROR,