diff options
| author | rkc@chromium.org <rkc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-09 21:59:06 +0000 |
|---|---|---|
| committer | rkc@chromium.org <rkc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-09 21:59:06 +0000 |
| commit | 89e09aeb12b3665e547f286ccc267ed35732e627 (patch) | |
| tree | 0685eeab84df9663b33b03dadb420656b8eb1314 | |
| parent | 112b6f7e9e5b8a3cbfdf404bc4664b9b9b42a10b (diff) | |
| download | chromium_src-89e09aeb12b3665e547f286ccc267ed35732e627.zip chromium_src-89e09aeb12b3665e547f286ccc267ed35732e627.tar.gz chromium_src-89e09aeb12b3665e547f286ccc267ed35732e627.tar.bz2 | |
Fix Feedback to use it's own profile in incognito/guest sessions and not redirect to the default profile. Also requires the extension to be loaded in split mode for incognito.
R=asargent@chromium.org, xiyuan@chromium.org
BUG=331197
Review URL: https://codereview.chromium.org/130233002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243987 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/extensions/api/feedback_private/feedback_private_api.h | 2 | ||||
| -rw-r--r-- | chrome/browser/resources/feedback/manifest.json | 1 |
2 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.h b/chrome/browser/extensions/api/feedback_private/feedback_private_api.h index e11808e..5740af5 100644 --- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.h +++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.h @@ -39,7 +39,7 @@ class FeedbackPrivateAPI : public ProfileKeyedAPI { return "FeedbackPrivateAPI"; } - static const bool kServiceRedirectedInIncognito = true; + static const bool kServiceHasOwnInstanceInIncognito = true; Profile* const profile_; FeedbackService* service_; diff --git a/chrome/browser/resources/feedback/manifest.json b/chrome/browser/resources/feedback/manifest.json index 5513646..4f94ae3 100644 --- a/chrome/browser/resources/feedback/manifest.json +++ b/chrome/browser/resources/feedback/manifest.json @@ -4,6 +4,7 @@ "name": "Feedback", "version": "1.0", "manifest_version": 2, + "incognito" : "split", "description": "User feedback extension", "icons": { "32": "images/icon32.png", |