diff options
| author | kristianm@chromium.org <kristianm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-11 08:53:33 +0000 |
|---|---|---|
| committer | kristianm@chromium.org <kristianm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-11 08:53:33 +0000 |
| commit | 90a2dfbe6b2628fdb87c33fc12b9c0b45fccea0d (patch) | |
| tree | 44b97927265b8abb4aa1d70f3ca5e755f0cf0a2f | |
| parent | cff7b7b50c63dc3b03cc49e6c0ba999d5e51da4a (diff) | |
| download | chromium_src-90a2dfbe6b2628fdb87c33fc12b9c0b45fccea0d.zip chromium_src-90a2dfbe6b2628fdb87c33fc12b9c0b45fccea0d.tar.gz chromium_src-90a2dfbe6b2628fdb87c33fc12b9c0b45fccea0d.tar.bz2 | |
Fix findbugs issues
Constants should be private static final.
Since I'm there, renamed TAG to LOGTAG so it is obvious it is only used for logging.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11827057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176288 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | build/android/findbugs_filter/findbugs_known_bugs.txt | 2 | ||||
| -rw-r--r-- | testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java | 6 |
2 files changed, 3 insertions, 5 deletions
diff --git a/build/android/findbugs_filter/findbugs_known_bugs.txt b/build/android/findbugs_filter/findbugs_known_bugs.txt index a589e7c..d14dfab 100644 --- a/build/android/findbugs_filter/findbugs_known_bugs.txt +++ b/build/android/findbugs_filter/findbugs_known_bugs.txt @@ -109,8 +109,6 @@ M P SIC: Should org.chromium.content.browser.JavaBridgeReturnValuesTest$CustomTy M P SIC: Should org.chromium.content.browser.PopupZoomerTest$CustomCanvasPopupZoomer be a _static_ inner class? At PopupZoomerTest.java M P SS: Unread field: org.chromium.android_webview.test.util.ImagePageGenerator.IMAGE_PREFIX; should this field be static? At ImagePageGenerator.java M P SS: Unread field: org.chromium.android_webview.test.util.ImagePageGenerator.IMAGE_SUFFIX; should this field be static? At ImagePageGenerator.java -M P SS: Unread field: org.chromium.native_test.ChromeNativeTestActivity.EXTRA_RUN_IN_SUB_THREAD; should this field be static? At ChromeNativeTestActivity.java -M P SS: Unread field: org.chromium.native_test.ChromeNativeTestActivity.TAG; should this field be static? At ChromeNativeTestActivity.java M P UrF: Unread field: org.chromium.content.browser.ContentViewGestureHandlerTest$MockListener.mLastFling2 At ContentViewGestureHandlerTest.java M P UrF: Unread field: org.chromium.content.browser.ContentViewGestureHandlerTest$MockListener.mLastScroll1 At ContentViewGestureHandlerTest.java M P UrF: Unread field: org.chromium.content.browser.ContentViewGestureHandlerTest$MockListener.mLastScroll2 At ContentViewGestureHandlerTest.java diff --git a/testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java b/testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java index fef3dce..490ed14 100644 --- a/testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java +++ b/testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java @@ -21,10 +21,10 @@ import java.io.File; // Our tests need to go up to our own java classes, which is not possible using // the native activity class loader. public class ChromeNativeTestActivity extends ChromiumActivity { - private final String TAG = "ChromeNativeTestActivity"; - private final String EXTRA_RUN_IN_SUB_THREAD = "RunInSubThread"; + private static final String TAG = "ChromeNativeTestActivity"; + private static final String EXTRA_RUN_IN_SUB_THREAD = "RunInSubThread"; // We post a delayed task to run tests so that we do not block onCreate(). - private static long RUN_TESTS_DELAY_IN_MS = 300; + private static final long RUN_TESTS_DELAY_IN_MS = 300; // Name of our shlib as obtained from a string resource. private String mLibrary; |