diff options
| author | binji@chromium.org <binji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-31 21:42:22 +0000 |
|---|---|---|
| committer | binji@chromium.org <binji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-31 21:42:22 +0000 |
| commit | a654e2a5753040fa93792f9cfbe7661731da2920 (patch) | |
| tree | 2c6780ed0812a846492aaa2f8dc5e679306b16bf | |
| parent | c020ea3de4bd73e4122c1827709561af51980dbd (diff) | |
| download | chromium_src-a654e2a5753040fa93792f9cfbe7661731da2920.zip chromium_src-a654e2a5753040fa93792f9cfbe7661731da2920.tar.gz chromium_src-a654e2a5753040fa93792f9cfbe7661731da2920.tar.bz2 | |
[Web UI Options] For overlays that have >1 button-strip, reverse order of all (in views).
BUG=102303
TEST=Run views chrome. Go to chrome://settings/personal. Sign in to sync. Click "Advanced". OK button should be on left. In non-views chrome (mac, linux), OK button should be on right.
Review URL: http://codereview.chromium.org/8387033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108014 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/resources/options/options_page.js | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/chrome/browser/resources/options/options_page.js b/chrome/browser/resources/options/options_page.js index 2e463bd..e88b240 100644 --- a/chrome/browser/resources/options/options_page.js +++ b/chrome/browser/resources/options/options_page.js @@ -481,15 +481,16 @@ cr.define('options', function() { * @private */ OptionsPage.reverseButtonStrip_ = function(overlay) { - var buttonStrip = overlay.pageDiv.querySelector('.button-strip'); + var buttonStrips = overlay.pageDiv.querySelectorAll('.button-strip'); - // Not all overlays have button strips. - if (!buttonStrip) - return; + // Reverse all button-strips in the overlay. + for (var j = 0; j < buttonStrips.length; j++) { + var buttonStrip = buttonStrips[j]; - var childNodes = buttonStrip.childNodes; - for (var i = childNodes.length - 1; i >= 0; i--) - buttonStrip.appendChild(childNodes[i]); + var childNodes = buttonStrip.childNodes; + for (var i = childNodes.length - 1; i >= 0; i--) + buttonStrip.appendChild(childNodes[i]); + } }; /** |