summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoravi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-10-18 22:19:25 +0000
committeravi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-10-18 22:19:25 +0000
commitb2b8da61e2c6730db4888948e8f16bf6cc1a9d64 (patch)
treea17f2c86702c8d2e91707f0bd0f8ba0669255eb1
parent931d29efc866519f43919a693c864a3e01ad5870 (diff)
downloadchromium_src-b2b8da61e2c6730db4888948e8f16bf6cc1a9d64.zip
chromium_src-b2b8da61e2c6730db4888948e8f16bf6cc1a9d64.tar.gz
chromium_src-b2b8da61e2c6730db4888948e8f16bf6cc1a9d64.tar.bz2
Remove TabContents from ContentSettingImageModelTest.
BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/11191064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162813 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/ui/content_settings/content_setting_image_model.cc6
-rw-r--r--chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc19
2 files changed, 13 insertions, 12 deletions
diff --git a/chrome/browser/ui/content_settings/content_setting_image_model.cc b/chrome/browser/ui/content_settings/content_setting_image_model.cc
index 7673a8b..a5673f2 100644
--- a/chrome/browser/ui/content_settings/content_setting_image_model.cc
+++ b/chrome/browser/ui/content_settings/content_setting_image_model.cc
@@ -8,7 +8,6 @@
#include "chrome/browser/content_settings/tab_specific_content_settings.h"
#include "chrome/browser/prerender/prerender_manager.h"
#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/ui/tab_contents/tab_contents.h"
#include "content/public/browser/web_contents.h"
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
@@ -106,12 +105,13 @@ void ContentSettingBlockedImageModel::UpdateFromWebContents(
// If a content type is blocked by default and was accessed, display the
// accessed icon.
- TabContents* tab_contents = TabContents::FromWebContents(web_contents);
TabSpecificContentSettings* content_settings =
TabSpecificContentSettings::FromWebContents(web_contents);
+ Profile* profile =
+ Profile::FromBrowserContext(web_contents->GetBrowserContext());
if (!content_settings->IsContentBlocked(get_content_settings_type())) {
if (!content_settings->IsContentAccessed(get_content_settings_type()) ||
- (tab_contents->profile()->GetHostContentSettingsMap()->
+ (profile->GetHostContentSettingsMap()->
GetDefaultContentSetting(get_content_settings_type(), NULL) !=
CONTENT_SETTING_BLOCK))
return;
diff --git a/chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc b/chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc
index 543a0ce..d254919 100644
--- a/chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc
+++ b/chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc
@@ -8,9 +8,8 @@
#include "chrome/browser/prerender/prerender_manager.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/content_settings/content_setting_image_model.h"
-#include "chrome/browser/ui/tab_contents/tab_contents.h"
-#include "chrome/browser/ui/tab_contents/test_tab_contents.h"
#include "chrome/test/base/testing_profile.h"
+#include "chrome/test/base/chrome_render_view_host_test_harness.h"
#include "content/public/test/test_browser_thread.h"
#include "content/public/test/test_renderer_host.h"
#include "net/cookies/cookie_options.h"
@@ -18,12 +17,17 @@
using content::BrowserThread;
-class ContentSettingImageModelTest : public TabContentsTestHarness {
+class ContentSettingImageModelTest : public ChromeRenderViewHostTestHarness {
public:
ContentSettingImageModelTest()
: ui_thread_(BrowserThread::UI, &message_loop_) {}
private:
+ virtual void SetUp() OVERRIDE {
+ ChromeRenderViewHostTestHarness::SetUp();
+ TabSpecificContentSettings::CreateForWebContents(web_contents());
+ }
+
content::TestBrowserThread ui_thread_;
DISALLOW_COPY_AND_ASSIGN(ContentSettingImageModelTest);
@@ -31,8 +35,7 @@ class ContentSettingImageModelTest : public TabContentsTestHarness {
TEST_F(ContentSettingImageModelTest, UpdateFromWebContents) {
TabSpecificContentSettings* content_settings =
- TabSpecificContentSettings::FromWebContents(
- tab_contents()->web_contents());
+ TabSpecificContentSettings::FromWebContents(web_contents());
scoped_ptr<ContentSettingImageModel> content_setting_image_model(
ContentSettingImageModel::CreateContentSettingImageModel(
CONTENT_SETTINGS_TYPE_IMAGES));
@@ -57,8 +60,7 @@ TEST_F(ContentSettingImageModelTest, RPHUpdateFromWebContents) {
EXPECT_FALSE(content_setting_image_model->is_visible());
TabSpecificContentSettings* content_settings =
- TabSpecificContentSettings::FromWebContents(
- tab_contents()->web_contents());
+ TabSpecificContentSettings::FromWebContents(web_contents());
content_settings->set_pending_protocol_handler(
ProtocolHandler::CreateProtocolHandler(
"mailto", GURL("http://www.google.com/"), ASCIIToUTF16("Handler")));
@@ -68,8 +70,7 @@ TEST_F(ContentSettingImageModelTest, RPHUpdateFromWebContents) {
TEST_F(ContentSettingImageModelTest, CookieAccessed) {
TabSpecificContentSettings* content_settings =
- TabSpecificContentSettings::FromWebContents(
- tab_contents()->web_contents());
+ TabSpecificContentSettings::FromWebContents(web_contents());
profile()->GetHostContentSettingsMap()->SetDefaultContentSetting(
CONTENT_SETTINGS_TYPE_COOKIES, CONTENT_SETTING_BLOCK);
scoped_ptr<ContentSettingImageModel> content_setting_image_model(