Coverity: Initialize member variables.

CID_COUNT=23
CID=100941,100986,100987,101015,101016,101017,101227,101229,101230,101332,101333,101334,101335,101336,101337,101355,101356,101359,101362,101363,101381,101389,101417
BUG=none
TEST=none

R=kmadhusu@chromium.org

Review URL: http://codereview.chromium.org/7780013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100774 0039d316-1c4b-4281-b951-d872f2087c98

29 files changed, 62 insertions, 22 deletions

diff --git a/chrome/browser/autofill/autofill_field.cc b/chrome/browser/autofill/autofill_field.cc
index 9b42589..6716c65 100644
--- a/chrome/browser/autofill/autofill_field.cc
+++ b/chrome/browser/autofill/autofill_field.cc
@@ -27,7 +27,8 @@ static std::string Hash32Bit(const std::string& str) {
 
 AutofillField::AutofillField()
     : server_type_(NO_SERVER_DATA),
-      heuristic_type_(UNKNOWN_TYPE) {
+      heuristic_type_(UNKNOWN_TYPE),
+      phone_part_(IGNORED) {
 }
 
 AutofillField::AutofillField(const webkit_glue::FormField& field,
diff --git a/chrome/browser/extensions/extension_install_ui.cc b/chrome/browser/extensions/extension_install_ui.cc
index 74d2eb0..5dabef3 100644
--- a/chrome/browser/extensions/extension_install_ui.cc
+++ b/chrome/browser/extensions/extension_install_ui.cc
@@ -78,7 +78,10 @@ const int kIconSize = 69;
 
 }  // namespace
 
-ExtensionInstallUI::Prompt::Prompt(PromptType type) : type_(type) {
+ExtensionInstallUI::Prompt::Prompt(PromptType type)
+    : type_(type),
+      average_rating_(0.0),
+      rating_count_(0) {
 }
 
 ExtensionInstallUI::Prompt::~Prompt() {
diff --git a/chrome/browser/extensions/extension_management_api.cc b/chrome/browser/extensions/extension_management_api.cc
index 67622cb..5efce86 100644
--- a/chrome/browser/extensions/extension_management_api.cc
+++ b/chrome/browser/extensions/extension_management_api.cc
@@ -198,7 +198,8 @@ class SafeManifestJSONParser : public UtilityProcessHost::Client {
   SafeManifestJSONParser(GetPermissionWarningsByManifestFunction* client,
                  const std::string& manifest)
       : client_(client),
-        manifest_(manifest) {}
+        manifest_(manifest),
+        utility_host_(NULL) {}
 
   void Start() {
     CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
diff --git a/chrome/browser/extensions/webstore_inline_installer.cc b/chrome/browser/extensions/webstore_inline_installer.cc
index 2767783..7db795f 100644
--- a/chrome/browser/extensions/webstore_inline_installer.cc
+++ b/chrome/browser/extensions/webstore_inline_installer.cc
@@ -140,7 +140,9 @@ WebstoreInlineInstaller::WebstoreInlineInstaller(TabContents* tab_contents,
       install_id_(install_id),
       id_(webstore_item_id),
       requestor_url_(requestor_url),
-      delegate_(delegate) {}
+      delegate_(delegate),
+      average_rating_(0.0),
+      rating_count_(0) {}
 
 WebstoreInlineInstaller::~WebstoreInlineInstaller() {
 }
diff --git a/chrome/browser/plugin_prefs.cc b/chrome/browser/plugin_prefs.cc
index 28468b2..6850d60 100644
--- a/chrome/browser/plugin_prefs.cc
+++ b/chrome/browser/plugin_prefs.cc
@@ -359,7 +359,7 @@ ProfileKeyedService* PluginPrefs::Factory::BuildServiceInstanceFor(
   return new PluginPrefsWrapper(plugin_prefs);
 }
 
-PluginPrefs::PluginPrefs() : notify_pending_(false) {
+PluginPrefs::PluginPrefs() : prefs_(NULL), notify_pending_(false) {
 }
 
 PluginPrefs::~PluginPrefs() {
diff --git a/chrome/browser/policy/policy_status_info.cc b/chrome/browser/policy/policy_status_info.cc
index e2fdc00..16bb8d7 100644
--- a/chrome/browser/policy/policy_status_info.cc
+++ b/chrome/browser/policy/policy_status_info.cc
@@ -19,7 +19,10 @@ const std::string PolicyStatusInfo::kStatusDictPath = "status";
 const std::string PolicyStatusInfo::kValueDictPath = "value";
 
 // PolicyStatusInfo
-PolicyStatusInfo::PolicyStatusInfo() {
+PolicyStatusInfo::PolicyStatusInfo()
+    : source_type(SOURCE_TYPE_UNDEFINED),
+      level(LEVEL_UNDEFINED),
+      status(STATUS_UNDEFINED) {
 }
 
 PolicyStatusInfo::PolicyStatusInfo(
diff --git a/chrome/browser/printing/print_dialog_cloud.cc b/chrome/browser/printing/print_dialog_cloud.cc
index b656ff4..eb504a8 100644
--- a/chrome/browser/printing/print_dialog_cloud.cc
+++ b/chrome/browser/printing/print_dialog_cloud.cc
@@ -244,7 +244,8 @@ CloudPrintFlowHandler::CloudPrintFlowHandler(const FilePath& path_to_file,
                                              const string16& print_job_title,
                                              const string16& print_ticket,
                                              const std::string& file_type)
-    : path_to_file_(path_to_file),
+    : dialog_delegate_(NULL),
+      path_to_file_(path_to_file),
       print_job_title_(print_job_title),
       print_ticket_(print_ticket),
       file_type_(file_type) {
diff --git a/chrome/browser/profiles/avatar_menu_model.cc b/chrome/browser/profiles/avatar_menu_model.cc
index 7c665d3..4f18836 100644
--- a/chrome/browser/profiles/avatar_menu_model.cc
+++ b/chrome/browser/profiles/avatar_menu_model.cc
@@ -64,6 +64,7 @@ AvatarMenuModel::~AvatarMenuModel() {
 
 AvatarMenuModel::Item::Item(size_t model_index, const gfx::Image& icon)
     : icon(icon),
+      active(false),
       model_index(model_index) {
 }
 
diff --git a/chrome/browser/speech/chrome_speech_input_manager.cc b/chrome/browser/speech/chrome_speech_input_manager.cc
index a75880a..2eb7f06 100644
--- a/chrome/browser/speech/chrome_speech_input_manager.cc
+++ b/chrome/browser/speech/chrome_speech_input_manager.cc
@@ -84,7 +84,9 @@ class ChromeSpeechInputManager::OptionalRequestInfo
   DISALLOW_COPY_AND_ASSIGN(OptionalRequestInfo);
 };
 
-ChromeSpeechInputManager::SpeechInputRequest::SpeechInputRequest() {
+ChromeSpeechInputManager::SpeechInputRequest::SpeechInputRequest()
+    : delegate(NULL),
+      is_active(false) {
 }
 
 ChromeSpeechInputManager::SpeechInputRequest::~SpeechInputRequest() {
diff --git a/chrome/browser/sync/glue/synced_session.cc b/chrome/browser/sync/glue/synced_session.cc
index 18011c8..b1b3c30 100644
--- a/chrome/browser/sync/glue/synced_session.cc
+++ b/chrome/browser/sync/glue/synced_session.cc
@@ -9,7 +9,8 @@
 
 namespace browser_sync {
 
-SyncedSession::SyncedSession() : session_tag("invalid") {
+SyncedSession::SyncedSession() : session_tag("invalid"),
+                                 device_type(TYPE_UNSET) {
 }
 
 SyncedSession::~SyncedSession() {
diff --git a/chrome/browser/sync/glue/synced_session.h b/chrome/browser/sync/glue/synced_session.h
index fcac6ecd..00f956b 100644
--- a/chrome/browser/sync/glue/synced_session.h
+++ b/chrome/browser/sync/glue/synced_session.h
@@ -19,6 +19,7 @@ namespace browser_sync {
 struct SyncedSession {
   // The type of device.
   enum DeviceType {
+    TYPE_UNSET = 0,
     TYPE_WIN = 1,
     TYPE_MACOSX = 2,
     TYPE_LINUX = 3,
diff --git a/chrome/browser/sync/retry_verifier.cc b/chrome/browser/sync/retry_verifier.cc
index 9d6e1e4..5cb73ca 100644
--- a/chrome/browser/sync/retry_verifier.cc
+++ b/chrome/browser/sync/retry_verifier.cc
@@ -71,6 +71,7 @@ bool IsRetryOnTime(DelayInfo* delay_table, int retry_count,
 RetryVerifier::RetryVerifier() : retry_count_(0),
                                  success_(false),
                                  done_(false) {
+  memset(&delay_table_, 0, sizeof(delay_table_));
 }
 
 RetryVerifier::~RetryVerifier() {
diff --git a/chrome/browser/ui/gtk/download/download_started_animation_gtk.cc b/chrome/browser/ui/gtk/download/download_started_animation_gtk.cc
index 51e9abf..47e1141 100644
--- a/chrome/browser/ui/gtk/download/download_started_animation_gtk.cc
+++ b/chrome/browser/ui/gtk/download/download_started_animation_gtk.cc
@@ -80,6 +80,7 @@ class DownloadStartedAnimationGtk : public ui::LinearAnimation,
 DownloadStartedAnimationGtk::DownloadStartedAnimationGtk(
     TabContents* tab_contents)
     : ui::LinearAnimation(kMoveTimeMs, kFrameRateHz, NULL),
+      popup_(NULL),
       tab_contents_(tab_contents) {
   static GdkPixbuf* kDownloadImage = NULL;
   if (!kDownloadImage) {
@@ -136,6 +137,8 @@ void DownloadStartedAnimationGtk::Reposition() {
   if (!tab_contents_)
     return;
 
+  DCHECK(popup_);
+
   // Align the image with the bottom left of the web contents (so that it
   // points to the newly created download).
   gtk_window_move(GTK_WINDOW(popup_),
@@ -148,6 +151,8 @@ void DownloadStartedAnimationGtk::Close() {
   if (!tab_contents_)
     return;
 
+  DCHECK(popup_);
+
   registrar_.Remove(
       this,
       content::NOTIFICATION_TAB_CONTENTS_HIDDEN,
diff --git a/chrome/browser/ui/webui/ntp/bookmarks_handler.cc b/chrome/browser/ui/webui/ntp/bookmarks_handler.cc
index 9f45aa7..7f81eb1 100644
--- a/chrome/browser/ui/webui/ntp/bookmarks_handler.cc
+++ b/chrome/browser/ui/webui/ntp/bookmarks_handler.cc
@@ -25,7 +25,8 @@
 
 namespace keys = extension_bookmarks_module_constants;
 
-BookmarksHandler::BookmarksHandler() : dom_ready_(false),
+BookmarksHandler::BookmarksHandler() : model_(NULL),
+                                       dom_ready_(false),
                                        from_current_page_(false) {
 }
 
diff --git a/chrome/browser/ui/webui/options/import_data_handler.cc b/chrome/browser/ui/webui/options/import_data_handler.cc
index dabc43d..a463b2a 100644
--- a/chrome/browser/ui/webui/options/import_data_handler.cc
+++ b/chrome/browser/ui/webui/options/import_data_handler.cc
@@ -23,7 +23,8 @@
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
-ImportDataHandler::ImportDataHandler() : importer_host_(NULL) {
+ImportDataHandler::ImportDataHandler() : importer_host_(NULL),
+                                         import_did_succeed_(false) {
 }
 
 ImportDataHandler::~ImportDataHandler() {
diff --git a/chrome/browser/ui/webui/options/intents_settings_handler.cc b/chrome/browser/ui/webui/options/intents_settings_handler.cc
index 2656e72..d473f76 100644
--- a/chrome/browser/ui/webui/options/intents_settings_handler.cc
+++ b/chrome/browser/ui/webui/options/intents_settings_handler.cc
@@ -20,7 +20,9 @@
 #include "net/url_request/url_request_context_getter.h"
 #include "ui/base/l10n/l10n_util.h"
 
-IntentsSettingsHandler::IntentsSettingsHandler() : batch_update_(false) {
+IntentsSettingsHandler::IntentsSettingsHandler()
+    : web_intents_registry_(NULL),
+      batch_update_(false) {
 }
 
 IntentsSettingsHandler::~IntentsSettingsHandler() {
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 7e4e08d..78089e6 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -143,7 +143,8 @@ static void AppendParams(const std::vector<string16>& additional_names,
 
 namespace chrome {
 
-ChromeContentRendererClient::ChromeContentRendererClient() {
+ChromeContentRendererClient::ChromeContentRendererClient()
+    : spellcheck_provider_(NULL) {
   chrome::InitializePPAPI();
 }
 
diff --git a/content/browser/tab_contents/page_navigator.cc b/content/browser/tab_contents/page_navigator.cc
index a7bcca3..7797220 100644
--- a/content/browser/tab_contents/page_navigator.cc
+++ b/content/browser/tab_contents/page_navigator.cc
@@ -20,7 +20,7 @@ OpenURLParams::OpenURLParams(
       transition(transition) {
 }
 
-OpenURLParams::OpenURLParams() {
+OpenURLParams::OpenURLParams() : disposition(UNKNOWN), transition(0) {
 }
 
 OpenURLParams::~OpenURLParams() {
diff --git a/media/base/pipeline_impl.cc b/media/base/pipeline_impl.cc
index 5a3fccb..589cd97 100644
--- a/media/base/pipeline_impl.cc
+++ b/media/base/pipeline_impl.cc
@@ -64,6 +64,7 @@ class PipelineImpl::PipelineInitState {
 PipelineImpl::PipelineImpl(MessageLoop* message_loop, MediaLog* media_log)
     : message_loop_(message_loop),
       media_log_(media_log),
+      network_activity_(false),
       clock_(new Clock(&base::Time::Now)),
       waiting_for_clock_update_(false),
       state_(kCreated),
diff --git a/net/base/load_states.h b/net/base/load_states.h
index 2f4911e..91b0b6b 100644
--- a/net/base/load_states.h
+++ b/net/base/load_states.h
@@ -84,7 +84,7 @@ enum LoadState {
 struct LoadStateWithParam {
   LoadState state;
   string16 param;
-  LoadStateWithParam() {}
+  LoadStateWithParam() : state(LOAD_STATE_IDLE) {}
   LoadStateWithParam(LoadState state, const string16& param)
       : state(state), param(param) {}
 };
diff --git a/ppapi/proxy/plugin_dispatcher.cc b/ppapi/proxy/plugin_dispatcher.cc
index f2728f2..bb42fcb7 100644
--- a/ppapi/proxy/plugin_dispatcher.cc
+++ b/ppapi/proxy/plugin_dispatcher.cc
@@ -42,6 +42,10 @@ InstanceToDispatcherMap* g_instance_to_dispatcher = NULL;
 
 }  // namespace
 
+InstanceData::InstanceData() : fullscreen(PP_FALSE) {
+  memset(&position, 0, sizeof(position));
+}
+
 PluginDispatcher::PluginDispatcher(base::ProcessHandle remote_process_handle,
                                    GetInterfaceFunc get_interface)
     : Dispatcher(remote_process_handle, get_interface),
diff --git a/ppapi/proxy/plugin_dispatcher.h b/ppapi/proxy/plugin_dispatcher.h
index 6634c52..2238646 100644
--- a/ppapi/proxy/plugin_dispatcher.h
+++ b/ppapi/proxy/plugin_dispatcher.h
@@ -33,7 +33,7 @@ namespace proxy {
 
 // Used to keep track of per-instance data.
 struct InstanceData {
-  InstanceData() : fullscreen(PP_FALSE) {}
+  InstanceData();
   PP_Rect position;
   PP_Bool fullscreen;
 };
diff --git a/ppapi/proxy/ppb_flash_net_connector_proxy.cc b/ppapi/proxy/ppb_flash_net_connector_proxy.cc
index acad6a89..44f856e 100644
--- a/ppapi/proxy/ppb_flash_net_connector_proxy.cc
+++ b/ppapi/proxy/ppb_flash_net_connector_proxy.cc
@@ -92,6 +92,7 @@ class FlashNetConnector : public PPB_Flash_NetConnector_API,
 FlashNetConnector::FlashNetConnector(const HostResource& resource)
     : Resource(resource),
       callback_(PP_BlockUntilComplete()),
+      socket_out_(NULL),
       local_addr_out_(NULL),
       remote_addr_out_(NULL) {
 }
@@ -175,8 +176,8 @@ int32_t FlashNetConnector::ConnectWithMessage(
 // the callback handler.
 struct PPB_Flash_NetConnector_Proxy::ConnectCallbackInfo {
   ConnectCallbackInfo(const HostResource& r) : resource(r), handle(0) {
-    local_addr.size = 0;
-    remote_addr.size = 0;
+    memset(&local_addr, 0, sizeof(local_addr));
+    memset(&remote_addr, 0, sizeof(remote_addr));
   }
 
   HostResource resource;
diff --git a/remoting/client/ipc_host_resolver.cc b/remoting/client/ipc_host_resolver.cc
index 81fe121..ea8a0a8 100644
--- a/remoting/client/ipc_host_resolver.cc
+++ b/remoting/client/ipc_host_resolver.cc
@@ -15,7 +15,8 @@ namespace remoting {
 class IpcHostResolver : public HostResolver {
  public:
   IpcHostResolver(content::P2PSocketDispatcher* socket_dispatcher)
-      : socket_dispatcher_(socket_dispatcher) {
+      : socket_dispatcher_(socket_dispatcher),
+        port_(0) {
   }
 
   virtual ~IpcHostResolver() {
diff --git a/ui/gfx/gl/gl_surface_egl.cc b/ui/gfx/gl/gl_surface_egl.cc
index 2f95385..a69466d 100644
--- a/ui/gfx/gl/gl_surface_egl.cc
+++ b/ui/gfx/gl/gl_surface_egl.cc
@@ -36,7 +36,7 @@ EGLDisplay g_software_display;
 EGLNativeDisplayType g_software_native_display;
 }
 
-GLSurfaceEGL::GLSurfaceEGL() {
+GLSurfaceEGL::GLSurfaceEGL() : software_(false) {
 }
 
 GLSurfaceEGL::~GLSurfaceEGL() {
diff --git a/webkit/glue/webpreferences.cc b/webkit/glue/webpreferences.cc
index cacfd4b..6bd15e5 100644
--- a/webkit/glue/webpreferences.cc
+++ b/webkit/glue/webpreferences.cc
@@ -75,6 +75,7 @@ WebPreferences::WebPreferences()
       asynchronous_spell_checking_enabled(true),
       accelerated_compositing_enabled(false),
       force_compositing_mode(false),
+      allow_webui_compositing(false),
       composite_to_texture_enabled(false),
       accelerated_layers_enabled(false),
       accelerated_video_enabled(false),
diff --git a/webkit/glue/window_open_disposition.h b/webkit/glue/window_open_disposition.h
index c9bfa0a..06bda03 100644
--- a/webkit/glue/window_open_disposition.h
+++ b/webkit/glue/window_open_disposition.h
@@ -8,6 +8,7 @@
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebNavigationPolicy.h"
 
 enum WindowOpenDisposition {
+  UNKNOWN,
   SUPPRESS_OPEN,
   CURRENT_TAB,
   // Indicates that only one tab with the url should exist in the same window.
diff --git a/webkit/plugins/ppapi/ppb_flash_menu_impl.cc b/webkit/plugins/ppapi/ppb_flash_menu_impl.cc
index 2d64e8b..c82e362 100644
--- a/webkit/plugins/ppapi/ppb_flash_menu_impl.cc
+++ b/webkit/plugins/ppapi/ppb_flash_menu_impl.cc
@@ -96,7 +96,8 @@ bool ConvertMenuData(const PP_Flash_Menu* in_menu,
 }  // namespace
 
 PPB_Flash_Menu_Impl::PPB_Flash_Menu_Impl(PP_Instance instance)
-    : Resource(instance) {
+    : Resource(instance),
+      selected_id_out_(NULL) {
 }
 
 PPB_Flash_Menu_Impl::~PPB_Flash_Menu_Impl() {
diff --git a/webkit/plugins/ppapi/ppb_flash_net_connector_impl.cc b/webkit/plugins/ppapi/ppb_flash_net_connector_impl.cc
index e22cccf..5b85ec1 100644
--- a/webkit/plugins/ppapi/ppb_flash_net_connector_impl.cc
+++ b/webkit/plugins/ppapi/ppb_flash_net_connector_impl.cc
@@ -18,7 +18,10 @@ namespace webkit {
 namespace ppapi {
 
 PPB_Flash_NetConnector_Impl::PPB_Flash_NetConnector_Impl(PP_Instance instance)
-    : Resource(instance) {
+    : Resource(instance),
+      socket_out_(NULL),
+      local_addr_out_(NULL),
+      remote_addr_out_(NULL) {
 }
 
 PPB_Flash_NetConnector_Impl::~PPB_Flash_NetConnector_Impl() {