diff options
author | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-09 23:28:06 +0000 |
---|---|---|
committer | ben@chromium.org <ben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-09 23:28:06 +0000 |
commit | e2e88e7f5dbcbb2367d632b534ca0e75aab9f25c (patch) | |
tree | 05402030dd11561f128734a8df6e2e6a848fc366 | |
parent | 6e472da04f540d7837b7a344383869013bc57a3d (diff) | |
download | chromium_src-e2e88e7f5dbcbb2367d632b534ca0e75aab9f25c.zip chromium_src-e2e88e7f5dbcbb2367d632b534ca0e75aab9f25c.tar.gz chromium_src-e2e88e7f5dbcbb2367d632b534ca0e75aab9f25c.tar.bz2 |
Migrate Event API methods to Google Style.
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6480001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74377 0039d316-1c4b-4281-b951-d872f2087c98
49 files changed, 208 insertions, 229 deletions
diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_views.cc b/chrome/browser/autocomplete/autocomplete_edit_view_views.cc index c030c57..80baa0d 100644 --- a/chrome/browser/autocomplete/autocomplete_edit_view_views.cc +++ b/chrome/browser/autocomplete/autocomplete_edit_view_views.cc @@ -165,21 +165,21 @@ bool AutocompleteEditViewViews::HandleAfterKeyEvent( if (content_maybe_changed_by_key_press_) OnAfterPossibleChange(); - if (event.GetKeyCode() == ui::VKEY_RETURN) { + if (event.key_code() == ui::VKEY_RETURN) { bool alt_held = event.IsAltDown(); model_->AcceptInput(alt_held ? NEW_FOREGROUND_TAB : CURRENT_TAB, false); handled = true; - } else if (!handled && event.GetKeyCode() == ui::VKEY_ESCAPE) { + } else if (!handled && event.key_code() == ui::VKEY_ESCAPE) { // We can handle the Escape key if textfield did not handle it. // If it's not handled by us, then we need to propagate it up to the parent // widgets, so that Escape accelerator can still work. handled = model_->OnEscapeKeyPressed(); - } else if (event.GetKeyCode() == ui::VKEY_CONTROL) { + } else if (event.key_code() == ui::VKEY_CONTROL) { // Omnibox2 can switch its contents while pressing a control key. To switch // the contents of omnibox2, we notify the AutocompleteEditModel class when // the control-key state is changed. model_->OnControlKeyChanged(true); - } else if (!text_changed_ && event.GetKeyCode() == ui::VKEY_DELETE && + } else if (!text_changed_ && event.key_code() == ui::VKEY_DELETE && event.IsShiftDown()) { // If shift+del didn't change the text, we let this delete an entry from // the popup. We can't check to see if the IME handled it because even if @@ -187,14 +187,14 @@ bool AutocompleteEditViewViews::HandleAfterKeyEvent( AutocompletePopupModel* popup_model = popup_view_->GetModel(); if (popup_model->IsOpen()) popup_model->TryDeletingCurrentItem(); - } else if (!handled && event.GetKeyCode() == ui::VKEY_UP) { + } else if (!handled && event.key_code() == ui::VKEY_UP) { model_->OnUpOrDownKeyPressed(-1); handled = true; - } else if (!handled && event.GetKeyCode() == ui::VKEY_DOWN) { + } else if (!handled && event.key_code() == ui::VKEY_DOWN) { model_->OnUpOrDownKeyPressed(1); handled = true; } else if (!handled && - event.GetKeyCode() == ui::VKEY_TAB && + event.key_code() == ui::VKEY_TAB && !event.IsShiftDown() && !event.IsControlDown()) { if (model_->is_keyword_hint()) { @@ -224,7 +224,7 @@ bool AutocompleteEditViewViews::HandleKeyReleaseEvent( // Omnibox2 can switch its contents while pressing a control key. To switch // the contents of omnibox2, we notify the AutocompleteEditModel class when // the control-key state is changed. - if (event.GetKeyCode() == ui::VKEY_CONTROL) { + if (event.key_code() == ui::VKEY_CONTROL) { // TODO(oshima): investigate if we need to support keyboard with two // controls. See autocomplete_edit_view_gtk.cc. model_->OnControlKeyChanged(false); @@ -583,7 +583,7 @@ void AutocompleteEditViewViews::ContentsChanged(views::Textfield* sender, bool AutocompleteEditViewViews::HandleKeyEvent( views::Textfield* textfield, const views::KeyEvent& event) { - delete_was_pressed_ = event.GetKeyCode() == ui::VKEY_DELETE; + delete_was_pressed_ = event.key_code() == ui::VKEY_DELETE; // Reset |text_changed_| before passing the key event on to the text view. text_changed_ = false; @@ -591,7 +591,7 @@ bool AutocompleteEditViewViews::HandleKeyEvent( handling_key_press_ = true; content_maybe_changed_by_key_press_ = false; - if (event.GetKeyCode() == ui::VKEY_BACK) { + if (event.key_code() == ui::VKEY_BACK) { // Checks if it's currently in keyword search mode. if (model_->is_keyword_hint() || model_->keyword().empty()) return false; diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_win.cc b/chrome/browser/autocomplete/autocomplete_edit_view_win.cc index 6366873..889d682 100644 --- a/chrome/browser/autocomplete/autocomplete_edit_view_win.cc +++ b/chrome/browser/autocomplete/autocomplete_edit_view_win.cc @@ -969,7 +969,7 @@ void AutocompleteEditViewWin::PasteAndGo(const string16& text) { bool AutocompleteEditViewWin::SkipDefaultKeyEventProcessing( const views::KeyEvent& e) { - ui::KeyboardCode key = e.GetKeyCode(); + ui::KeyboardCode key = e.key_code(); // We don't process ALT + numpad digit as accelerators, they are used for // entering special characters. We do translate alt-home. if (e.IsAltDown() && (key != ui::VKEY_HOME) && diff --git a/chrome/browser/bookmarks/bookmark_drop_info.cc b/chrome/browser/bookmarks/bookmark_drop_info.cc index ba9d7a0..30d1f03 100644 --- a/chrome/browser/bookmarks/bookmark_drop_info.cc +++ b/chrome/browser/bookmarks/bookmark_drop_info.cc @@ -26,7 +26,7 @@ BookmarkDropInfo::~BookmarkDropInfo() { } void BookmarkDropInfo::Update(const views::DropTargetEvent& event) { - source_operations_ = event.GetSourceOperations(); + source_operations_ = event.source_operations(); is_control_down_ = event.IsControlDown(); last_y_ = event.y(); diff --git a/chrome/browser/bookmarks/bookmark_utils.cc b/chrome/browser/bookmarks/bookmark_utils.cc index 6e26e9b..42bde4a3 100644 --- a/chrome/browser/bookmarks/bookmark_utils.cc +++ b/chrome/browser/bookmarks/bookmark_utils.cc @@ -244,7 +244,7 @@ int BookmarkDropOperation(Profile* profile, return ui::DragDropTypes::DRAG_MOVE; } // User is dragging from another app, copy. - return PreferredDropOperation(event.GetSourceOperations(), + return PreferredDropOperation(event.source_operations(), ui::DragDropTypes::DRAG_COPY | ui::DragDropTypes::DRAG_LINK); } diff --git a/chrome/browser/chromeos/login/captcha_view.cc b/chrome/browser/chromeos/login/captcha_view.cc index 4126832..c4c295b 100644 --- a/chrome/browser/chromeos/login/captcha_view.cc +++ b/chrome/browser/chromeos/login/captcha_view.cc @@ -123,7 +123,7 @@ void CaptchaView::ViewHierarchyChanged(bool is_add, bool CaptchaView::HandleKeyEvent(views::Textfield* sender, const views::KeyEvent& key_event) { if (sender == captcha_textfield_ && - key_event.GetKeyCode() == ui::VKEY_RETURN) { + key_event.key_code() == ui::VKEY_RETURN) { if (is_standalone_) { Accept(); } else { diff --git a/chrome/browser/chromeos/login/existing_user_view.cc b/chrome/browser/chromeos/login/existing_user_view.cc index dcf100f..8655351 100644 --- a/chrome/browser/chromeos/login/existing_user_view.cc +++ b/chrome/browser/chromeos/login/existing_user_view.cc @@ -33,13 +33,13 @@ class UserEntryTextfield : public TextfieldWithMargin { // Overridden from views::View: virtual bool OnKeyPressed(const views::KeyEvent& e) { - if (e.GetKeyCode() == ui::VKEY_TAB) { + if (e.key_code() == ui::VKEY_TAB) { controller_->SelectUserRelative(e.IsShiftDown() ? -1 : 1); return true; - } else if (e.GetKeyCode() == ui::VKEY_LEFT) { + } else if (e.key_code() == ui::VKEY_LEFT) { controller_->SelectUserRelative(-1); return true; - } else if (e.GetKeyCode() == ui::VKEY_RIGHT) { + } else if (e.key_code() == ui::VKEY_RIGHT) { controller_->SelectUserRelative(1); return true; } else { @@ -48,7 +48,7 @@ class UserEntryTextfield : public TextfieldWithMargin { } virtual bool SkipDefaultKeyEventProcessing(const views::KeyEvent& e) { - if (e.GetKeyCode() == ui::VKEY_TAB) + if (e.key_code() == ui::VKEY_TAB) return true; else return views::Textfield::SkipDefaultKeyEventProcessing(e); @@ -104,7 +104,7 @@ bool ExistingUserView::AcceleratorPressed( bool ExistingUserView::HandleKeyEvent(views::Textfield* sender, const views::KeyEvent& key_event) { - if (key_event.GetKeyCode() == ui::VKEY_RETURN) { + if (key_event.key_code() == ui::VKEY_RETURN) { if (!password_field_->text().empty()) user_controller_->OnLogin("", UTF16ToUTF8(password_field_->text())); } else { diff --git a/chrome/browser/chromeos/login/guest_user_view.cc b/chrome/browser/chromeos/login/guest_user_view.cc index 5f9b9b5..02978e2 100644 --- a/chrome/browser/chromeos/login/guest_user_view.cc +++ b/chrome/browser/chromeos/login/guest_user_view.cc @@ -23,7 +23,7 @@ class UserEntryButton : public login::WideButton { // Overridden from views::View: virtual bool OnKeyPressed(const views::KeyEvent& e) { - if (e.GetKeyCode() == ui::VKEY_TAB) { + if (e.key_code() == ui::VKEY_TAB) { user_controller_->SelectUserRelative(e.IsShiftDown() ? -1 : 1); return true; } @@ -31,7 +31,7 @@ class UserEntryButton : public login::WideButton { } virtual bool SkipDefaultKeyEventProcessing(const views::KeyEvent& e) { - if (e.GetKeyCode() == ui::VKEY_TAB) + if (e.key_code() == ui::VKEY_TAB) return true; return WideButton::SkipDefaultKeyEventProcessing(e); } diff --git a/chrome/browser/chromeos/login/new_user_view.cc b/chrome/browser/chromeos/login/new_user_view.cc index 121cf9f..ab17d64 100644 --- a/chrome/browser/chromeos/login/new_user_view.cc +++ b/chrome/browser/chromeos/login/new_user_view.cc @@ -85,7 +85,7 @@ class UsernameField : public chromeos::TextfieldWithMargin { // Overridden from views::View: virtual bool OnKeyPressed(const views::KeyEvent& e) { - if (e.GetKeyCode() == ui::VKEY_LEFT) { + if (e.key_code() == ui::VKEY_LEFT) { return controller_->NavigateAway(); } return false; @@ -512,7 +512,7 @@ bool NewUserView::HandleKeyEvent(views::Textfield* sender, if (!CrosLibrary::Get()->EnsureLoaded() || login_in_process_) return false; - if (key_event.GetKeyCode() == ui::VKEY_RETURN) { + if (key_event.key_code() == ui::VKEY_RETURN) { if (!username_field_->text().empty() && !password_field_->text().empty()) Login(); // Return true so that processing ends diff --git a/chrome/browser/chromeos/login/screen_lock_view.cc b/chrome/browser/chromeos/login/screen_lock_view.cc index e74710a..0ebcd09 100644 --- a/chrome/browser/chromeos/login/screen_lock_view.cc +++ b/chrome/browser/chromeos/login/screen_lock_view.cc @@ -198,7 +198,7 @@ bool ScreenLockView::HandleKeyEvent( views::Textfield* sender, const views::KeyEvent& key_event) { screen_locker_->ClearErrors(); - if (key_event.GetKeyCode() == ui::VKEY_RETURN) { + if (key_event.key_code() == ui::VKEY_RETURN) { screen_locker_->Authenticate(password_field_->text()); return true; } diff --git a/chrome/browser/chromeos/login/textfield_with_margin.cc b/chrome/browser/chromeos/login/textfield_with_margin.cc index 38cadb7..eb75416 100644 --- a/chrome/browser/chromeos/login/textfield_with_margin.cc +++ b/chrome/browser/chromeos/login/textfield_with_margin.cc @@ -36,7 +36,7 @@ void TextfieldWithMargin::Layout() { } bool TextfieldWithMargin::OnKeyPressed(const views::KeyEvent& e) { - if (e.GetKeyCode() == ui::VKEY_ESCAPE && !text().empty()) { + if (e.key_code() == ui::VKEY_ESCAPE && !text().empty()) { SetText(string16()); return true; } diff --git a/chrome/browser/chromeos/options/wifi_config_view.cc b/chrome/browser/chromeos/options/wifi_config_view.cc index f55c1b5..e419994 100644 --- a/chrome/browser/chromeos/options/wifi_config_view.cc +++ b/chrome/browser/chromeos/options/wifi_config_view.cc @@ -152,7 +152,7 @@ void WifiConfigView::ContentsChanged(views::Textfield* sender, bool WifiConfigView::HandleKeyEvent(views::Textfield* sender, const views::KeyEvent& key_event) { if (sender == passphrase_textfield_ && - key_event.GetKeyCode() == ui::VKEY_RETURN) { + key_event.key_code() == ui::VKEY_RETURN) { parent_->GetDialogClientView()->AcceptWindow(); } return false; diff --git a/chrome/browser/extensions/extension_input_api.cc b/chrome/browser/extensions/extension_input_api.cc index bb91c00..f4913b96 100644 --- a/chrome/browser/extensions/extension_input_api.cc +++ b/chrome/browser/extensions/extension_input_api.cc @@ -89,12 +89,12 @@ bool SendKeyboardEventInputFunction::RunImpl() { const views::KeyEvent& prototype_event = KeyEventFromKeyIdentifier(identifier); - if (prototype_event.GetKeyCode() == ui::VKEY_UNKNOWN) { + if (prototype_event.key_code() == ui::VKEY_UNKNOWN) { error_ = kUnknownOrUnsupportedKeyIdentiferError; return false; } - int flags = prototype_event.GetFlags(); + int flags = prototype_event.flags(); bool alt = false; if (args->GetBoolean(kAlt, &alt)) flags |= alt ? views::Event::EF_ALT_DOWN : 0; @@ -119,7 +119,7 @@ bool SendKeyboardEventInputFunction::RunImpl() { return false; } - views::KeyEvent event(type, prototype_event.GetKeyCode(), flags, 0, 0); + views::KeyEvent event(type, prototype_event.key_code(), flags, 0, 0); if (!root_view->ProcessKeyEvent(event)) { error_ = kKeyEventUnprocessedError; return false; diff --git a/chrome/browser/extensions/key_identifier_conversion_views_unittest.cc b/chrome/browser/extensions/key_identifier_conversion_views_unittest.cc index 79ce56e..8f36e98 100644 --- a/chrome/browser/extensions/key_identifier_conversion_views_unittest.cc +++ b/chrome/browser/extensions/key_identifier_conversion_views_unittest.cc @@ -23,40 +23,40 @@ class KeyEventFromKeyIdentifierTest : public testing::Test { }; TEST_F(KeyEventFromKeyIdentifierTest, MatchOnIdentifier) { - EXPECT_EQ(ui::VKEY_APPS, KeyEventFromKeyIdentifier("Apps").GetKeyCode()); + EXPECT_EQ(ui::VKEY_APPS, KeyEventFromKeyIdentifier("Apps").key_code()); EXPECT_EQ(ui::VKEY_UNKNOWN, - KeyEventFromKeyIdentifier("Nonsense").GetKeyCode()); + KeyEventFromKeyIdentifier("Nonsense").key_code()); } TEST_F(KeyEventFromKeyIdentifierTest, MatchOnCharacter) { - EXPECT_EQ(ui::VKEY_A, KeyEventFromKeyIdentifier("a").GetKeyCode()); - EXPECT_EQ(ui::VKEY_A, KeyEventFromKeyIdentifier("A").GetKeyCode()); - EXPECT_EQ(ui::VKEY_OEM_PERIOD, KeyEventFromKeyIdentifier(">").GetKeyCode()); + EXPECT_EQ(ui::VKEY_A, KeyEventFromKeyIdentifier("a").key_code()); + EXPECT_EQ(ui::VKEY_A, KeyEventFromKeyIdentifier("A").key_code()); + EXPECT_EQ(ui::VKEY_OEM_PERIOD, KeyEventFromKeyIdentifier(">").key_code()); std::string non_printing_char(" "); non_printing_char[0] = static_cast<char>(1); EXPECT_EQ(ui::VKEY_UNKNOWN, - KeyEventFromKeyIdentifier(non_printing_char).GetKeyCode()); + KeyEventFromKeyIdentifier(non_printing_char).key_code()); } TEST_F(KeyEventFromKeyIdentifierTest, MatchOnUnicodeCodepoint) { - EXPECT_EQ(ui::VKEY_A, KeyEventFromKeyIdentifier("U+0041").GetKeyCode()); - EXPECT_EQ(ui::VKEY_A, KeyEventFromKeyIdentifier("U+0061").GetKeyCode()); - EXPECT_EQ(ui::VKEY_DELETE, KeyEventFromKeyIdentifier("U+007F").GetKeyCode()); + EXPECT_EQ(ui::VKEY_A, KeyEventFromKeyIdentifier("U+0041").key_code()); + EXPECT_EQ(ui::VKEY_A, KeyEventFromKeyIdentifier("U+0061").key_code()); + EXPECT_EQ(ui::VKEY_DELETE, KeyEventFromKeyIdentifier("U+007F").key_code()); // this one exists in the map, but has no valid ui::VKEY - EXPECT_EQ(ui::VKEY_UNKNOWN, KeyEventFromKeyIdentifier("U+030A").GetKeyCode()); + EXPECT_EQ(ui::VKEY_UNKNOWN, KeyEventFromKeyIdentifier("U+030A").key_code()); // this one is not in the map - EXPECT_EQ(ui::VKEY_UNKNOWN, KeyEventFromKeyIdentifier("U+0001").GetKeyCode()); + EXPECT_EQ(ui::VKEY_UNKNOWN, KeyEventFromKeyIdentifier("U+0001").key_code()); } TEST_F(KeyEventFromKeyIdentifierTest, DoesNotMatchEmptyString) { - EXPECT_EQ(ui::VKEY_UNKNOWN, KeyEventFromKeyIdentifier("").GetKeyCode()); + EXPECT_EQ(ui::VKEY_UNKNOWN, KeyEventFromKeyIdentifier("").key_code()); } TEST_F(KeyEventFromKeyIdentifierTest, ShiftModifiersAreSet) { - EXPECT_EQ(0, KeyEventFromKeyIdentifier("1").GetFlags()); + EXPECT_EQ(0, KeyEventFromKeyIdentifier("1").flags()); const char* keys_with_shift[] = { "~", "!", "@", "#", "$", "%", "^", "&", "*", "(", ")", "_", "+", @@ -66,7 +66,7 @@ TEST_F(KeyEventFromKeyIdentifierTest, ShiftModifiersAreSet) { for (int i = 0; i < kNumKeysWithShift; ++i) { EXPECT_EQ(views::Event::EF_SHIFT_DOWN, - KeyEventFromKeyIdentifier(keys_with_shift[i]).GetFlags()); + KeyEventFromKeyIdentifier(keys_with_shift[i]).flags()); } } diff --git a/chrome/browser/ui/views/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmark_bar_view.cc index d0d9510..90e1694 100644 --- a/chrome/browser/ui/views/bookmark_bar_view.cc +++ b/chrome/browser/ui/views/bookmark_bar_view.cc @@ -193,12 +193,12 @@ class BookmarkFolderButton : public views::MenuButton { virtual bool IsTriggerableEvent(const views::MouseEvent& e) { // Left clicks should show the menu contents and right clicks should show // the context menu. They should not trigger the opening of underlying urls. - if (e.GetFlags() == views::MouseEvent::EF_LEFT_BUTTON_DOWN || - e.GetFlags() == views::MouseEvent::EF_RIGHT_BUTTON_DOWN) + if (e.flags() == views::MouseEvent::EF_LEFT_BUTTON_DOWN || + e.flags() == views::MouseEvent::EF_RIGHT_BUTTON_DOWN) return false; WindowOpenDisposition disposition( - event_utils::DispositionFromEventFlags(e.GetFlags())); + event_utils::DispositionFromEventFlags(e.flags())); return disposition != CURRENT_TAB; } @@ -1402,9 +1402,8 @@ int BookmarkBarView::CalculateDropOperation(const DropTargetEvent& event, int ops = data.GetFirstNode(profile_) ? ui::DragDropTypes::DRAG_MOVE : ui::DragDropTypes::DRAG_COPY | ui::DragDropTypes::DRAG_LINK; - return - bookmark_utils::PreferredDropOperation(event.GetSourceOperations(), - ops); + return bookmark_utils::PreferredDropOperation(event.source_operations(), + ops); } for (int i = 0; i < GetBookmarkButtonCount() && diff --git a/chrome/browser/ui/views/browser_actions_container.cc b/chrome/browser/ui/views/browser_actions_container.cc index 8a2b9a1..77ecd07 100644 --- a/chrome/browser/ui/views/browser_actions_container.cc +++ b/chrome/browser/ui/views/browser_actions_container.cc @@ -699,7 +699,7 @@ void BrowserActionsContainer::OnDragExited() { int BrowserActionsContainer::OnPerformDrop( const views::DropTargetEvent& event) { BrowserActionDragData data; - if (!data.Read(event.GetData())) + if (!data.Read(event.data())) return ui::DragDropTypes::DRAG_NONE; // Make sure we have the same view as we started with. diff --git a/chrome/browser/ui/views/content_setting_bubble_contents.cc b/chrome/browser/ui/views/content_setting_bubble_contents.cc index c2b93d7..de139bf 100644 --- a/chrome/browser/ui/views/content_setting_bubble_contents.cc +++ b/chrome/browser/ui/views/content_setting_bubble_contents.cc @@ -92,7 +92,7 @@ void ContentSettingBubbleContents::Favicon::OnMouseReleased( if (!canceled && (event.IsLeftMouseButton() || event.IsMiddleMouseButton()) && HitTest(event.location())) - parent_->LinkActivated(link_, event.GetFlags()); + parent_->LinkActivated(link_, event.flags()); } gfx::NativeCursor ContentSettingBubbleContents::Favicon::GetCursorForPoint( diff --git a/chrome/browser/ui/views/download_item_view.cc b/chrome/browser/ui/views/download_item_view.cc index ff2d44f..92f5c341 100644 --- a/chrome/browser/ui/views/download_item_view.cc +++ b/chrome/browser/ui/views/download_item_view.cc @@ -876,8 +876,7 @@ bool DownloadItemView::OnKeyPressed(const views::KeyEvent& e) { if (IsDangerousMode()) return true; - if (e.GetKeyCode() == ui::VKEY_SPACE || - e.GetKeyCode() == ui::VKEY_RETURN) { + if (e.key_code() == ui::VKEY_SPACE || e.key_code() == ui::VKEY_RETURN) { OpenDownload(); return true; } diff --git a/chrome/browser/ui/views/dropdown_bar_host_win.cc b/chrome/browser/ui/views/dropdown_bar_host_win.cc index f08db1d..0f0ce6a 100644 --- a/chrome/browser/ui/views/dropdown_bar_host_win.cc +++ b/chrome/browser/ui/views/dropdown_bar_host_win.cc @@ -17,7 +17,7 @@ NativeWebKeyboardEvent DropdownBarHost::GetKeyboardEvent( const TabContents* contents, const views::KeyEvent& key_event) { HWND hwnd = contents->GetContentNativeView(); - WORD key = WindowsKeyCodeForKeyboardCode(key_event.GetKeyCode()); + WORD key = WindowsKeyCodeForKeyboardCode(key_event.key_code()); return NativeWebKeyboardEvent(hwnd, key_event.message(), key, 0); } diff --git a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc index 3c6260d..549017d 100644 --- a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc +++ b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc @@ -148,7 +148,7 @@ int BrowserActionOverflowMenuController::GetDropOperation( // (because we don't shrink the BrowserActionContainer when you do this). if ((item->GetCommand() == 0) && (*position == DROP_BEFORE)) { BrowserActionDragData drop_data; - if (!drop_data.Read(event.GetData())) + if (!drop_data.Read(event.data())) return ui::DragDropTypes::DRAG_NONE; if (drop_data.index() < owner_->VisibleBrowserActions()) @@ -163,7 +163,7 @@ int BrowserActionOverflowMenuController::OnPerformDrop( DropPosition position, const views::DropTargetEvent& event) { BrowserActionDragData drop_data; - if (!drop_data.Read(event.GetData())) + if (!drop_data.Read(event.data())) return ui::DragDropTypes::DRAG_NONE; size_t drop_index; diff --git a/chrome/browser/ui/views/extensions/extension_view.cc b/chrome/browser/ui/views/extensions/extension_view.cc index 077f4cd..811f12e 100644 --- a/chrome/browser/ui/views/extensions/extension_view.cc +++ b/chrome/browser/ui/views/extensions/extension_view.cc @@ -177,7 +177,7 @@ void ExtensionView::PreferredSizeChanged() { bool ExtensionView::SkipDefaultKeyEventProcessing(const views::KeyEvent& e) { // Let the tab key event be processed by the renderer (instead of moving the // focus to the next focusable view). - return (e.GetKeyCode() == ui::VKEY_TAB); + return (e.key_code() == ui::VKEY_TAB); } void ExtensionView::HandleMouseMove() { diff --git a/chrome/browser/ui/views/find_bar_host.cc b/chrome/browser/ui/views/find_bar_host.cc index a253f8f..c1eac91 100644 --- a/chrome/browser/ui/views/find_bar_host.cc +++ b/chrome/browser/ui/views/find_bar_host.cc @@ -49,7 +49,7 @@ bool FindBarHost::MaybeForwardKeyEventToWebpage( return false; } - switch (key_event.GetKeyCode()) { + switch (key_event.key_code()) { case ui::VKEY_DOWN: case ui::VKEY_UP: case ui::VKEY_PRIOR: diff --git a/chrome/browser/ui/views/find_bar_view.cc b/chrome/browser/ui/views/find_bar_view.cc index 92e5619..87a7abd 100644 --- a/chrome/browser/ui/views/find_bar_view.cc +++ b/chrome/browser/ui/views/find_bar_view.cc @@ -514,7 +514,7 @@ bool FindBarView::HandleKeyEvent(views::Textfield* sender, if (find_bar_host()->MaybeForwardKeyEventToWebpage(key_event)) return true; // Handled, we are done! - if (key_event.GetKeyCode() == ui::VKEY_RETURN) { + if (key_event.key_code() == ui::VKEY_RETURN) { // Pressing Return/Enter starts the search (unless text box is empty). string16 find_string = find_text_->text(); if (!find_string.empty()) { diff --git a/chrome/browser/ui/views/frame/browser_root_view.cc b/chrome/browser/ui/views/frame/browser_root_view.cc index 0eb38e3..bba2945 100644 --- a/chrome/browser/ui/views/frame/browser_root_view.cc +++ b/chrome/browser/ui/views/frame/browser_root_view.cc @@ -56,7 +56,7 @@ void BrowserRootView::OnDragEntered(const views::DropTargetEvent& event) { if (ShouldForwardToTabStrip(event)) { forwarding_to_tab_strip_ = true; scoped_ptr<views::DropTargetEvent> mapped_event( - MapEventToTabStrip(event, event.GetData())); + MapEventToTabStrip(event, event.data())); tabstrip()->OnDragEntered(*mapped_event.get()); } } @@ -64,7 +64,7 @@ void BrowserRootView::OnDragEntered(const views::DropTargetEvent& event) { int BrowserRootView::OnDragUpdated(const views::DropTargetEvent& event) { if (ShouldForwardToTabStrip(event)) { scoped_ptr<views::DropTargetEvent> mapped_event( - MapEventToTabStrip(event, event.GetData())); + MapEventToTabStrip(event, event.data())); if (!forwarding_to_tab_strip_) { tabstrip()->OnDragEntered(*mapped_event.get()); forwarding_to_tab_strip_ = true; @@ -94,9 +94,9 @@ int BrowserRootView::OnPerformDrop(const views::DropTargetEvent& event) { GURL url; std::wstring title; ui::OSExchangeData mapped_data; - if (!event.GetData().GetURLAndTitle(&url, &title) || !url.is_valid()) { + if (!event.data().GetURLAndTitle(&url, &title) || !url.is_valid()) { // The url isn't valid. Use the paste and go url. - if (GetPasteAndGoURL(event.GetData(), &url)) + if (GetPasteAndGoURL(event.data(), &url)) mapped_data.SetURL(url, std::wstring()); // else case: couldn't extract a url or 'paste and go' url. This ends up // passing through an ui::OSExchangeData with nothing in it. We need to do @@ -129,7 +129,7 @@ views::DropTargetEvent* BrowserRootView::MapEventToTabStrip( ConvertPointToView(this, tabstrip(), &tab_strip_loc); return new views::DropTargetEvent(data, tab_strip_loc.x(), tab_strip_loc.y(), - event.GetSourceOperations()); + event.source_operations()); } BaseTabStrip* BrowserRootView::tabstrip() const { diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc index a4ab18c..3f34a24 100644 --- a/chrome/browser/ui/views/frame/browser_view.cc +++ b/chrome/browser/ui/views/frame/browser_view.cc @@ -1258,7 +1258,7 @@ bool BrowserView::PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event, // it'll be best if we can unify these conversion tables. // See http://crbug.com/54315 views::KeyEvent views_event(event.os_event); - views::Accelerator accelerator(views_event.GetKeyCode(), + views::Accelerator accelerator(views_event.key_code(), views_event.IsShiftDown(), views_event.IsControlDown(), views_event.IsAltDown()); diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc index 6634354..08188c6 100644 --- a/chrome/browser/ui/views/location_bar/location_bar_view.cc +++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc @@ -697,13 +697,13 @@ void LocationBarView::SelectAll() { bool LocationBarView::OnMousePressed(const views::MouseEvent& event) { UINT msg; if (event.IsLeftMouseButton()) { - msg = (event.GetFlags() & views::MouseEvent::EF_IS_DOUBLE_CLICK) ? + msg = (event.flags() & views::MouseEvent::EF_IS_DOUBLE_CLICK) ? WM_LBUTTONDBLCLK : WM_LBUTTONDOWN; } else if (event.IsMiddleMouseButton()) { - msg = (event.GetFlags() & views::MouseEvent::EF_IS_DOUBLE_CLICK) ? + msg = (event.flags() & views::MouseEvent::EF_IS_DOUBLE_CLICK) ? WM_MBUTTONDBLCLK : WM_MBUTTONDOWN; } else if (event.IsRightMouseButton()) { - msg = (event.GetFlags() & views::MouseEvent::EF_IS_DOUBLE_CLICK) ? + msg = (event.flags() & views::MouseEvent::EF_IS_DOUBLE_CLICK) ? WM_RBUTTONDBLCLK : WM_RBUTTONDOWN; } else { NOTREACHED(); diff --git a/chrome/browser/ui/views/location_bar/page_action_image_view.cc b/chrome/browser/ui/views/location_bar/page_action_image_view.cc index e867091..bcfe51a 100644 --- a/chrome/browser/ui/views/location_bar/page_action_image_view.cc +++ b/chrome/browser/ui/views/location_bar/page_action_image_view.cc @@ -140,8 +140,7 @@ void PageActionImageView::OnMouseReleased(const views::MouseEvent& event, } bool PageActionImageView::OnKeyPressed(const views::KeyEvent& e) { - if (e.GetKeyCode() == ui::VKEY_SPACE || - e.GetKeyCode() == ui::VKEY_RETURN) { + if (e.key_code() == ui::VKEY_SPACE || e.key_code() == ui::VKEY_RETURN) { ExecuteAction(1, false); return true; } diff --git a/chrome/browser/ui/views/location_bar/star_view.cc b/chrome/browser/ui/views/location_bar/star_view.cc index c7bacbeb..886aec2 100644 --- a/chrome/browser/ui/views/location_bar/star_view.cc +++ b/chrome/browser/ui/views/location_bar/star_view.cc @@ -59,8 +59,7 @@ void StarView::OnMouseReleased(const views::MouseEvent& event, bool canceled) { } bool StarView::OnKeyPressed(const views::KeyEvent& e) { - if (e.GetKeyCode() == ui::VKEY_SPACE || - e.GetKeyCode() == ui::VKEY_RETURN) { + if (e.key_code() == ui::VKEY_SPACE || e.key_code() == ui::VKEY_RETURN) { command_updater_->ExecuteCommand(IDC_BOOKMARK_PAGE); return true; } diff --git a/chrome/browser/ui/views/options/cookies_view.cc b/chrome/browser/ui/views/options/cookies_view.cc index 83040e5..5b9c9e3 100644 --- a/chrome/browser/ui/views/options/cookies_view.cc +++ b/chrome/browser/ui/views/options/cookies_view.cc @@ -145,9 +145,9 @@ void CookiesView::ContentsChanged(views::Textfield* sender, bool CookiesView::HandleKeyEvent(views::Textfield* sender, const views::KeyEvent& key_event) { - if (key_event.GetKeyCode() == ui::VKEY_ESCAPE) { + if (key_event.key_code() == ui::VKEY_ESCAPE) { ResetSearchQuery(); - } else if (key_event.GetKeyCode() == ui::VKEY_RETURN) { + } else if (key_event.key_code() == ui::VKEY_RETURN) { search_update_factory_.RevokeAll(); UpdateSearchResults(); } diff --git a/chrome/browser/ui/views/tabs/tab_strip.cc b/chrome/browser/ui/views/tabs/tab_strip.cc index eca1ef9..84d7517 100644 --- a/chrome/browser/ui/views/tabs/tab_strip.cc +++ b/chrome/browser/ui/views/tabs/tab_strip.cc @@ -355,7 +355,7 @@ int TabStrip::OnPerformDrop(const DropTargetEvent& event) { GURL url; std::wstring title; - if (!event.GetData().GetURLAndTitle(&url, &title) || !url.is_valid()) + if (!event.data().GetURLAndTitle(&url, &title) || !url.is_valid()) return ui::DragDropTypes::DRAG_NONE; controller()->PerformDrop(drop_before, drop_index, url); @@ -758,7 +758,7 @@ void TabStrip::SetDropIndex(int tab_data_index, bool drop_before) { } int TabStrip::GetDropEffect(const views::DropTargetEvent& event) { - const int source_ops = event.GetSourceOperations(); + const int source_ops = event.source_operations(); if (source_ops & ui::DragDropTypes::DRAG_COPY) return ui::DragDropTypes::DRAG_COPY; if (source_ops & ui::DragDropTypes::DRAG_LINK) diff --git a/views/controls/button/button.cc b/views/controls/button/button.cc index b59fd89..7b6cc75 100644 --- a/views/controls/button/button.cc +++ b/views/controls/button/button.cc @@ -52,7 +52,7 @@ Button::Button(ButtonListener* listener) } void Button::NotifyClick(const views::Event& event) { - mouse_event_flags_ = event.IsMouseEvent() ? event.GetFlags() : 0; + mouse_event_flags_ = event.IsMouseEvent() ? event.flags() : 0; // We can be called when there is no listener, in cases like double clicks on // menu buttons etc. if (listener_) diff --git a/views/controls/button/button_dropdown.cc b/views/controls/button/button_dropdown.cc index 16f424f..1d7004e 100644 --- a/views/controls/button/button_dropdown.cc +++ b/views/controls/button/button_dropdown.cc @@ -124,7 +124,7 @@ bool ButtonDropDown::ShouldEnterPushedState(const MouseEvent& e) { // Enter PUSHED state on press with Left or Right mouse button. Remain // in this state while the context menu is open. return ((MouseEvent::EF_LEFT_BUTTON_DOWN | - MouseEvent::EF_RIGHT_BUTTON_DOWN) & e.GetFlags()) != 0; + MouseEvent::EF_RIGHT_BUTTON_DOWN) & e.flags()) != 0; } void ButtonDropDown::ShowDropDownMenu(gfx::NativeView window) { diff --git a/views/controls/button/custom_button.cc b/views/controls/button/custom_button.cc index 56abaeb..af419d4 100644 --- a/views/controls/button/custom_button.cc +++ b/views/controls/button/custom_button.cc @@ -125,7 +125,7 @@ CustomButton::CustomButton(ButtonListener* listener) } bool CustomButton::IsTriggerableEvent(const MouseEvent& e) { - return (triggerable_event_flags_ & e.GetFlags()) != 0; + return (triggerable_event_flags_ & e.flags()) != 0; } //////////////////////////////////////////////////////////////////////////////// @@ -203,9 +203,9 @@ bool CustomButton::OnKeyPressed(const KeyEvent& e) { // Space sets button state to pushed. Enter clicks the button. This matches // the Windows native behavior of buttons, where Space clicks the button on // KeyRelease and Enter clicks the button on KeyPressed. - if (e.GetKeyCode() == ui::VKEY_SPACE) { + if (e.key_code() == ui::VKEY_SPACE) { SetState(BS_PUSHED); - } else if (e.GetKeyCode() == ui::VKEY_RETURN) { + } else if (e.key_code() == ui::VKEY_RETURN) { SetState(BS_NORMAL); NotifyClick(e); } else { @@ -215,7 +215,7 @@ bool CustomButton::OnKeyPressed(const KeyEvent& e) { } bool CustomButton::OnKeyReleased(const KeyEvent& e) { - if ((state_ == BS_DISABLED) || (e.GetKeyCode() != ui::VKEY_SPACE)) + if ((state_ == BS_DISABLED) || (e.key_code() != ui::VKEY_SPACE)) return false; SetState(BS_NORMAL); diff --git a/views/controls/button/menu_button.cc b/views/controls/button/menu_button.cc index 0cd933e..766b3dc 100644 --- a/views/controls/button/menu_button.cc +++ b/views/controls/button/menu_button.cc @@ -220,14 +220,18 @@ void MenuButton::OnMouseReleased(const MouseEvent& e, } bool MenuButton::OnKeyPressed(const KeyEvent& e) { - if (e.GetKeyCode() == ui::VKEY_SPACE || - e.GetKeyCode() == ui::VKEY_RETURN || - e.GetKeyCode() == ui::VKEY_UP || - e.GetKeyCode() == ui::VKEY_DOWN) { - bool result = Activate(); - if (GetFocusManager()->GetFocusedView() == NULL) - RequestFocus(); - return result; + switch (e.key_code()) { + case ui::VKEY_SPACE: + case ui::VKEY_RETURN: + case ui::VKEY_UP: + case ui::VKEY_DOWN: { + bool result = Activate(); + if (GetFocusManager()->GetFocusedView() == NULL) + RequestFocus(); + return result; + } + default: + break; } return false; } diff --git a/views/controls/combobox/combobox.cc b/views/controls/combobox/combobox.cc index 0c7f293..2349bbb 100644 --- a/views/controls/combobox/combobox.cc +++ b/views/controls/combobox/combobox.cc @@ -77,7 +77,7 @@ void Combobox::SetEnabled(bool flag) { // VKEY_ESCAPE should be handled by this view when the drop down list is active. // In other words, the list should be closed instead of the dialog. bool Combobox::SkipDefaultKeyEventProcessing(const KeyEvent& e) { - if (e.GetKeyCode() != ui::VKEY_ESCAPE || + if (e.key_code() != ui::VKEY_ESCAPE || e.IsShiftDown() || e.IsControlDown() || e.IsAltDown()) { return false; } diff --git a/views/controls/link.cc b/views/controls/link.cc index ab48bc2..a9affb3 100644 --- a/views/controls/link.cc +++ b/views/controls/link.cc @@ -121,13 +121,13 @@ void Link::OnMouseReleased(const MouseEvent& e, bool canceled) { RequestFocus(); if (controller_) - controller_->LinkActivated(this, e.GetFlags()); + controller_->LinkActivated(this, e.flags()); } } bool Link::OnKeyPressed(const KeyEvent& e) { - bool activate = ((e.GetKeyCode() == ui::VKEY_SPACE) || - (e.GetKeyCode() == ui::VKEY_RETURN)); + bool activate = ((e.key_code() == ui::VKEY_SPACE) || + (e.key_code() == ui::VKEY_RETURN)); if (!activate) return false; @@ -137,15 +137,15 @@ bool Link::OnKeyPressed(const KeyEvent& e) { RequestFocus(); if (controller_) - controller_->LinkActivated(this, e.GetFlags()); + controller_->LinkActivated(this, e.flags()); return true; } bool Link::SkipDefaultKeyEventProcessing(const KeyEvent& e) { // Make sure we don't process space or enter as accelerators. - return (e.GetKeyCode() == ui::VKEY_SPACE) || - (e.GetKeyCode() == ui::VKEY_RETURN); + return (e.key_code() == ui::VKEY_SPACE) || + (e.key_code() == ui::VKEY_RETURN); } AccessibilityTypes::Role Link::GetAccessibleRole() { diff --git a/views/controls/menu/menu_controller.cc b/views/controls/menu/menu_controller.cc index 660f8ef..1632b72 100644 --- a/views/controls/menu/menu_controller.cc +++ b/views/controls/menu/menu_controller.cc @@ -523,13 +523,13 @@ void MenuController::OnMouseReleased(SubmenuView* source, // contents of the folder. if (!part.is_scroll() && part.menu && !(part.menu->HasSubmenu() && - (event.GetFlags() == MouseEvent::EF_LEFT_BUTTON_DOWN))) { + (event.flags() == MouseEvent::EF_LEFT_BUTTON_DOWN))) { if (active_mouse_view_) { SendMouseReleaseToActiveView(source, event, false); return; } if (part.menu->GetDelegate()->IsTriggerableEvent(event)) { - Accept(part.menu, event.GetFlags()); + Accept(part.menu, event.flags()); return; } } else if (part.type == MenuPart::MENU_ITEM) { @@ -1795,7 +1795,7 @@ void MenuController::UpdateActiveMouseView(SubmenuView* event_source, MouseEvent mouse_pressed_event(MouseEvent::ET_MOUSE_PRESSED, target_point.x(), target_point.y(), - event.GetFlags()); + event.flags()); active_mouse_view_->OnMousePressed(mouse_pressed_event); } } @@ -1805,7 +1805,7 @@ void MenuController::UpdateActiveMouseView(SubmenuView* event_source, View::ConvertPointToView(target_menu, active_mouse_view_, &target_point); MouseEvent mouse_dragged_event(MouseEvent::ET_MOUSE_DRAGGED, target_point.x(), target_point.y(), - event.GetFlags()); + event.flags()); active_mouse_view_->OnMouseDragged(mouse_dragged_event); } } @@ -1821,7 +1821,7 @@ void MenuController::SendMouseReleaseToActiveView(SubmenuView* event_source, &target_loc); View::ConvertPointToView(NULL, active_mouse_view_, &target_loc); MouseEvent release_event(Event::ET_MOUSE_RELEASED, target_loc.x(), - target_loc.y(), event.GetFlags()); + target_loc.y(), event.flags()); // Reset the active_mouse_view_ before sending mouse released. That way if if // calls back to use we aren't in a weird state. View* active_view = active_mouse_view_; diff --git a/views/controls/menu/submenu_view.cc b/views/controls/menu/submenu_view.cc index 56bd103..8a1f079 100644 --- a/views/controls/menu/submenu_view.cc +++ b/views/controls/menu/submenu_view.cc @@ -195,11 +195,11 @@ bool SubmenuView::OnMouseWheel(const MouseWheelEvent& e) { // If the first item isn't entirely visible, make it visible, otherwise make // the next/previous one entirely visible. #if defined(OS_WIN) - int delta = abs(e.GetOffset() / WHEEL_DELTA); + int delta = abs(e.offset() / WHEEL_DELTA); #elif defined(OS_LINUX) - int delta = abs(e.GetOffset()); + int delta = abs(e.offset()); #endif - for (bool scroll_up = (e.GetOffset() > 0); delta != 0; --delta) { + for (bool scroll_up = (e.offset() > 0); delta != 0; --delta) { int scroll_target; if (scroll_up) { if (GetMenuItemAt(first_vis_index)->y() == vis_bounds.y()) { diff --git a/views/controls/scrollbar/bitmap_scroll_bar.cc b/views/controls/scrollbar/bitmap_scroll_bar.cc index cf0e919..a60d666 100644 --- a/views/controls/scrollbar/bitmap_scroll_bar.cc +++ b/views/controls/scrollbar/bitmap_scroll_bar.cc @@ -491,13 +491,13 @@ void BitmapScrollBar::OnMouseReleased(const MouseEvent& event, bool canceled) { } bool BitmapScrollBar::OnMouseWheel(const MouseWheelEvent& event) { - ScrollByContentsOffset(event.GetOffset()); + ScrollByContentsOffset(event.offset()); return true; } bool BitmapScrollBar::OnKeyPressed(const KeyEvent& event) { ScrollAmount amount = SCROLL_NONE; - switch (event.GetKeyCode()) { + switch (event.key_code()) { case ui::VKEY_UP: if (!IsHorizontal()) amount = SCROLL_PREV_LINE; diff --git a/views/controls/scrollbar/native_scroll_bar_gtk.cc b/views/controls/scrollbar/native_scroll_bar_gtk.cc index 73bb109..dc1a9b6 100644 --- a/views/controls/scrollbar/native_scroll_bar_gtk.cc +++ b/views/controls/scrollbar/native_scroll_bar_gtk.cc @@ -44,7 +44,7 @@ gfx::Size NativeScrollBarGtk::GetPreferredSize() { bool NativeScrollBarGtk::OnKeyPressed(const KeyEvent& event) { if (!native_view()) return false; - switch (event.GetKeyCode()) { + switch (event.key_code()) { case ui::VKEY_UP: if (!native_scroll_bar_->IsHorizontal()) MoveStep(false /* negative */); @@ -82,7 +82,7 @@ bool NativeScrollBarGtk::OnKeyPressed(const KeyEvent& event) { bool NativeScrollBarGtk::OnMouseWheel(const MouseWheelEvent& e) { if (!native_view()) return false; - MoveBy(-e.GetOffset()); // e.GetOffset() > 0 means scroll up. + MoveBy(-e.offset()); // e.GetOffset() > 0 means scroll up. return true; } diff --git a/views/controls/scrollbar/native_scroll_bar_win.cc b/views/controls/scrollbar/native_scroll_bar_win.cc index 44d8bf6..01cd5f8 100644 --- a/views/controls/scrollbar/native_scroll_bar_win.cc +++ b/views/controls/scrollbar/native_scroll_bar_win.cc @@ -230,7 +230,7 @@ bool NativeScrollBarWin::OnKeyPressed(const KeyEvent& event) { if (!sb_container_.get()) return false; int code = -1; - switch (event.GetKeyCode()) { + switch (event.key_code()) { case ui::VKEY_UP: if (!native_scroll_bar_->IsHorizontal()) code = SB_LINEUP; @@ -272,7 +272,7 @@ bool NativeScrollBarWin::OnKeyPressed(const KeyEvent& event) { bool NativeScrollBarWin::OnMouseWheel(const MouseWheelEvent& e) { if (!sb_container_.get()) return false; - sb_container_->ScrollWithOffset(e.GetOffset()); + sb_container_->ScrollWithOffset(e.offset()); return true; } diff --git a/views/controls/textfield/native_textfield_views.cc b/views/controls/textfield/native_textfield_views.cc index 11649ebf..3b3e15e 100644 --- a/views/controls/textfield/native_textfield_views.cc +++ b/views/controls/textfield/native_textfield_views.cc @@ -531,8 +531,8 @@ void NativeTextfieldViews::PaintTextAndCursor(gfx::Canvas* canvas) { bool NativeTextfieldViews::HandleKeyEvent(const KeyEvent& key_event) { // TODO(oshima): handle IME. - if (key_event.GetType() == views::Event::ET_KEY_PRESSED) { - ui::KeyboardCode key_code = key_event.GetKeyCode(); + if (key_event.type() == views::Event::ET_KEY_PRESSED) { + ui::KeyboardCode key_code = key_event.key_code(); // TODO(oshima): shift-tab does not work. Figure out why and fix. if (key_code == ui::VKEY_TAB) return false; @@ -642,7 +642,7 @@ bool NativeTextfieldViews::HandleKeyEvent(const KeyEvent& key_event) { char16 NativeTextfieldViews::GetPrintableChar(const KeyEvent& key_event) { // TODO(oshima): IME, i18n support. // This only works for UCS-2 characters. - ui::KeyboardCode key_code = key_event.GetKeyCode(); + ui::KeyboardCode key_code = key_event.key_code(); bool shift = key_event.IsShiftDown(); bool upper = shift ^ key_event.IsCapsLockDown(); // TODO(oshima): We should have a utility function @@ -790,9 +790,9 @@ size_t NativeTextfieldViews::FindCursorPosition(const gfx::Point& point) const { bool NativeTextfieldViews::HandleMousePressed(const views::MouseEvent& e) { textfield_->RequestFocus(); - base::TimeDelta time_delta = e.GetTimeStamp() - last_mouse_press_time_; + base::TimeDelta time_delta = e.time_stamp() - last_mouse_press_time_; gfx::Point location_delta = e.location().Subtract(last_mouse_press_location_); - last_mouse_press_time_ = e.GetTimeStamp(); + last_mouse_press_time_ = e.time_stamp(); last_mouse_press_location_ = e.location(); if (e.IsLeftMouseButton()) { if (!ExceededDragThreshold(location_delta.x(), location_delta.y()) diff --git a/views/controls/textfield/textfield.cc b/views/controls/textfield/textfield.cc index 1b4461c..9028f88 100644 --- a/views/controls/textfield/textfield.cc +++ b/views/controls/textfield/textfield.cc @@ -309,7 +309,7 @@ void Textfield::AboutToRequestFocusFromTabTraversal(bool reverse) { bool Textfield::SkipDefaultKeyEventProcessing(const KeyEvent& e) { // TODO(hamaji): Figure out which keyboard combinations we need to add here, // similar to LocationBarView::SkipDefaultKeyEventProcessing. - ui::KeyboardCode key = e.GetKeyCode(); + ui::KeyboardCode key = e.key_code(); if (key == ui::VKEY_BACK) return true; // We'll handle BackSpace ourselves. diff --git a/views/events/event.h b/views/events/event.h index b16371e..c641795 100644 --- a/views/events/event.h +++ b/views/events/event.h @@ -10,6 +10,7 @@ #include "base/time.h" #include "ui/base/keycodes/keyboard_codes.h" #include "ui/gfx/point.h" +#include "views/native_types.h" #if defined(OS_LINUX) typedef struct _GdkEventKey GdkEventKey; @@ -76,43 +77,18 @@ class Event { EF_COMMAND_DOWN = 1 << 7, // Only useful on OSX }; - // Return the event type - EventType GetType() const { - return type_; - } - - // Return the event time stamp. - const base::Time& GetTimeStamp() const { - return time_stamp_; - } - - // Return the flags - int GetFlags() const { - return flags_; - } - - void set_flags(int flags) { - flags_ = flags; - } + const NativeEvent& native_event() const { return native_event_; } + EventType type() const { return type_; } + const base::Time& time_stamp() const { return time_stamp_; } + int flags() const { return flags_; } + void set_flags(int flags) { flags_ = flags; } - // Return whether the shift modifier is down - bool IsShiftDown() const { - return (flags_ & EF_SHIFT_DOWN) != 0; - } - - // Return whether the control modifier is down - bool IsControlDown() const { - return (flags_ & EF_CONTROL_DOWN) != 0; - } - - bool IsCapsLockDown() const { - return (flags_ & EF_CAPS_LOCK_DOWN) != 0; - } - - // Return whether the alt modifier is down - bool IsAltDown() const { - return (flags_ & EF_ALT_DOWN) != 0; - } + // The following methods return true if the respective keys were pressed at + // the time the event was created. + bool IsShiftDown() const { return (flags_ & EF_SHIFT_DOWN) != 0; } + bool IsControlDown() const { return (flags_ & EF_CONTROL_DOWN) != 0; } + bool IsCapsLockDown() const { return (flags_ & EF_CAPS_LOCK_DOWN) != 0; } + bool IsAltDown() const { return (flags_ & EF_ALT_DOWN) != 0; } bool IsMouseEvent() const { return type_ == ET_MOUSE_PRESSED || @@ -149,14 +125,16 @@ class Event { Event(EventType type, int flags); Event(const Event& model) - : type_(model.GetType()), - time_stamp_(model.GetTimeStamp()), - flags_(model.GetFlags()) { + : native_event_(model.native_event()), + type_(model.type()), + time_stamp_(model.time_stamp()), + flags_(model.flags()) { } private: void operator=(const Event&); + NativeEvent native_event_; EventType type_; base::Time time_stamp_; int flags_; @@ -182,20 +160,9 @@ class LocatedEvent : public Event { // from 'from' coordinate system to 'to' coordinate system LocatedEvent(const LocatedEvent& model, View* from, View* to); - // Returns the X location. - int x() const { - return location_.x(); - } - - // Returns the Y location. - int y() const { - return location_.y(); - } - - // Returns the location. - const gfx::Point& location() const { - return location_; - } + int x() const { return location_.x(); } + int y() const { return location_.y(); } + const gfx::Point& location() const { return location_; } private: gfx::Point location_; @@ -242,30 +209,30 @@ class MouseEvent : public LocatedEvent { // Conveniences to quickly test what button is down bool IsOnlyLeftMouseButton() const { - return (GetFlags() & EF_LEFT_BUTTON_DOWN) && - !(GetFlags() & (EF_MIDDLE_BUTTON_DOWN | EF_RIGHT_BUTTON_DOWN)); + return (flags() & EF_LEFT_BUTTON_DOWN) && + !(flags() & (EF_MIDDLE_BUTTON_DOWN | EF_RIGHT_BUTTON_DOWN)); } bool IsLeftMouseButton() const { - return (GetFlags() & EF_LEFT_BUTTON_DOWN) != 0; + return (flags() & EF_LEFT_BUTTON_DOWN) != 0; } bool IsOnlyMiddleMouseButton() const { - return (GetFlags() & EF_MIDDLE_BUTTON_DOWN) && - !(GetFlags() & (EF_LEFT_BUTTON_DOWN | EF_RIGHT_BUTTON_DOWN)); + return (flags() & EF_MIDDLE_BUTTON_DOWN) && + !(flags() & (EF_LEFT_BUTTON_DOWN | EF_RIGHT_BUTTON_DOWN)); } bool IsMiddleMouseButton() const { - return (GetFlags() & EF_MIDDLE_BUTTON_DOWN) != 0; + return (flags() & EF_MIDDLE_BUTTON_DOWN) != 0; } bool IsOnlyRightMouseButton() const { - return (GetFlags() & EF_RIGHT_BUTTON_DOWN) && - !(GetFlags() & (EF_LEFT_BUTTON_DOWN | EF_MIDDLE_BUTTON_DOWN)); + return (flags() & EF_RIGHT_BUTTON_DOWN) && + !(flags() & (EF_LEFT_BUTTON_DOWN | EF_MIDDLE_BUTTON_DOWN)); } bool IsRightMouseButton() const { - return (GetFlags() & EF_RIGHT_BUTTON_DOWN) != 0; + return (flags() & EF_RIGHT_BUTTON_DOWN) != 0; } private: @@ -306,10 +273,7 @@ class TouchEvent : public LocatedEvent { explicit TouchEvent(XEvent* xev); #endif - // Return the touch point for this event. - bool identity() const { - return touch_id_; - } + bool identity() const { return touch_id_; } private: // The identity (typically finger) of the touch starting at 0 and incrementing @@ -355,25 +319,15 @@ class KeyEvent : public Event { explicit KeyEvent(XEvent* xevent); #endif - // This returns a VKEY_ value as defined in app/keyboard_codes.h which is - // the Windows value. - // On GTK, you can use the methods in keyboard_code_conversion_gtk.cc to - // convert this value back to a GDK value if needed. - ui::KeyboardCode GetKeyCode() const { - return key_code_; - } + ui::KeyboardCode key_code() const { return key_code_; } #if defined(OS_WIN) bool IsExtendedKey() const; - UINT message() const { - return message_; - } + UINT message() const { return message_; } #endif - int GetRepeatCount() const { - return repeat_count_; - } + int repeat_count() const { return repeat_count_; } #if defined(OS_WIN) static int GetKeyStateFlags(); @@ -412,9 +366,7 @@ class MouseWheelEvent : public LocatedEvent { explicit MouseWheelEvent(XEvent* xev); #endif - int GetOffset() const { - return offset_; - } + int offset() const { return offset_; } private: int offset_; @@ -441,14 +393,14 @@ class DropTargetEvent : public LocatedEvent { source_operations_(source_operations) { } - // Data associated with the drag/drop session. - const OSExchangeData& GetData() const { return data_; } - - // Bitmask of supported ui::DragDropTypes::DragOperation by the source. - int GetSourceOperations() const { return source_operations_; } + const OSExchangeData& data() const { return data_; } + int source_operations() const { return source_operations_; } private: + // Data associated with the drag/drop session. const OSExchangeData& data_; + + // Bitmask of supported ui::DragDropTypes::DragOperation by the source. int source_operations_; DISALLOW_COPY_AND_ASSIGN(DropTargetEvent); diff --git a/views/focus/focus_manager.cc b/views/focus/focus_manager.cc index d217e63..5e5b2f4 100644 --- a/views/focus/focus_manager.cc +++ b/views/focus/focus_manager.cc @@ -120,7 +120,7 @@ bool FocusManager::OnKeyEvent(const KeyEvent& event) { #endif // Intercept arrow key messages to switch between grouped views. - ui::KeyboardCode key_code = event.GetKeyCode(); + ui::KeyboardCode key_code = event.key_code(); if (focused_view_ && focused_view_->GetGroup() != -1 && (key_code == ui::VKEY_UP || key_code == ui::VKEY_DOWN || key_code == ui::VKEY_LEFT || key_code == ui::VKEY_RIGHT)) { @@ -146,7 +146,7 @@ bool FocusManager::OnKeyEvent(const KeyEvent& event) { // Process keyboard accelerators. // If the key combination matches an accelerator, the accelerator is // triggered, otherwise the key event is processed as usual. - Accelerator accelerator(event.GetKeyCode(), + Accelerator accelerator(event.key_code(), event.IsShiftDown(), event.IsControlDown(), event.IsAltDown()); @@ -509,8 +509,7 @@ AcceleratorTarget* FocusManager::GetCurrentTargetForAccelerator( // static bool FocusManager::IsTabTraversalKeyEvent(const KeyEvent& key_event) { - return key_event.GetKeyCode() == ui::VKEY_TAB && - !key_event.IsControlDown(); + return key_event.key_code() == ui::VKEY_TAB && !key_event.IsControlDown(); } void FocusManager::ViewRemoved(View* parent, View* removed) { diff --git a/views/focus/focus_manager_unittest.cc b/views/focus/focus_manager_unittest.cc index bd21c16..457ed09 100644 --- a/views/focus/focus_manager_unittest.cc +++ b/views/focus/focus_manager_unittest.cc @@ -1448,12 +1448,12 @@ class MessageTrackingView : public View { } virtual bool OnKeyPressed(const KeyEvent& e) { - keys_pressed_.push_back(e.GetKeyCode()); + keys_pressed_.push_back(e.key_code()); return true; } virtual bool OnKeyReleased(const KeyEvent& e) { - keys_released_.push_back(e.GetKeyCode()); + keys_released_.push_back(e.key_code()); return true; } diff --git a/views/native_types.h b/views/native_types.h new file mode 100644 index 0000000..abea52e --- /dev/null +++ b/views/native_types.h @@ -0,0 +1,28 @@ +// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#ifndef VIEWS_NATIVE_TYPES_H_ +#define VIEWS_NATIVE_TYPES_H_ +#pragma once + +#include "ui/gfx/native_widget_types.h" + +namespace views { + +#if defined(OS_WIN) +typedef MSG NativeEvent; +#endif +#if defined(OS_LINUX) +typedef union _GdkEvent GdkEvent; +typedef GdkEvent* NativeEvent; +#endif +#if defined(TOUCH_UI) +typedef union _XEvent XEvent; +typedef XEvent* NativeEvent; +#endif + +} // namespace views + +#endif // VIEWS_NATIVE_TYPES_H_ + diff --git a/views/view_unittest.cc b/views/view_unittest.cc index d2dc693..5f4d672 100644 --- a/views/view_unittest.cc +++ b/views/view_unittest.cc @@ -326,19 +326,19 @@ TEST_F(ViewTest, AddRemoveNotifications) { //////////////////////////////////////////////////////////////////////////////// bool TestView::OnMousePressed(const MouseEvent& event) { - last_mouse_event_type_ = event.GetType(); + last_mouse_event_type_ = event.type(); location_.SetPoint(event.x(), event.y()); return true; } bool TestView::OnMouseDragged(const MouseEvent& event) { - last_mouse_event_type_ = event.GetType(); + last_mouse_event_type_ = event.type(); location_.SetPoint(event.x(), event.y()); return true; } void TestView::OnMouseReleased(const MouseEvent& event, bool canceled) { - last_mouse_event_type_ = event.GetType(); + last_mouse_event_type_ = event.type(); location_.SetPoint(event.x(), event.y()); } diff --git a/views/widget/root_view.cc b/views/widget/root_view.cc index 6010d99..3a24ac8 100644 --- a/views/widget/root_view.cc +++ b/views/widget/root_view.cc @@ -386,8 +386,8 @@ bool RootView::OnMousePressed(const MouseEvent& e) { // are formed from a single-click followed by a double-click event. When the // double-click event lands on a different view than its single-click part, // we transform it into a single-click which prevents odd things. - if ((e.GetFlags() & MouseEvent::EF_IS_NON_CLIENT) && - !(e.GetFlags() & MouseEvent::EF_IS_DOUBLE_CLICK)) { + if ((e.flags() & MouseEvent::EF_IS_NON_CLIENT) && + !(e.flags() & MouseEvent::EF_IS_DOUBLE_CLICK)) { last_click_handler_ = NULL; return false; } @@ -424,7 +424,7 @@ bool RootView::OnMousePressed(const MouseEvent& e) { // Remove the double-click flag if the handler is different than the // one which got the first click part of the double-click. if (mouse_pressed_handler_ != last_click_handler_) - mouse_pressed_event.set_flags(e.GetFlags() & + mouse_pressed_event.set_flags(e.flags() & ~MouseEvent::EF_IS_DOUBLE_CLICK); drag_info.Reset(); @@ -469,7 +469,7 @@ bool RootView::OnMousePressed(const MouseEvent& e) { // entire hierarchy (even as a single-click when sent to a different view), // it must be marked as handled to avoid anything happening from default // processing if it the first click-part was handled by us. - if (last_click_handler_ && e.GetFlags() & MouseEvent::EF_IS_DOUBLE_CLICK) + if (last_click_handler_ && e.flags() & MouseEvent::EF_IS_DOUBLE_CLICK) hit_disabled_view = true; last_click_handler_ = NULL; @@ -508,7 +508,7 @@ void RootView::UpdateCursor(const MouseEvent& e) { if (v && v != this) { gfx::Point l(e.location()); View::ConvertPointToView(this, v, &l); - cursor = v->GetCursorForPoint(e.GetType(), l); + cursor = v->GetCursorForPoint(e.type(), l); } SetActiveCursor(cursor); } @@ -521,7 +521,7 @@ bool RootView::OnMouseDragged(const MouseEvent& e) { gfx::Point p; ConvertPointToMouseHandler(e.location(), &p); - MouseEvent mouse_event(e.GetType(), p.x(), p.y(), e.GetFlags()); + MouseEvent mouse_event(e.type(), p.x(), p.y(), e.flags()); return mouse_pressed_handler_->ProcessMouseDragged(mouse_event, &drag_info); } return false; @@ -533,7 +533,7 @@ void RootView::OnMouseReleased(const MouseEvent& e, bool canceled) { if (mouse_pressed_handler_) { gfx::Point p; ConvertPointToMouseHandler(e.location(), &p); - MouseEvent mouse_released(e.GetType(), p.x(), p.y(), e.GetFlags()); + MouseEvent mouse_released(e.type(), p.x(), p.y(), e.flags()); // We allow the view to delete us from ProcessMouseReleased. As such, // configure state such that we're done first, then call View. View* mouse_pressed_handler = mouse_pressed_handler_; @@ -576,7 +576,7 @@ void RootView::OnMouseMoved(const MouseEvent& e) { mouse_move_handler_->OnMouseMoved(moved_event); gfx::NativeCursor cursor = mouse_move_handler_->GetCursorForPoint( - moved_event.GetType(), moved_event.location()); + moved_event.type(), moved_event.location()); SetActiveCursor(cursor); } else if (mouse_move_handler_ != NULL) { MouseEvent exited_event(Event::ET_MOUSE_EXITED, 0, 0, 0); @@ -680,18 +680,18 @@ bool RootView::ProcessKeyEvent(const KeyEvent& event) { View* v = GetFocusedView(); // Special case to handle right-click context menus triggered by the // keyboard. - if (v && v->IsEnabled() && ((event.GetKeyCode() == ui::VKEY_APPS) || - (event.GetKeyCode() == ui::VKEY_F10 && event.IsShiftDown()))) { + if (v && v->IsEnabled() && ((event.key_code() == ui::VKEY_APPS) || + (event.key_code() == ui::VKEY_F10 && event.IsShiftDown()))) { v->ShowContextMenu(v->GetKeyboardContextMenuLocation(), false); return true; } for (; v && v != this && !consumed; v = v->parent()) { - consumed = (event.GetType() == Event::ET_KEY_PRESSED) ? + consumed = (event.type() == Event::ET_KEY_PRESSED) ? v->OnKeyPressed(event) : v->OnKeyReleased(event); } if (!consumed && default_keyboard_handler_) { - consumed = (event.GetType() == Event::ET_KEY_PRESSED) ? + consumed = (event.type() == Event::ET_KEY_PRESSED) ? default_keyboard_handler_->OnKeyPressed(event) : default_keyboard_handler_->OnKeyReleased(event); } @@ -758,7 +758,7 @@ void RootView::UnregisterViewForVisibleBoundsNotification(View* view) { } void RootView::SetMouseLocationAndFlags(const MouseEvent& e) { - last_mouse_event_flags_ = e.GetFlags(); + last_mouse_event_flags_ = e.flags(); last_mouse_event_x_ = e.x(); last_mouse_event_y_ = e.y(); } diff --git a/views/widget/widget_gtk.cc b/views/widget/widget_gtk.cc index 730d6f7..4c4466c 100644 --- a/views/widget/widget_gtk.cc +++ b/views/widget/widget_gtk.cc @@ -883,7 +883,7 @@ bool WidgetGtk::HandleKeyboardEvent(GdkEventKey* event) { return false; KeyEvent key(event); - int key_code = key.GetKeyCode(); + int key_code = key.key_code(); bool handled = false; // Always reset |should_handle_menu_key_release_| unless we are handling a @@ -901,7 +901,7 @@ bool WidgetGtk::HandleKeyboardEvent(GdkEventKey* event) { else should_handle_menu_key_release_ = true; } else if (key_code == ui::VKEY_MENU && should_handle_menu_key_release_ && - (key.GetFlags() & ~Event::EF_ALT_DOWN) == 0) { + (key.flags() & ~Event::EF_ALT_DOWN) == 0) { // Trigger VKEY_MENU when only this key is pressed and released, and both // press and release events are not handled by others. Accelerator accelerator(ui::VKEY_MENU, false, false, false); @@ -1174,7 +1174,7 @@ gboolean WidgetGtk::OnKeyEvent(GtkWidget* widget, GdkEventKey* event) { // VKEY_MENU key release event. It ensures that VKEY_MENU accelerator can only // be activated when handling a VKEY_MENU key release event which is preceded // by an unhandled VKEY_MENU key press event. See also HandleKeyboardEvent(). - if (key.GetKeyCode() != ui::VKEY_MENU || event->type != GDK_KEY_RELEASE) + if (key.key_code() != ui::VKEY_MENU || event->type != GDK_KEY_RELEASE) should_handle_menu_key_release_ = false; bool handled = false; |