diff options
author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-01 20:26:06 +0000 |
---|---|---|
committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-01 20:26:06 +0000 |
commit | e7fea95ab2ade9b27606e2e89a4d42db63a4e872 (patch) | |
tree | 195fa757ff9a47e14054d24fb39a6e1ffabefaf6 | |
parent | 10d8398b778db2c47e712d184147db84e48d8d2a (diff) | |
download | chromium_src-e7fea95ab2ade9b27606e2e89a4d42db63a4e872.zip chromium_src-e7fea95ab2ade9b27606e2e89a4d42db63a4e872.tar.gz chromium_src-e7fea95ab2ade9b27606e2e89a4d42db63a4e872.tar.bz2 |
Remove the --use-lf-heap flag.
In 2008 Mike observed:
- Using the LFH on XP has some perf gain at the expense of a lot of RAM.
- Using the LFH on Vista seems to have no impact on perf or RAM.
We don't need to experiment with this flag anymore.
Review URL: http://codereview.chromium.org/6592074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76415 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | chrome/app/chrome_main.cc | 12 | ||||
-rw-r--r-- | chrome/browser/renderer_host/browser_render_process_host.cc | 1 | ||||
-rw-r--r-- | chrome/common/chrome_switches.cc | 3 | ||||
-rw-r--r-- | chrome/common/chrome_switches.h | 1 | ||||
-rw-r--r-- | content/browser/plugin_process_host.cc | 1 |
5 files changed, 0 insertions, 18 deletions
diff --git a/chrome/app/chrome_main.cc b/chrome/app/chrome_main.cc index 3454cc4..5f678fd 100644 --- a/chrome/app/chrome_main.cc +++ b/chrome/app/chrome_main.cc @@ -206,18 +206,6 @@ void SetupCRT(const CommandLine& command_line) { _CrtSetReportMode(_CRT_ASSERT, 0); } #endif - - // Enable the low fragmentation heap for the CRT heap. The heap is not changed - // if the process is run under the debugger is enabled or if certain gflags - // are set. - if (command_line.HasSwitch(switches::kUseLowFragHeapCrt) && - (command_line.GetSwitchValueASCII(switches::kUseLowFragHeapCrt) - != "false")) { - void* crt_heap = reinterpret_cast<void*>(_get_heap_handle()); - ULONG enable_lfh = 2; - HeapSetInformation(crt_heap, HeapCompatibilityInformation, - &enable_lfh, sizeof(enable_lfh)); - } #endif } diff --git a/chrome/browser/renderer_host/browser_render_process_host.cc b/chrome/browser/renderer_host/browser_render_process_host.cc index 30916b4..fab96a0 100644 --- a/chrome/browser/renderer_host/browser_render_process_host.cc +++ b/chrome/browser/renderer_host/browser_render_process_host.cc @@ -740,7 +740,6 @@ void BrowserRenderProcessHost::PropagateBrowserCommandLineToRenderer( // This flag needs to be propagated to the renderer process for // --in-process-webgl. switches::kUseGL, - switches::kUseLowFragHeapCrt, switches::kUserAgent, switches::kV, switches::kVideoThreads, diff --git a/chrome/common/chrome_switches.cc b/chrome/common/chrome_switches.cc index 7e87a56..0be38c8 100644 --- a/chrome/common/chrome_switches.cc +++ b/chrome/common/chrome_switches.cc @@ -1227,9 +1227,6 @@ const char kUnlimitedQuotaForFiles[] = "unlimited-quota-for-files"; // browsing. It is ignored in single process mode. const char kUnlimitedQuotaForIndexedDB[] = "unlimited-quota-for-indexeddb"; -// Use the low fragmentation heap for the CRT. -const char kUseLowFragHeapCrt[] = "use-lf-heap"; - // A string used to override the default user agent with a custom one. const char kUserAgent[] = "user-agent"; diff --git a/chrome/common/chrome_switches.h b/chrome/common/chrome_switches.h index 1d2eb41..6b8e757 100644 --- a/chrome/common/chrome_switches.h +++ b/chrome/common/chrome_switches.h @@ -339,7 +339,6 @@ extern const char kMaxSpdySessionsPerDomain[]; extern const char kMaxSpdyConcurrentStreams[]; extern const char kUnlimitedQuotaForFiles[]; extern const char kUnlimitedQuotaForIndexedDB[]; -extern const char kUseLowFragHeapCrt[]; extern const char kUserAgent[]; extern const char kUserDataDir[]; extern const char kUserScriptsDir[]; diff --git a/content/browser/plugin_process_host.cc b/content/browser/plugin_process_host.cc index 0cbb756..4d1301a 100644 --- a/content/browser/plugin_process_host.cc +++ b/content/browser/plugin_process_host.cc @@ -220,7 +220,6 @@ bool PluginProcessHost::Init(const webkit::npapi::WebPluginInfo& info, switches::kEnableDCHECK, switches::kSilentDumpOnDCHECK, switches::kMemoryProfiling, - switches::kUseLowFragHeapCrt, switches::kEnableStatsTable, switches::kEnableGPUPlugin, switches::kUseGL, |