summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorrobertshield@chromium.org <robertshield@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-10-26 20:20:59 +0000
committerrobertshield@chromium.org <robertshield@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-10-26 20:20:59 +0000
commiteba0116741b4849809fc57d97cdf527a1b5da507 (patch)
treefc9aabc242ed7cc1123b54a2cd9af0111efc9dbc
parentac43f703a731d232ea095c28a5367f2cdd2bd7b2 (diff)
downloadchromium_src-eba0116741b4849809fc57d97cdf527a1b5da507.zip
chromium_src-eba0116741b4849809fc57d97cdf527a1b5da507.tar.gz
chromium_src-eba0116741b4849809fc57d97cdf527a1b5da507.tar.bz2
Add metrics tracking how many times users are bugged with "version mismatch, please restart your browser" dialogs during CF udpates. If this number gets high, we should do something better.
BUG=none TEST=none Review URL: http://codereview.chromium.org/4110001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63936 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome_frame/chrome_frame_activex.cc1
-rw-r--r--chrome_frame/chrome_frame_npapi.cc1
2 files changed, 2 insertions, 0 deletions
diff --git a/chrome_frame/chrome_frame_activex.cc b/chrome_frame/chrome_frame_activex.cc
index 5d7904a..a5d6d99 100644
--- a/chrome_frame/chrome_frame_activex.cc
+++ b/chrome_frame/chrome_frame_activex.cc
@@ -252,6 +252,7 @@ void ChromeFrameActivex::OnAutomationServerLaunchFailed(
// Do not display warnings for privileged instances of Chrome Frame.
if (reason == AUTOMATION_VERSION_MISMATCH && !is_privileged_) {
+ THREAD_SAFE_UMA_HISTOGRAM_COUNTS("ChromeFrame.VersionMismatchDisplayed", 1);
DisplayVersionMismatchWarning(m_hWnd, server_version);
}
}
diff --git a/chrome_frame/chrome_frame_npapi.cc b/chrome_frame/chrome_frame_npapi.cc
index 0a087b7..267516f 100644
--- a/chrome_frame/chrome_frame_npapi.cc
+++ b/chrome_frame/chrome_frame_npapi.cc
@@ -868,6 +868,7 @@ void ChromeFrameNPAPI::OnAutomationServerLaunchFailed(
// Do not display warnings for privileged instances of Chrome Frame.
if (reason == AUTOMATION_VERSION_MISMATCH && !is_privileged_) {
+ THREAD_SAFE_UMA_HISTOGRAM_COUNTS("ChromeFrame.VersionMismatchDisplayed", 1);
DisplayVersionMismatchWarning(m_hWnd, server_version);
}
}