diff options
author | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-12 02:47:52 +0000 |
---|---|---|
committer | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-12 02:47:52 +0000 |
commit | a41dec94dcb81268cfb45be72ac6105e2ed686b7 (patch) | |
tree | 1ae368d5fd66b526c566b091fbd90a6f2ef0c2d6 | |
parent | 9508f239f64b85fa913df6f7518c231b6bf7e78c (diff) | |
download | chromium_src-a41dec94dcb81268cfb45be72ac6105e2ed686b7.zip chromium_src-a41dec94dcb81268cfb45be72ac6105e2ed686b7.tar.gz chromium_src-a41dec94dcb81268cfb45be72ac6105e2ed686b7.tar.bz2 |
Final (?) set of changes to unblock WebLocalFrame in blink.
Mostly mechanical like several other proceeding CLs. This is to unblock
https://codereview.chromium.org/232133004/ so it can land in Blink and
roll into Chrome.
BUG=346764
R=bauerb@chromium.org, jam@chromium.org, mkosiba@chromium.org
Review URL: https://codereview.chromium.org/234263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263449 0039d316-1c4b-4281-b951-d872f2087c98
18 files changed, 85 insertions, 74 deletions
diff --git a/android_webview/renderer/aw_render_view_ext.cc b/android_webview/renderer/aw_render_view_ext.cc index a20e55c..b12821e 100644 --- a/android_webview/renderer/aw_render_view_ext.cc +++ b/android_webview/renderer/aw_render_view_ext.cc @@ -24,9 +24,9 @@ #include "third_party/WebKit/public/web/WebDocument.h" #include "third_party/WebKit/public/web/WebElement.h" #include "third_party/WebKit/public/web/WebElementCollection.h" -#include "third_party/WebKit/public/web/WebFrame.h" #include "third_party/WebKit/public/web/WebHitTestResult.h" #include "third_party/WebKit/public/web/WebImageCache.h" +#include "third_party/WebKit/public/web/WebLocalFrame.h" #include "third_party/WebKit/public/web/WebNode.h" #include "third_party/WebKit/public/web/WebSecurityOrigin.h" #include "third_party/WebKit/public/web/WebView.h" @@ -180,7 +180,7 @@ void AwRenderViewExt::OnDocumentHasImagesRequest(int id) { hasImages)); } -void AwRenderViewExt::DidCommitProvisionalLoad(blink::WebFrame* frame, +void AwRenderViewExt::DidCommitProvisionalLoad(blink::WebLocalFrame* frame, bool is_new_navigation) { content::DocumentState* document_state = content::DocumentState::FromDataSource(frame->dataSource()); diff --git a/android_webview/renderer/aw_render_view_ext.h b/android_webview/renderer/aw_render_view_ext.h index 838344b..911bbe0 100644 --- a/android_webview/renderer/aw_render_view_ext.h +++ b/android_webview/renderer/aw_render_view_ext.h @@ -34,7 +34,7 @@ class AwRenderViewExt : public content::RenderViewObserver { // RenderView::Observer: virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; - virtual void DidCommitProvisionalLoad(blink::WebFrame* frame, + virtual void DidCommitProvisionalLoad(blink::WebLocalFrame* frame, bool is_new_navigation) OVERRIDE; virtual void FocusedNodeChanged(const blink::WebNode& node) OVERRIDE; virtual void DidCommitCompositorFrame() OVERRIDE; diff --git a/android_webview/renderer/print_web_view_helper.cc b/android_webview/renderer/print_web_view_helper.cc index fe1ac8d..6179a31 100644 --- a/android_webview/renderer/print_web_view_helper.cc +++ b/android_webview/renderer/print_web_view_helper.cc @@ -379,7 +379,7 @@ bool IsPrintThrottlingDisabled() { } // namespace -FrameReference::FrameReference(blink::WebFrame* frame) { +FrameReference::FrameReference(blink::WebLocalFrame* frame) { Reset(frame); } @@ -390,7 +390,7 @@ FrameReference::FrameReference() { FrameReference::~FrameReference() { } -void FrameReference::Reset(blink::WebFrame* frame) { +void FrameReference::Reset(blink::WebLocalFrame* frame) { if (frame) { view_ = frame->view(); frame_ = frame; @@ -400,13 +400,13 @@ void FrameReference::Reset(blink::WebFrame* frame) { } } -blink::WebFrame* FrameReference::GetFrame() { +blink::WebLocalFrame* FrameReference::GetFrame() { if (view_ == NULL || frame_ == NULL) return NULL; for (blink::WebFrame* frame = view_->mainFrame(); frame != NULL; frame = frame->traverseNext(false)) { if (frame == frame_) - return frame; + return frame_; } return NULL; } @@ -440,7 +440,7 @@ void PrintWebViewHelper::PrintHeaderAndFooter( blink::WebView* web_view = blink::WebView::create(NULL); web_view->settings()->setJavaScriptEnabled(true); - blink::WebFrame* frame = blink::WebFrame::create(NULL) + blink::WebFrame* frame = blink::WebLocalFrame::create(NULL) web_view->setMainFrame(web_frame); base::StringValue html( @@ -503,7 +503,7 @@ class PrepareFrameAndViewForPrint : public blink::WebViewClient, public blink::WebFrameClient { public: PrepareFrameAndViewForPrint(const PrintMsg_Print_Params& params, - blink::WebFrame* frame, + blink::WebLocalFrame* frame, const blink::WebNode& node, bool ignore_css_margins); virtual ~PrepareFrameAndViewForPrint(); @@ -516,7 +516,7 @@ class PrepareFrameAndViewForPrint : public blink::WebViewClient, // Prepares frame for printing. void StartPrinting(); - blink::WebFrame* frame() { + blink::WebLocalFrame* frame() { return frame_.GetFrame(); } @@ -542,7 +542,7 @@ class PrepareFrameAndViewForPrint : public blink::WebViewClient, virtual void didStopLoading(); // blink::WebFrameClient override: - virtual blink::WebFrame* createChildFrame(blink::WebFrame* parent, + virtual blink::WebFrame* createChildFrame(blink::WebLocalFrame* parent, const blink::WebString& name); virtual void frameDetached(blink::WebFrame* frame); @@ -571,7 +571,7 @@ class PrepareFrameAndViewForPrint : public blink::WebViewClient, PrepareFrameAndViewForPrint::PrepareFrameAndViewForPrint( const PrintMsg_Print_Params& params, - blink::WebFrame* frame, + blink::WebLocalFrame* frame, const blink::WebNode& node, bool ignore_css_margins) : weak_ptr_factory_(this), @@ -662,8 +662,8 @@ void PrepareFrameAndViewForPrint::CopySelection( owns_web_view_ = true; content::ApplyWebPreferences(prefs, web_view); - web_view->setMainFrame(blink::WebFrame::create(this)); - frame_.Reset(web_view->mainFrame()); + web_view->setMainFrame(blink::WebLocalFrame::create(this)); + frame_.Reset(web_view->mainFrame()->toWebLocalFrame()); node_to_print_.reset(); // When loading is done this will call didStopLoading() and that will do the @@ -682,9 +682,9 @@ void PrepareFrameAndViewForPrint::didStopLoading() { } blink::WebFrame* PrepareFrameAndViewForPrint::createChildFrame( - blink::WebFrame* parent, + blink::WebLocalFrame* parent, const blink::WebString& name) { - blink::WebFrame* frame = blink::WebFrame::create(this); + blink::WebFrame* frame = blink::WebLocalFrame::create(this); parent->appendChild(frame); return frame; } @@ -786,7 +786,7 @@ void PrintWebViewHelper::DidStopLoading() { } // Prints |frame| which called window.print(). -void PrintWebViewHelper::PrintPage(blink::WebFrame* frame, +void PrintWebViewHelper::PrintPage(blink::WebLocalFrame* frame, bool user_initiated) { DCHECK(frame); @@ -855,7 +855,7 @@ void PrintWebViewHelper::OnPrintForPrintPreview( // on return. base::AutoReset<bool> set_printing_flag(&print_for_preview_, true); - blink::WebFrame* pdf_frame = pdf_element.document().frame(); + blink::WebLocalFrame* pdf_frame = pdf_element.document().frame(); if (!UpdatePrintSettings(pdf_frame, pdf_element, job_settings)) { LOG(ERROR) << "UpdatePrintSettings failed"; DidFinishPrinting(FAIL_PRINT); @@ -881,7 +881,7 @@ void PrintWebViewHelper::OnPrintForPrintPreview( } } -bool PrintWebViewHelper::GetPrintFrame(blink::WebFrame** frame) { +bool PrintWebViewHelper::GetPrintFrame(blink::WebLocalFrame** frame) { DCHECK(frame); blink::WebView* webView = render_view()->GetWebView(); DCHECK(webView); @@ -890,19 +890,22 @@ bool PrintWebViewHelper::GetPrintFrame(blink::WebFrame** frame) { // If the user has selected text in the currently focused frame we print // only that frame (this makes print selection work for multiple frames). - blink::WebFrame* focusedFrame = webView->focusedFrame(); - *frame = focusedFrame->hasSelection() ? focusedFrame : webView->mainFrame(); + blink::WebLocalFrame* focusedFrame = + webView->focusedFrame()->toWebLocalFrame(); + *frame = focusedFrame->hasSelection() + ? focusedFrame + : webView->mainFrame()->toWebLocalFrame(); return true; } void PrintWebViewHelper::OnPrintPages() { - blink::WebFrame* frame; + blink::WebLocalFrame* frame; if (GetPrintFrame(&frame)) Print(frame, blink::WebNode()); } void PrintWebViewHelper::OnPrintForSystemDialog() { - blink::WebFrame* frame = print_preview_context_.source_frame(); + blink::WebLocalFrame* frame = print_preview_context_.source_frame(); if (!frame) { NOTREACHED(); return; @@ -1165,7 +1168,7 @@ void PrintWebViewHelper::SetScriptedPrintBlocked(bool blocked) { void PrintWebViewHelper::OnInitiatePrintPreview(bool selection_only) { DCHECK(is_preview_enabled_); - blink::WebFrame* frame = NULL; + blink::WebLocalFrame* frame = NULL; GetPrintFrame(&frame); DCHECK(frame); print_preview_context_.InitWithFrame(frame); @@ -1209,7 +1212,7 @@ void PrintWebViewHelper::PrintNode(const blink::WebNode& node) { print_node_in_progress_ = false; } -void PrintWebViewHelper::Print(blink::WebFrame* frame, +void PrintWebViewHelper::Print(blink::WebLocalFrame* frame, const blink::WebNode& node) { // If still not finished with earlier print request simply ignore. if (prep_frame_view_) @@ -1408,7 +1411,7 @@ bool PrintWebViewHelper::InitPrintSettings(bool fit_to_paper_size) { return result; } -bool PrintWebViewHelper::CalculateNumberOfPages(blink::WebFrame* frame, +bool PrintWebViewHelper::CalculateNumberOfPages(blink::WebLocalFrame* frame, const blink::WebNode& node, int* number_of_pages) { DCHECK(frame); @@ -1435,7 +1438,7 @@ bool PrintWebViewHelper::CalculateNumberOfPages(blink::WebFrame* frame, } bool PrintWebViewHelper::UpdatePrintSettings( - blink::WebFrame* frame, + blink::WebLocalFrame* frame, const blink::WebNode& node, const base::DictionaryValue& passed_job_settings) { DCHECK(is_preview_enabled_); @@ -1572,7 +1575,7 @@ bool PrintWebViewHelper::GetPrintSettingsFromUser(blink::WebFrame* frame, return (print_settings.params.dpi && print_settings.params.document_cookie); } -bool PrintWebViewHelper::RenderPagesForPrint(blink::WebFrame* frame, +bool PrintWebViewHelper::RenderPagesForPrint(blink::WebLocalFrame* frame, const blink::WebNode& node) { if (!frame || prep_frame_view_) return false; @@ -1782,7 +1785,7 @@ PrintWebViewHelper::PrintPreviewContext::~PrintPreviewContext() { } void PrintWebViewHelper::PrintPreviewContext::InitWithFrame( - blink::WebFrame* web_frame) { + blink::WebLocalFrame* web_frame) { DCHECK(web_frame); DCHECK(!IsRendering()); state_ = INITIALIZED; @@ -1958,7 +1961,7 @@ void PrintWebViewHelper::PrintPreviewContext::set_error( error_ = error; } -blink::WebFrame* PrintWebViewHelper::PrintPreviewContext::source_frame() { +blink::WebLocalFrame* PrintWebViewHelper::PrintPreviewContext::source_frame() { DCHECK(state_ != UNINITIALIZED); return source_frame_.GetFrame(); } @@ -1969,7 +1972,8 @@ const blink::WebNode& return source_node_; } -blink::WebFrame* PrintWebViewHelper::PrintPreviewContext::prepared_frame() { +blink::WebLocalFrame* +PrintWebViewHelper::PrintPreviewContext::prepared_frame() { DCHECK(state_ != UNINITIALIZED); return prep_frame_view_->frame(); } diff --git a/android_webview/renderer/print_web_view_helper.h b/android_webview/renderer/print_web_view_helper.h index 18ef9ea..23dbec2 100644 --- a/android_webview/renderer/print_web_view_helper.h +++ b/android_webview/renderer/print_web_view_helper.h @@ -45,18 +45,18 @@ class PrepareFrameAndViewForPrint; // If WebFrame someday supports WeakPtr, we should use it here. class FrameReference { public: - explicit FrameReference(blink::WebFrame* frame); + explicit FrameReference(blink::WebLocalFrame* frame); FrameReference(); ~FrameReference(); - void Reset(blink::WebFrame* frame); + void Reset(blink::WebLocalFrame* frame); - blink::WebFrame* GetFrame(); + blink::WebLocalFrame* GetFrame(); blink::WebView* view(); private: blink::WebView* view_; - blink::WebFrame* frame_; + blink::WebLocalFrame* frame_; }; // PrintWebViewHelper handles most of the printing grunt work for RenderView. @@ -115,7 +115,8 @@ class PrintWebViewHelper // RenderViewObserver implementation. virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; - virtual void PrintPage(blink::WebFrame* frame, bool user_initiated) OVERRIDE; + virtual void PrintPage(blink::WebLocalFrame* frame, + bool user_initiated) OVERRIDE; virtual void DidStartLoading() OVERRIDE; virtual void DidStopLoading() OVERRIDE; @@ -182,7 +183,7 @@ class PrintWebViewHelper // Main printing code ------------------------------------------------------- - void Print(blink::WebFrame* frame, const blink::WebNode& node); + void Print(blink::WebLocalFrame* frame, const blink::WebNode& node); // Notification when printing is done - signal tear-down/free resources. void DidFinishPrinting(PrintingResult result); @@ -194,14 +195,14 @@ class PrintWebViewHelper bool InitPrintSettings(bool fit_to_paper_size); // Calculate number of pages in source document. - bool CalculateNumberOfPages(blink::WebFrame* frame, + bool CalculateNumberOfPages(blink::WebLocalFrame* frame, const blink::WebNode& node, int* number_of_pages); // Update the current print settings with new |passed_job_settings|. // |passed_job_settings| dictionary contains print job details such as printer // name, number of copies, page range, etc. - bool UpdatePrintSettings(blink::WebFrame* frame, + bool UpdatePrintSettings(blink::WebLocalFrame* frame, const blink::WebNode& node, const base::DictionaryValue& passed_job_settings); @@ -233,7 +234,7 @@ class PrintWebViewHelper #endif // Render the frame for printing. - bool RenderPagesForPrint(blink::WebFrame* frame, + bool RenderPagesForPrint(blink::WebLocalFrame* frame, const blink::WebNode& node); // Platform specific helper function for rendering page(s) to |metafile|. @@ -292,7 +293,7 @@ class PrintWebViewHelper const base::DictionaryValue& header_footer_info, const PrintMsg_Print_Params& params); - bool GetPrintFrame(blink::WebFrame** frame); + bool GetPrintFrame(blink::WebLocalFrame** frame); // Script Initiated Printing ------------------------------------------------ @@ -365,7 +366,7 @@ class PrintWebViewHelper // Initializes the print preview context. Need to be called to set // the |web_frame| / |web_node| to generate the print preview for. - void InitWithFrame(blink::WebFrame* web_frame); + void InitWithFrame(blink::WebLocalFrame* web_frame); void InitWithNode(const blink::WebNode& web_node); // Does bookkeeping at the beginning of print preview. @@ -406,13 +407,13 @@ class PrintWebViewHelper // Getters // Original frame for which preview was requested. - blink::WebFrame* source_frame(); + blink::WebLocalFrame* source_frame(); // Original node for which preview was requested. const blink::WebNode& source_node() const; // Frame to be use to render preview. May be the same as source_frame(), or // generated from it, e.g. copy of selected block. - blink::WebFrame* prepared_frame(); + blink::WebLocalFrame* prepared_frame(); // Node to be use to render preview. May be the same as source_node(), or // generated from it, e.g. copy of selected block. const blink::WebNode& prepared_node() const; diff --git a/chrome/chrome_dll.gypi b/chrome/chrome_dll.gypi index e99c437..acad974 100644 --- a/chrome/chrome_dll.gypi +++ b/chrome/chrome_dll.gypi @@ -109,6 +109,8 @@ '../chrome/chrome_resources.gyp:chrome_unscaled_resources', '../crypto/crypto.gyp:crypto', '../net/net.gyp:net_resources', + # TODO(dcheng): remove this temporary hack once WebLocalFrame lands and rolls. + '../third_party/WebKit/public/blink_headers.gyp:blink_headers', '../ui/views/views.gyp:views', '../webkit/webkit_resources.gyp:webkit_resources', ], @@ -361,6 +363,8 @@ '<@(chromium_child_dependencies)', '../content/content.gyp:content_app_child', '../content/content.gyp:content_worker', + # TODO(dcheng): remove this temporary hack once WebLocalFrame lands and rolls. + '../third_party/WebKit/public/blink_headers.gyp:blink_headers', 'chrome_version_resources', 'policy_path_parser', ], diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc index 22b207c6..661a5ac 100644 --- a/chrome/renderer/chrome_content_renderer_client.cc +++ b/chrome/renderer/chrome_content_renderer_client.cc @@ -134,6 +134,7 @@ using blink::WebConsoleMessage; using blink::WebDataSource; using blink::WebDocument; using blink::WebFrame; +using blink::WebLocalFrame; using blink::WebPlugin; using blink::WebPluginParams; using blink::WebSecurityOrigin; @@ -466,7 +467,7 @@ const Extension* ChromeContentRendererClient::GetExtensionByOrigin( bool ChromeContentRendererClient::OverrideCreatePlugin( content::RenderFrame* render_frame, - WebFrame* frame, + WebLocalFrame* frame, const WebPluginParams& params, WebPlugin** plugin) { std::string orig_mime_type = params.mimeType.utf8(); @@ -532,7 +533,7 @@ void ChromeContentRendererClient::DeferMediaLoad( WebPlugin* ChromeContentRendererClient::CreatePlugin( content::RenderFrame* render_frame, - WebFrame* frame, + WebLocalFrame* frame, const WebPluginParams& original_params, const ChromeViewHostMsg_GetPluginInfo_Output& output) { const ChromeViewHostMsg_GetPluginInfo_Status& status = output.status; diff --git a/chrome/renderer/chrome_content_renderer_client.h b/chrome/renderer/chrome_content_renderer_client.h index f2e8ecb..7b7e264 100644 --- a/chrome/renderer/chrome_content_renderer_client.h +++ b/chrome/renderer/chrome_content_renderer_client.h @@ -14,6 +14,7 @@ #include "base/strings/string16.h" #include "content/public/renderer/content_renderer_client.h" #include "ipc/ipc_channel_proxy.h" +#include "third_party/WebKit/public/web/WebLocalFrame.h" class ChromeRenderProcessObserver; class PrescientNetworkingDispatcher; @@ -71,7 +72,7 @@ class ChromeContentRendererClient : public content::ContentRendererClient { virtual std::string GetDefaultEncoding() OVERRIDE; virtual bool OverrideCreatePlugin( content::RenderFrame* render_frame, - blink::WebFrame* frame, + blink::WebLocalFrame* frame, const blink::WebPluginParams& params, blink::WebPlugin** plugin) OVERRIDE; virtual blink::WebPlugin* CreatePluginReplacement( @@ -142,7 +143,7 @@ class ChromeContentRendererClient : public content::ContentRendererClient { static blink::WebPlugin* CreatePlugin( content::RenderFrame* render_frame, - blink::WebFrame* frame, + blink::WebLocalFrame* frame, const blink::WebPluginParams& params, const ChromeViewHostMsg_GetPluginInfo_Output& output); diff --git a/chrome/renderer/plugins/chrome_plugin_placeholder.cc b/chrome/renderer/plugins/chrome_plugin_placeholder.cc index 53484f4..0d606aa 100644 --- a/chrome/renderer/plugins/chrome_plugin_placeholder.cc +++ b/chrome/renderer/plugins/chrome_plugin_placeholder.cc @@ -20,9 +20,9 @@ #include "grit/renderer_resources.h" #include "grit/webkit_strings.h" #include "third_party/WebKit/public/web/WebDocument.h" -#include "third_party/WebKit/public/web/WebFrame.h" #include "third_party/WebKit/public/web/WebInputEvent.h" #include "third_party/WebKit/public/web/WebKit.h" +#include "third_party/WebKit/public/web/WebLocalFrame.h" #include "third_party/WebKit/public/web/WebScriptSource.h" #include "ui/base/l10n/l10n_util.h" #include "ui/base/resource/resource_bundle.h" @@ -32,6 +32,7 @@ using base::UserMetricsAction; using blink::WebDocument; using blink::WebElement; using blink::WebFrame; +using blink::WebLocalFrame; using blink::WebMouseEvent; using blink::WebNode; using blink::WebPlugin; @@ -49,7 +50,7 @@ const char ChromePluginPlaceholder::kPluginPlaceholderDataURL[] = ChromePluginPlaceholder::ChromePluginPlaceholder( content::RenderFrame* render_frame, - blink::WebFrame* frame, + blink::WebLocalFrame* frame, const blink::WebPluginParams& params, const std::string& html_data, const base::string16& title) @@ -87,7 +88,7 @@ ChromePluginPlaceholder::~ChromePluginPlaceholder() { // static ChromePluginPlaceholder* ChromePluginPlaceholder::CreateMissingPlugin( content::RenderFrame* render_frame, - WebFrame* frame, + WebLocalFrame* frame, const WebPluginParams& params) { const base::StringPiece template_html( ResourceBundle::GetSharedInstance().GetRawDataResource( @@ -142,7 +143,7 @@ ChromePluginPlaceholder* ChromePluginPlaceholder::CreateErrorPlugin( // static ChromePluginPlaceholder* ChromePluginPlaceholder::CreateBlockedPlugin( content::RenderFrame* render_frame, - WebFrame* frame, + WebLocalFrame* frame, const WebPluginParams& params, const content::WebPluginInfo& plugin, const std::string& identifier, diff --git a/chrome/renderer/plugins/chrome_plugin_placeholder.h b/chrome/renderer/plugins/chrome_plugin_placeholder.h index d7d1d81..92a841c 100644 --- a/chrome/renderer/plugins/chrome_plugin_placeholder.h +++ b/chrome/renderer/plugins/chrome_plugin_placeholder.h @@ -17,7 +17,7 @@ class ChromePluginPlaceholder : public plugins::PluginPlaceholder, static ChromePluginPlaceholder* CreateBlockedPlugin( content::RenderFrame* render_frame, - blink::WebFrame* frame, + blink::WebLocalFrame* frame, const blink::WebPluginParams& params, const content::WebPluginInfo& info, const std::string& identifier, @@ -28,7 +28,7 @@ class ChromePluginPlaceholder : public plugins::PluginPlaceholder, // Creates a new WebViewPlugin with a MissingPlugin as a delegate. static ChromePluginPlaceholder* CreateMissingPlugin( content::RenderFrame* render_frame, - blink::WebFrame* frame, + blink::WebLocalFrame* frame, const blink::WebPluginParams& params); static ChromePluginPlaceholder* CreateErrorPlugin( @@ -43,7 +43,7 @@ class ChromePluginPlaceholder : public plugins::PluginPlaceholder, private: ChromePluginPlaceholder(content::RenderFrame* render_frame, - blink::WebFrame* frame, + blink::WebLocalFrame* frame, const blink::WebPluginParams& params, const std::string& html_data, const base::string16& title); diff --git a/components/plugins/renderer/mobile_youtube_plugin.cc b/components/plugins/renderer/mobile_youtube_plugin.cc index 0fc3d4a7..caeb5b3 100644 --- a/components/plugins/renderer/mobile_youtube_plugin.cc +++ b/components/plugins/renderer/mobile_youtube_plugin.cc @@ -74,7 +74,7 @@ bool IsValidYouTubeVideo(const std::string& path) { namespace plugins { MobileYouTubePlugin::MobileYouTubePlugin(content::RenderFrame* render_frame, - blink::WebFrame* frame, + blink::WebLocalFrame* frame, const blink::WebPluginParams& params, base::StringPiece& template_html, GURL placeholderDataUrl) diff --git a/components/plugins/renderer/mobile_youtube_plugin.h b/components/plugins/renderer/mobile_youtube_plugin.h index a7654da..288daa1 100644 --- a/components/plugins/renderer/mobile_youtube_plugin.h +++ b/components/plugins/renderer/mobile_youtube_plugin.h @@ -17,7 +17,7 @@ namespace plugins { class MobileYouTubePlugin : public PluginPlaceholder { public: MobileYouTubePlugin(content::RenderFrame* render_frame, - blink::WebFrame* frame, + blink::WebLocalFrame* frame, const blink::WebPluginParams& params, base::StringPiece& template_html, GURL placeholderDataUrl); diff --git a/components/plugins/renderer/plugin_placeholder.cc b/components/plugins/renderer/plugin_placeholder.cc index 351b955..21e268b 100644 --- a/components/plugins/renderer/plugin_placeholder.cc +++ b/components/plugins/renderer/plugin_placeholder.cc @@ -18,7 +18,6 @@ #include "gin/object_template_builder.h" #include "third_party/WebKit/public/web/WebDocument.h" #include "third_party/WebKit/public/web/WebElement.h" -#include "third_party/WebKit/public/web/WebFrame.h" #include "third_party/WebKit/public/web/WebInputEvent.h" #include "third_party/WebKit/public/web/WebPluginContainer.h" #include "third_party/WebKit/public/web/WebScriptSource.h" @@ -27,7 +26,7 @@ using base::UserMetricsAction; using blink::WebElement; -using blink::WebFrame; +using blink::WebLocalFrame; using blink::WebMouseEvent; using blink::WebNode; using blink::WebPlugin; @@ -42,7 +41,7 @@ namespace plugins { gin::WrapperInfo PluginPlaceholder::kWrapperInfo = {gin::kEmbedderNativeGin}; PluginPlaceholder::PluginPlaceholder(content::RenderFrame* render_frame, - WebFrame* frame, + WebLocalFrame* frame, const WebPluginParams& params, const std::string& html_data, GURL placeholderDataUrl) @@ -245,7 +244,7 @@ void PluginPlaceholder::SetIdentifier(const std::string& identifier) { identifier_ = identifier; } -blink::WebFrame* PluginPlaceholder::GetFrame() { return frame_; } +blink::WebLocalFrame* PluginPlaceholder::GetFrame() { return frame_; } const blink::WebPluginParams& PluginPlaceholder::GetPluginParams() const { return plugin_params_; diff --git a/components/plugins/renderer/plugin_placeholder.h b/components/plugins/renderer/plugin_placeholder.h index a1cdad5..3427d40 100644 --- a/components/plugins/renderer/plugin_placeholder.h +++ b/components/plugins/renderer/plugin_placeholder.h @@ -38,7 +38,7 @@ class PluginPlaceholder : public content::RenderFrameObserver, // |render_frame| and |frame| are weak pointers. If either one is going away, // our |plugin_| will be destroyed as well and will notify us. PluginPlaceholder(content::RenderFrame* render_frame, - blink::WebFrame* frame, + blink::WebLocalFrame* frame, const blink::WebPluginParams& params, const std::string& html_data, GURL placeholderDataUrl); @@ -52,7 +52,7 @@ class PluginPlaceholder : public content::RenderFrameObserver, void SetPluginInfo(const content::WebPluginInfo& plugin_info); const content::WebPluginInfo& GetPluginInfo() const; void SetIdentifier(const std::string& identifier); - blink::WebFrame* GetFrame(); + blink::WebLocalFrame* GetFrame(); const blink::WebPluginParams& GetPluginParams() const; bool LoadingAllowed() const { return allow_loading_; } @@ -90,7 +90,7 @@ class PluginPlaceholder : public content::RenderFrameObserver, void UpdateMessage(); - blink::WebFrame* frame_; + blink::WebLocalFrame* frame_; blink::WebPluginParams plugin_params_; WebViewPlugin* plugin_; diff --git a/content/public/renderer/content_renderer_client.cc b/content/public/renderer/content_renderer_client.cc index 19324ed..7934968 100644 --- a/content/public/renderer/content_renderer_client.cc +++ b/content/public/renderer/content_renderer_client.cc @@ -20,7 +20,7 @@ std::string ContentRendererClient::GetDefaultEncoding() { bool ContentRendererClient::OverrideCreatePlugin( RenderFrame* render_frame, - blink::WebFrame* frame, + blink::WebLocalFrame* frame, const blink::WebPluginParams& params, blink::WebPlugin** plugin) { return false; diff --git a/content/public/renderer/content_renderer_client.h b/content/public/renderer/content_renderer_client.h index d4917a1..485bb10 100644 --- a/content/public/renderer/content_renderer_client.h +++ b/content/public/renderer/content_renderer_client.h @@ -13,6 +13,7 @@ #include "content/public/common/content_client.h" #include "content/public/common/page_transition_types.h" #include "ipc/ipc_message.h" +#include "third_party/WebKit/public/web/WebLocalFrame.h" #include "third_party/WebKit/public/web/WebNavigationPolicy.h" #include "third_party/WebKit/public/web/WebNavigationType.h" #include "third_party/WebKit/public/web/WebPageVisibilityState.h" @@ -29,7 +30,6 @@ class MessageLoop; namespace blink { class WebAudioDevice; class WebClipboard; -class WebFrame; class WebMIDIAccessor; class WebMIDIAccessorClient; class WebMediaStreamCenter; @@ -90,7 +90,7 @@ class CONTENT_EXPORT ContentRendererClient { // returns false, the content layer will create the plugin. virtual bool OverrideCreatePlugin( RenderFrame* render_frame, - blink::WebFrame* frame, + blink::WebLocalFrame* frame, const blink::WebPluginParams& params, blink::WebPlugin** plugin); diff --git a/content/renderer/media/android/media_info_loader_unittest.cc b/content/renderer/media/android/media_info_loader_unittest.cc index e0f18e1..ffde792 100644 --- a/content/renderer/media/android/media_info_loader_unittest.cc +++ b/content/renderer/media/android/media_info_loader_unittest.cc @@ -11,14 +11,14 @@ #include "third_party/WebKit/public/platform/WebURLError.h" #include "third_party/WebKit/public/platform/WebURLRequest.h" #include "third_party/WebKit/public/platform/WebURLResponse.h" -#include "third_party/WebKit/public/web/WebFrame.h" +#include "third_party/WebKit/public/web/WebLocalFrame.h" #include "third_party/WebKit/public/web/WebView.h" using ::testing::_; using ::testing::InSequence; using ::testing::NiceMock; -using blink::WebFrame; +using blink::WebLocalFrame; using blink::WebString; using blink::WebURLError; using blink::WebURLResponse; @@ -38,7 +38,7 @@ static const int kHttpNotFound = 404; class MediaInfoLoaderTest : public testing::Test { public: MediaInfoLoaderTest() - : view_(WebView::create(NULL)), frame_(WebFrame::create(&client_)) { + : view_(WebView::create(NULL)), frame_(WebLocalFrame::create(&client_)) { view_->setMainFrame(frame_); } @@ -112,7 +112,7 @@ class MediaInfoLoaderTest : public testing::Test { MockWebFrameClient client_; WebView* view_; - WebFrame* frame_; + WebLocalFrame* frame_; base::MessageLoop message_loop_; diff --git a/content/shell/renderer/shell_content_renderer_client.cc b/content/shell/renderer/shell_content_renderer_client.cc index 1cbc7bb..341fc23 100644 --- a/content/shell/renderer/shell_content_renderer_client.cc +++ b/content/shell/renderer/shell_content_renderer_client.cc @@ -27,7 +27,7 @@ using blink::WebAudioDevice; using blink::WebClipboard; -using blink::WebFrame; +using blink::WebLocalFrame; using blink::WebMIDIAccessor; using blink::WebMIDIAccessorClient; using blink::WebMediaStreamCenter; @@ -84,7 +84,7 @@ void ShellContentRendererClient::RenderViewCreated(RenderView* render_view) { bool ShellContentRendererClient::OverrideCreatePlugin( RenderFrame* render_frame, - WebFrame* frame, + WebLocalFrame* frame, const WebPluginParams& params, WebPlugin** plugin) { std::string mime_type = params.mimeType.utf8(); diff --git a/content/shell/renderer/shell_content_renderer_client.h b/content/shell/renderer/shell_content_renderer_client.h index 584d779..cfc56afb 100644 --- a/content/shell/renderer/shell_content_renderer_client.h +++ b/content/shell/renderer/shell_content_renderer_client.h @@ -36,7 +36,7 @@ class ShellContentRendererClient : public ContentRendererClient { virtual void RenderViewCreated(RenderView* render_view) OVERRIDE; virtual bool OverrideCreatePlugin( RenderFrame* render_frame, - blink::WebFrame* frame, + blink::WebLocalFrame* frame, const blink::WebPluginParams& params, blink::WebPlugin** plugin) OVERRIDE; virtual blink::WebMediaStreamCenter* OverrideCreateWebMediaStreamCenter( |