diff options
| author | agl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-05 01:41:22 +0000 |
|---|---|---|
| committer | agl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-05 01:41:22 +0000 |
| commit | 016e1ae50526c1795f74cbb0f660ad90d1e00413 (patch) | |
| tree | ecd0a6b467fe2c2648b65edb0ae011a550f980b9 | |
| parent | 7cfe4b0dc18b7d375bf987275a228639825e9a39 (diff) | |
| download | chromium_src-016e1ae50526c1795f74cbb0f660ad90d1e00413.zip chromium_src-016e1ae50526c1795f74cbb0f660ad90d1e00413.tar.gz chromium_src-016e1ae50526c1795f74cbb0f660ad90d1e00413.tar.bz2 | |
Wrap forward declarations in their relevant namespace
Forward declarations can't simply use "class $namespace::$class;" syntax. Instead one needs to use "namespace $namespace { class $class; }" syntax.
Review URL: http://codereview.chromium.org/8722
Patch from James Vega.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4723 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/history/thumbnail_database.h | 4 | ||||
| -rw-r--r-- | chrome/browser/views/old_frames/vista_frame.h | 5 | ||||
| -rw-r--r-- | chrome/browser/webdata/web_database.h | 4 | ||||
| -rw-r--r-- | net/http/http_network_transaction_unittest.cc | 1 |
4 files changed, 11 insertions, 3 deletions
diff --git a/chrome/browser/history/thumbnail_database.h b/chrome/browser/history/thumbnail_database.h index 3b9e1ff..60ad059 100644 --- a/chrome/browser/history/thumbnail_database.h +++ b/chrome/browser/history/thumbnail_database.h @@ -15,7 +15,9 @@ struct sqlite3; struct ThumbnailScore; -class base::Time; + namespace base { +class Time; +} namespace history { diff --git a/chrome/browser/views/old_frames/vista_frame.h b/chrome/browser/views/old_frames/vista_frame.h index ff5de5c..a165485 100644 --- a/chrome/browser/views/old_frames/vista_frame.h +++ b/chrome/browser/views/old_frames/vista_frame.h @@ -28,10 +28,13 @@ class BookmarkBarView; class Browser; class BrowserView; class TabContentsContainerView; -class views::FocusManager; class SkBitmap; class TabStrip; +namespace views { + class FocusManager; +} + //////////////////////////////////////////////////////////////////////////////// // // VistaFrame class diff --git a/chrome/browser/webdata/web_database.h b/chrome/browser/webdata/web_database.h index 386bf6c..cff9c88 100644 --- a/chrome/browser/webdata/web_database.h +++ b/chrome/browser/webdata/web_database.h @@ -14,7 +14,9 @@ #include "chrome/common/sqlite_utils.h" #include "skia/include/SkBitmap.h" -class base::Time; +namespace base { + class Time; +} struct PasswordForm; struct IE7PasswordInfo; diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc index c362e04..389fdb6 100644 --- a/net/http/http_network_transaction_unittest.cc +++ b/net/http/http_network_transaction_unittest.cc @@ -2,6 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +#include <math.h> // ceil #include "base/compiler_specific.h" #include "base/platform_test.h" #include "net/base/client_socket_factory.h" |