summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorolehougaard@google.com <olehougaard@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-10-15 13:06:37 +0000
committerolehougaard@google.com <olehougaard@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-10-15 13:06:37 +0000
commitdb5e9e77c62b4683b7a5b790aea1b996a1208727 (patch)
treea9d50ce32dbdf60c37780e2139b7de26958379c3
parent51fcbab1bcd1995b4c5c13dc371200ad557a5cfb (diff)
downloadchromium_src-db5e9e77c62b4683b7a5b790aea1b996a1208727.zip
chromium_src-db5e9e77c62b4683b7a5b790aea1b996a1208727.tar.gz
chromium_src-db5e9e77c62b4683b7a5b790aea1b996a1208727.tar.bz2
Fixing a layout test by introducing support for SVG tags altGlyph and glyph.
Review URL: http://codereview.chromium.org/7347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3393 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--webkit/build/V8Bindings/SConscript2
-rw-r--r--webkit/build/V8Bindings/V8Bindings.vcproj16
-rw-r--r--webkit/port/DerivedSources.make1
-rw-r--r--webkit/port/bindings/v8/v8_index.cpp2
-rw-r--r--webkit/port/bindings/v8/v8_index.h2
-rw-r--r--webkit/port/bindings/v8/v8_proxy.cpp2
-rw-r--r--webkit/tools/layout_tests/test_lists/tests_fixable.txt1
-rw-r--r--webkit/webkit.xcodeproj/project.pbxproj6
8 files changed, 31 insertions, 1 deletions
diff --git a/webkit/build/V8Bindings/SConscript b/webkit/build/V8Bindings/SConscript
index 3af24fd..c1d3102 100644
--- a/webkit/build/V8Bindings/SConscript
+++ b/webkit/build/V8Bindings/SConscript
@@ -182,6 +182,7 @@ inputs = [
'$DERIVED_DIR/V8StyleSheet.cpp',
'$DERIVED_DIR/V8StyleSheetList.cpp',
'$DERIVED_DIR/V8SVGAElement.cpp',
+ '$DERIVED_DIR/V8SVGAltGlyphElement.cpp',
'$DERIVED_DIR/V8SVGAngle.cpp',
'$DERIVED_DIR/V8SVGAnimateColorElement.cpp',
'$DERIVED_DIR/V8SVGAnimatedAngle.cpp',
@@ -220,6 +221,7 @@ inputs = [
'$DERIVED_DIR/V8SVGFontFaceUriElement.cpp',
'$DERIVED_DIR/V8SVGForeignObjectElement.cpp',
'$DERIVED_DIR/V8SVGGElement.cpp',
+ '$DERIVED_DIR/V8SVGGlyphElement.cpp',
'$DERIVED_DIR/V8SVGGradientElement.cpp',
'$DERIVED_DIR/V8SVGImageElement.cpp',
'$DERIVED_DIR/V8SVGLength.cpp',
diff --git a/webkit/build/V8Bindings/V8Bindings.vcproj b/webkit/build/V8Bindings/V8Bindings.vcproj
index 03836c4..cc48ed2 100644
--- a/webkit/build/V8Bindings/V8Bindings.vcproj
+++ b/webkit/build/V8Bindings/V8Bindings.vcproj
@@ -1256,6 +1256,14 @@
>
</File>
<File
+ RelativePath="$(IntDir)\DerivedSources\V8SVGAltGlyphElement.cpp"
+ >
+ </File>
+ <File
+ RelativePath="$(IntDir)\DerivedSources\V8SVGAltGlyphElement.h"
+ >
+ </File>
+ <File
RelativePath="$(IntDir)\DerivedSources\V8SVGAngle.cpp"
>
</File>
@@ -1560,6 +1568,14 @@
>
</File>
<File
+ RelativePath="$(IntDir)\DerivedSources\V8SVGGlyphElement.cpp"
+ >
+ </File>
+ <File
+ RelativePath="$(IntDir)\DerivedSources\V8SVGGlyphElement.h"
+ >
+ </File>
+ <File
RelativePath="$(IntDir)\DerivedSources\V8SVGGradientElement.cpp"
>
</File>
diff --git a/webkit/port/DerivedSources.make b/webkit/port/DerivedSources.make
index 870d73e..fd96f68 100644
--- a/webkit/port/DerivedSources.make
+++ b/webkit/port/DerivedSources.make
@@ -749,6 +749,7 @@ all : \
V8RangeException.h \
V8Rect.h \
V8SVGAElement.h \
+ V8SVGAltGlyphElement.h \
V8SVGAngle.h \
V8SVGAnimatedAngle.h \
V8SVGAnimateColorElement.h \
diff --git a/webkit/port/bindings/v8/v8_index.cpp b/webkit/port/bindings/v8/v8_index.cpp
index da59756..902ebfb 100644
--- a/webkit/port/bindings/v8/v8_index.cpp
+++ b/webkit/port/bindings/v8/v8_index.cpp
@@ -247,6 +247,7 @@
#if ENABLE(SVG)
#include "V8SVGAElement.h"
+#include "V8SVGAltGlyphElement.h"
#include "V8SVGCircleElement.h"
#include "V8SVGClipPathElement.h"
#include "V8SVGCursorElement.h"
@@ -256,6 +257,7 @@
#include "V8SVGEllipseElement.h"
#include "V8SVGException.h"
#include "V8SVGGElement.h"
+#include "V8SVGGlyphElement.h"
#include "V8SVGGradientElement.h"
#include "V8SVGImageElement.h"
#include "V8SVGLinearGradientElement.h"
diff --git a/webkit/port/bindings/v8/v8_index.h b/webkit/port/bindings/v8/v8_index.h
index 4be3f1bf9..28c59d8 100644
--- a/webkit/port/bindings/v8/v8_index.h
+++ b/webkit/port/bindings/v8/v8_index.h
@@ -169,6 +169,7 @@ typedef v8::Persistent<v8::FunctionTemplate> (*FunctionTemplateFactory)();
SVG_FOREIGN_OBJECT_ELEMENT_TYPES(V) \
SVG_USE_ELEMENT_TYPES(V) \
V(SVGAELEMENT, SVGAElement) \
+ V(SVGALTGLYPHELEMENT, SVGAltGlyphElement) \
V(SVGCIRCLEELEMENT, SVGCircleElement) \
V(SVGCLIPPATHELEMENT, SVGClipPathElement) \
V(SVGCURSORELEMENT, SVGCursorElement) \
@@ -176,6 +177,7 @@ typedef v8::Persistent<v8::FunctionTemplate> (*FunctionTemplateFactory)();
V(SVGDESCELEMENT, SVGDescElement) \
V(SVGELLIPSEELEMENT, SVGEllipseElement) \
V(SVGGELEMENT, SVGGElement) \
+ V(SVGGLYPHELEMENT, SVGGlyphElement) \
V(SVGGRADIENTELEMENT, SVGGradientElement) \
V(SVGIMAGEELEMENT, SVGImageElement) \
V(SVGLINEARGRADIENTELEMENT, SVGLinearGradientElement) \
diff --git a/webkit/port/bindings/v8/v8_proxy.cpp b/webkit/port/bindings/v8/v8_proxy.cpp
index 2d4109a..df82d3b 100644
--- a/webkit/port/bindings/v8/v8_proxy.cpp
+++ b/webkit/port/bindings/v8/v8_proxy.cpp
@@ -2252,6 +2252,7 @@ FOR_EACH_TAG(ADD_TO_HASH_MAP)
FOR_EACH_FOREIGN_OBJECT_TAG(macro) \
FOR_EACH_USE_TAG(macro) \
macro(a, A) \
+ macro(altGlyph, ALTGLYPH) \
macro(circle, CIRCLE) \
macro(clipPath, CLIPPATH) \
macro(cursor, CURSOR) \
@@ -2259,6 +2260,7 @@ FOR_EACH_TAG(ADD_TO_HASH_MAP)
macro(desc, DESC) \
macro(ellipse, ELLIPSE) \
macro(g, G) \
+ macro(glyph, GLYPH) \
macro(image, IMAGE) \
macro(linearGradient, LINEARGRADIENT) \
macro(line, LINE) \
diff --git a/webkit/tools/layout_tests/test_lists/tests_fixable.txt b/webkit/tools/layout_tests/test_lists/tests_fixable.txt
index b7ba575..2f3906e 100644
--- a/webkit/tools/layout_tests/test_lists/tests_fixable.txt
+++ b/webkit/tools/layout_tests/test_lists/tests_fixable.txt
@@ -945,7 +945,6 @@ V8 | KJS # LayoutTests/plugins/return-error-from-new-stream-doesnt-invoke-destro
V8 | KJS # LayoutTests/printing = FAIL
V8 | KJS # LayoutTests/security/autocomplete-cleared-on-back.html = FAIL | TIMEOUT
V8 | KJS # LayoutTests/security/set-form-autocomplete-attribute.html = FAIL
-V8 | KJS # LayoutTests/svg/dom/altGlyph-dom.xhtml = FAIL
// Post-MERGE failures: these will all need to be fixed one day
V8 | KJS # LayoutTests/editing/execCommand/outdent-selection.gchtml = FAIL
diff --git a/webkit/webkit.xcodeproj/project.pbxproj b/webkit/webkit.xcodeproj/project.pbxproj
index d8bd10b..5b2c37a 100644
--- a/webkit/webkit.xcodeproj/project.pbxproj
+++ b/webkit/webkit.xcodeproj/project.pbxproj
@@ -128,6 +128,7 @@
4DB7FA470E9BF0CA00C66CE0 /* StyleGeneratedImage.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4DB7FA430E9BF0CA00C66CE0 /* StyleGeneratedImage.cpp */; };
4DB7FA670E9BF24600C66CE0 /* NetworkStateNotifierMac.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4DB7F9EE0E9BECEC00C66CE0 /* NetworkStateNotifierMac.cpp */; };
4DB7FE770E9BF6D800C66CE0 /* WebSystemInterface.m in Sources */ = {isa = PBXBuildFile; fileRef = 4DB7FE6A0E9BF69A00C66CE0 /* WebSystemInterface.m */; };
+ 4DBB28F70EA611B200A0A427 /* V8SVGAltGlyphElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4DBB28F50EA611B200A0A427 /* V8SVGAltGlyphElement.cpp */; };
4DFF09850E9C1261003CF5B4 /* AccessibilityObjectWin.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4DFF09840E9C1261003CF5B4 /* AccessibilityObjectWin.cpp */; };
7B0091350DAFEFBE00F72082 /* CSSGrammar.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7B00912B0DAFEFBE00F72082 /* CSSGrammar.cpp */; };
7B0091370DAFEFBE00F72082 /* HTMLNames.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7B00912D0DAFEFBE00F72082 /* HTMLNames.cpp */; };
@@ -1545,6 +1546,8 @@
4DB7FE690E9BF69A00C66CE0 /* WebSystemInterface.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebSystemInterface.h; sourceTree = "<group>"; };
4DB7FE6A0E9BF69A00C66CE0 /* WebSystemInterface.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = WebSystemInterface.m; sourceTree = "<group>"; };
4DB7FE6F0E9BF6AC00C66CE0 /* libwebcoresysteminterface.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = libwebcoresysteminterface.a; sourceTree = BUILT_PRODUCTS_DIR; };
+ 4DBB28F50EA611B200A0A427 /* V8SVGAltGlyphElement.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = V8SVGAltGlyphElement.cpp; sourceTree = "<group>"; };
+ 4DBB28F60EA611B200A0A427 /* V8SVGAltGlyphElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = V8SVGAltGlyphElement.h; sourceTree = "<group>"; };
4DFF09840E9C1261003CF5B4 /* AccessibilityObjectWin.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = AccessibilityObjectWin.cpp; sourceTree = "<group>"; };
7B00912B0DAFEFBE00F72082 /* CSSGrammar.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CSSGrammar.cpp; sourceTree = "<group>"; };
7B00912C0DAFEFBE00F72082 /* CSSGrammar.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CSSGrammar.h; sourceTree = "<group>"; };
@@ -6564,6 +6567,8 @@
7B0092520DAFEFE400F72082 /* V8StyleSheetList.h */,
7B0092530DAFEFE400F72082 /* V8SVGAElement.cpp */,
7B0092540DAFEFE400F72082 /* V8SVGAElement.h */,
+ 4DBB28F50EA611B200A0A427 /* V8SVGAltGlyphElement.cpp */,
+ 4DBB28F60EA611B200A0A427 /* V8SVGAltGlyphElement.h */,
7B0092550DAFEFE400F72082 /* V8SVGAngle.cpp */,
7B0092560DAFEFE400F72082 /* V8SVGAngle.h */,
4DB7EF8A0E9B9F6300C66CE0 /* V8SVGAnimateColorElement.cpp */,
@@ -7631,6 +7636,7 @@
7B0094910DAFEFE600F72082 /* V8StyleSheet.cpp in Sources */,
7B0094930DAFEFE600F72082 /* V8StyleSheetList.cpp in Sources */,
7B0094950DAFEFE600F72082 /* V8SVGAElement.cpp in Sources */,
+ 4DBB28F70EA611B200A0A427 /* V8SVGAltGlyphElement.cpp in Sources */,
7B0094970DAFEFE600F72082 /* V8SVGAngle.cpp in Sources */,
4DB7EF970E9B9F6300C66CE0 /* V8SVGAnimateColorElement.cpp in Sources */,
7B00949B0DAFEFE600F72082 /* V8SVGAnimatedAngle.cpp in Sources */,