diff options
| author | Garrett Casto <gcasto@chromium.org> | 2014-09-30 19:25:53 -0700 |
|---|---|---|
| committer | Garrett Casto <gcasto@chromium.org> | 2014-10-01 02:26:58 +0000 |
| commit | 44c5e4ebc358b6e804ae7af97fd240ca5682743f (patch) | |
| tree | 433dba51db818af1e451966b4896a3d3bc40e2af | |
| parent | 83988d706b3c665d7f442c825be03ab2a0aaac69 (diff) | |
| download | chromium_src-44c5e4ebc358b6e804ae7af97fd240ca5682743f.zip chromium_src-44c5e4ebc358b6e804ae7af97fd240ca5682743f.tar.gz chromium_src-44c5e4ebc358b6e804ae7af97fd240ca5682743f.tar.bz2 | |
[Password Generation] Fix a bug where we always upload ACCOUNT_CREATION_PASSWORD
Update test to catch the problem. Previous test mocked out
bad behavior.
BUG=419228
R=isherman@chromium.org
Review URL: https://codereview.chromium.org/614313002
Cr-Commit-Position: refs/heads/master@{#297580}
| -rw-r--r-- | components/password_manager/core/browser/password_form_manager.cc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc index 59eff7c..5bd25b6 100644 --- a/components/password_manager/core/browser/password_form_manager.cc +++ b/components/password_manager/core/browser/password_form_manager.cc @@ -730,8 +730,7 @@ void PasswordFormManager::UploadPasswordForm( // Note that this doesn't guarantee that the upload succeeded, only that // |form_data| is considered uploadable. bool success = - autofill_manager->UploadPasswordForm( - form_data, autofill::ACCOUNT_CREATION_PASSWORD); + autofill_manager->UploadPasswordForm(form_data, password_type); UMA_HISTOGRAM_BOOLEAN("PasswordGeneration.UploadStarted", success); } |