diff options
| author | mseaborn@chromium.org <mseaborn@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-16 23:49:42 +0000 |
|---|---|---|
| committer | mseaborn@chromium.org <mseaborn@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-16 23:49:42 +0000 |
| commit | e1d44c6e9928357c27afb472a3f9e36075ff9337 (patch) | |
| tree | 0ae0917f858a0e671f200ac0bfc024a38fb9b0b0 | |
| parent | 74b123ad24bc3f9c6b68dd064a001123cfbabcd9 (diff) | |
| download | chromium_src-e1d44c6e9928357c27afb472a3f9e36075ff9337.zip chromium_src-e1d44c6e9928357c27afb472a3f9e36075ff9337.tar.gz chromium_src-e1d44c6e9928357c27afb472a3f9e36075ff9337.tar.bz2 | |
Breakpad: Enable more logging in crash_service to debug flaky failures on Windows
Two things are needed to get crash_service's VLOG(1) messages sent to
stderr:
* Pass --v=1
* Enable "SYSTEM_DEBUG_LOG" in InitLogging()
Without these steps, only higher verbosity messages get sent to
stderr.
Note that crash_service's stderr works if stderr is a pipe but not if
it's a Windows console. On a Buildbot slave, though, stderr is a pipe.
BUG=169394
TEST=run_breakpad_browser_process_crash_test in nacl_integration
Review URL: https://codereview.chromium.org/11881043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177271 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/tools/crash_service/main.cc | 6 | ||||
| -rwxr-xr-x | ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py | 1 |
2 files changed, 5 insertions, 2 deletions
diff --git a/chrome/tools/crash_service/main.cc b/chrome/tools/crash_service/main.cc index ae802ab..8efa31a 100644 --- a/chrome/tools/crash_service/main.cc +++ b/chrome/tools/crash_service/main.cc @@ -44,13 +44,15 @@ int __stdcall wWinMain(HINSTANCE instance, HINSTANCE, wchar_t* cmd_line, GetCrashServiceDirectory(&operating_dir); FilePath log_file = operating_dir.Append(kStandardLogFile); - // Logging to a file with pid, tid and timestamp. + // Logging to stderr (to help with debugging failures on the + // buildbots) and to a file. logging::InitLogging( log_file.value().c_str(), - logging::LOG_ONLY_TO_FILE, + logging::LOG_TO_BOTH_FILE_AND_SYSTEM_DEBUG_LOG, logging::LOCK_LOG_FILE, logging::APPEND_TO_OLD_LOG_FILE, logging::DISABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS); + // Logging with pid, tid and timestamp. logging::SetLogItems(true, true, true, false); VLOG(1) << "session start. cmdline is [" << cmd_line << "]"; diff --git a/ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py b/ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py index 5e7484f4..cc3d14b 100755 --- a/ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py +++ b/ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py @@ -42,6 +42,7 @@ def StartCrashService(browser_path, dumps_dir, windows_pipe_name, # Find crash_service.exe relative to chrome.exe. This is a bit icky. browser_dir = os.path.dirname(browser_path) proc = subprocess.Popen([os.path.join(browser_dir, crash_service_exe), + '--v=1', # Verbose output for debugging failures '--dumps-dir=%s' % dumps_dir, '--pipe-name=%s' % windows_pipe_name]) |