summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlexei Svitkine <asvitkine@chromium.org>2014-11-13 16:12:19 -0500
committerAlexei Svitkine <asvitkine@chromium.org>2014-11-13 21:13:39 +0000
commit082a3449b89e079f55c5755cb240e62ce5b5f2ad (patch)
treeab11c4d0501cfafc218bab3f5b70e28b5df14e36
parent01ed1471bc5f648604078a503e89edb2ec83dd42 (diff)
downloadchromium_src-082a3449b89e079f55c5755cb240e62ce5b5f2ad.zip
chromium_src-082a3449b89e079f55c5755cb240e62ce5b5f2ad.tar.gz
chromium_src-082a3449b89e079f55c5755cb240e62ce5b5f2ad.tar.bz2
Fix reporting_level_ initialization
BUG=431833 TBR=holte@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/715633003 Cr-Commit-Position: refs/heads/master@{#303518} (cherry picked from commit b35d1e1ad264ee432442cfe7d988880a44ca07d7) Review URL: https://codereview.chromium.org/727533003 Cr-Commit-Position: refs/branch-heads/2214@{#30} Cr-Branched-From: 03655fd3f6d72165dc3c9bd2c89807305316fe6c-refs/heads/master@{#303346}
-rw-r--r--components/rappor/rappor_service.cc11
1 files changed, 8 insertions, 3 deletions
diff --git a/components/rappor/rappor_service.cc b/components/rappor/rappor_service.cc
index de814c4..e6879d2 100644
--- a/components/rappor/rappor_service.cc
+++ b/components/rappor/rappor_service.cc
@@ -108,7 +108,7 @@ void RapporService::Start(net::URLRequestContextGetter* request_context,
return;
DVLOG(1) << "RapporService started. Reporting to " << server_url.spec();
DCHECK(!uploader_);
- Initialize(LoadCohort(), LoadSecret(), reporting_level_);
+ Initialize(LoadCohort(), LoadSecret(), reporting_level);
uploader_.reset(new LogUploader(server_url, kMimeType, request_context));
log_rotation_timer_.Start(
FROM_HERE,
@@ -192,8 +192,10 @@ std::string RapporService::LoadSecret() {
}
bool RapporService::ExportMetrics(RapporReports* reports) {
- if (metrics_map_.empty())
+ if (metrics_map_.empty()) {
+ DVLOG(2) << "metrics_map_ is empty.";
return false;
+ }
DCHECK_GE(cohort_, 0);
reports->set_cohort(cohort_);
@@ -236,8 +238,11 @@ void RapporService::RecordSampleInternal(const std::string& metric_name,
DCHECK(IsInitialized());
// Skip this metric if it's reporting level is less than the enabled
// reporting level.
- if (reporting_level_ < parameters.reporting_level)
+ if (reporting_level_ < parameters.reporting_level) {
+ DVLOG(2) << "Metric not logged due to reporting_level "
+ << reporting_level_ << " < " << parameters.reporting_level;
return;
+ }
RapporMetric* metric = LookUpMetric(metric_name, parameters);
metric->AddSample(sample);
}