summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorddorwin@chromium.org <ddorwin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-05-28 17:49:00 +0000
committerddorwin@chromium.org <ddorwin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-05-28 17:49:00 +0000
commit0f253da52ef4fdb2dde29f3cf5f8ca660e5067ea (patch)
tree7b68f0fd3fdcfb672c0311bf455e7f1b3f34f17f
parentea79de87234c1865609b94cc06c0474825166f10 (diff)
downloadchromium_src-0f253da52ef4fdb2dde29f3cf5f8ca660e5067ea.zip
chromium_src-0f253da52ef4fdb2dde29f3cf5f8ca660e5067ea.tar.gz
chromium_src-0f253da52ef4fdb2dde29f3cf5f8ca660e5067ea.tar.bz2
Fix a type mismatch on Windows caused by r201738.
The problem was at encrypted_media_browsertest.cc line 167, which is a call to RegisterPepperCdm(), but the right fix is to use ASCII for the constants. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/15658009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202598 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/component_updater/widevine_cdm_component_installer.cc8
-rw-r--r--chrome/common/chrome_paths.cc2
-rw-r--r--third_party/widevine/cdm/widevine_cdm_common.h16
3 files changed, 13 insertions, 13 deletions
diff --git a/chrome/browser/component_updater/widevine_cdm_component_installer.cc b/chrome/browser/component_updater/widevine_cdm_component_installer.cc
index f43c28a..000ff86 100644
--- a/chrome/browser/component_updater/widevine_cdm_component_installer.cc
+++ b/chrome/browser/component_updater/widevine_cdm_component_installer.cc
@@ -217,7 +217,7 @@ bool WidevineCdmComponentInstaller::Install(
if (current_version_.CompareTo(version) > 0)
return false;
- if (!file_util::PathExists(unpack_path.Append(kWidevineCdmFileName)))
+ if (!file_util::PathExists(unpack_path.AppendASCII(kWidevineCdmFileName)))
return false;
base::FilePath adapter_source_path;
@@ -234,7 +234,7 @@ bool WidevineCdmComponentInstaller::Install(
return false;
base::FilePath adapter_install_path =
- install_path.Append(kWidevineCdmAdapterFileName);
+ install_path.AppendASCII(kWidevineCdmAdapterFileName);
if (!file_util::CopyFile(adapter_source_path, adapter_install_path))
return false;
@@ -270,8 +270,8 @@ void StartWidevineCdmUpdateRegistration(ComponentUpdateService* cus) {
base::Version version(kNullVersion);
std::vector<base::FilePath> older_dirs;
if (GetWidevineCdmDirectory(&path, &version, &older_dirs)) {
- if (file_util::PathExists(path.Append(kWidevineCdmAdapterFileName)) &&
- file_util::PathExists(path.Append(kWidevineCdmFileName))) {
+ if (file_util::PathExists(path.AppendASCII(kWidevineCdmAdapterFileName)) &&
+ file_util::PathExists(path.AppendASCII(kWidevineCdmFileName))) {
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::Bind(&RegisterWidevineCdmWithChrome, path, version));
diff --git a/chrome/common/chrome_paths.cc b/chrome/common/chrome_paths.cc
index 641baf2..a88ca9f 100644
--- a/chrome/common/chrome_paths.cc
+++ b/chrome/common/chrome_paths.cc
@@ -368,7 +368,7 @@ bool PathProvider(int key, base::FilePath* result) {
case chrome::FILE_WIDEVINE_CDM_ADAPTER:
if (!GetInternalPluginsDirectory(&cur))
return false;
- cur = cur.Append(kWidevineCdmAdapterFileName);
+ cur = cur.AppendASCII(kWidevineCdmAdapterFileName);
break;
#endif // defined(WIDEVINE_CDM_AVAILABLE) && defined(ENABLE_PEPPER_CDMS)
case chrome::FILE_RESOURCES_PACK:
diff --git a/third_party/widevine/cdm/widevine_cdm_common.h b/third_party/widevine/cdm/widevine_cdm_common.h
index 144aacb..ec68901 100644
--- a/third_party/widevine/cdm/widevine_cdm_common.h
+++ b/third_party/widevine/cdm/widevine_cdm_common.h
@@ -26,24 +26,24 @@ const char kWidevineCdmPluginMimeTypeDescription[] =
#endif
// File name of the CDM on different platforms.
-const base::FilePath::CharType kWidevineCdmFileName[] =
+const char kWidevineCdmFileName[] =
#if defined(OS_MACOSX)
- FILE_PATH_LITERAL("widevinecdm.dylib");
+ "widevinecdm.dylib";
#elif defined(OS_WIN)
- FILE_PATH_LITERAL("widevinecdm.dll");
+ "widevinecdm.dll";
#else // OS_LINUX, etc.
- FILE_PATH_LITERAL("libwidevinecdm.so");
+ "libwidevinecdm.so";
#endif
#if defined(ENABLE_PEPPER_CDMS)
// File name of the adapter on different platforms.
-const base::FilePath::CharType kWidevineCdmAdapterFileName[] =
+const char kWidevineCdmAdapterFileName[] =
#if defined(OS_MACOSX)
- FILE_PATH_LITERAL("widevinecdmadapter.plugin");
+ "widevinecdmadapter.plugin";
#elif defined(OS_WIN)
- FILE_PATH_LITERAL("widevinecdmadapter.dll");
+ "widevinecdmadapter.dll";
#else // OS_LINUX, etc.
- FILE_PATH_LITERAL("libwidevinecdmadapter.so");
+ "libwidevinecdmadapter.so";
#endif
#endif // defined(ENABLE_PEPPER_CDMS)