[Autofill] Investigate Autofill Flakiness

Add additional logging to try and track down source of flakiness.

BUG=150084

Review URL: https://chromiumcodereview.appspot.com/19818008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213832 0039d316-1c4b-4281-b951-d872f2087c98

3 files changed, 22 insertions, 9 deletions

diff --git a/chrome/browser/autofill/autofill_interactive_uitest.cc b/chrome/browser/autofill/autofill_interactive_uitest.cc
index d241f3f..325d075 100644
--- a/chrome/browser/autofill/autofill_interactive_uitest.cc
+++ b/chrome/browser/autofill/autofill_interactive_uitest.cc
@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/autofill/personal_data_manager_factory.h"
@@ -75,14 +76,17 @@ class AutofillManagerTestDelegateImpl
   AutofillManagerTestDelegateImpl() {}
 
   virtual void DidPreviewFormData() OVERRIDE {
+    LOG(INFO) << "DidPreviewFormData";
     loop_runner_->Quit();
   }
 
   virtual void DidFillFormData() OVERRIDE {
+    LOG(INFO) << "DidFillFormData";
     loop_runner_->Quit();
   }
 
   virtual void DidShowSuggestions() OVERRIDE {
+    LOG(INFO) << "DidShowSuggestions";
     loop_runner_->Quit();
   }
 
@@ -303,14 +307,6 @@ class AutofillInteractiveTest : public InProcessBrowserTest {
   }
 
   void SendKeyToPopupAndWait(ui::KeyboardCode key) {
-    // TODO(isherman): Remove this condition once the WebKit popup UI code is
-    // removed.
-    if (!external_delegate()) {
-      // When testing the WebKit-based UI, route all keys to the page.
-      SendKeyToPageAndWait(key);
-      return;
-    }
-
     // When testing the native UI, route popup-targeted key presses via the
     // external delegate.
     content::NativeWebKeyboardEvent event;
@@ -332,7 +328,8 @@ class AutofillInteractiveTest : public InProcessBrowserTest {
   AutofillManagerTestDelegateImpl test_delegate_;
 };
 
-IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, DISABLED_AutofillSelectViaTab) {
+// Temporarily renabled to help track down flakiness. crbug.com/150084
+IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, AutofillSelectViaTab) {
   CreateTestProfile();
 
   // Load the test page.
@@ -342,6 +339,10 @@ IN_PROC_BROWSER_TEST_F(AutofillInteractiveTest, DISABLED_AutofillSelectViaTab) {
   // Focus a fillable field.
   FocusFirstNameField();
 
+  // Enable all logging to help track down the flakiness.
+  // TODO(csharp): Remove once this flakiness is fixed.
+  logging::SetMinLogLevel(0);
+
   // Press the down arrow to initiate Autofill and wait for the popup to be
   // shown.
   SendKeyToPageAndWait(ui::VKEY_DOWN);
diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc
index f61902f..ff534bd 100644
--- a/components/autofill/content/renderer/autofill_agent.cc
+++ b/components/autofill/content/renderer/autofill_agent.cc
@@ -627,6 +627,9 @@ void AutofillAgent::ShowSuggestions(const WebInputElement& element,
                                     bool autofill_on_empty_values,
                                     bool requires_caret_at_end,
                                     bool display_warning_if_disabled) {
+  // TODO(csharp): Remove once Autofill test flakiness is fixed.
+  LOG(INFO) << "AutofillAgent::ShowSuggestions";
+
   if (!element.isEnabled() || element.isReadOnly() || !element.isTextField() ||
       element.isPasswordField() || !element.suggestedValue().isEmpty())
     return;
@@ -663,6 +666,9 @@ void AutofillAgent::ShowSuggestions(const WebInputElement& element,
 
 void AutofillAgent::QueryAutofillSuggestions(const WebInputElement& element,
                                              bool display_warning_if_disabled) {
+  // TODO(csharp): Remove once Autofill test flakiness is fixed.
+  LOG(INFO) << "AutofillAgent::QueryAutofillSuggestions";
+
   if (!element.document().frame())
     return;
 
diff --git a/components/autofill/core/browser/autofill_external_delegate.cc b/components/autofill/core/browser/autofill_external_delegate.cc
index 95119bf..1cf7c06 100644
--- a/components/autofill/core/browser/autofill_external_delegate.cc
+++ b/components/autofill/core/browser/autofill_external_delegate.cc
@@ -48,6 +48,9 @@ void AutofillExternalDelegate::OnQuery(int query_id,
                                        const FormFieldData& field,
                                        const gfx::RectF& element_bounds,
                                        bool display_warning_if_disabled) {
+  // TODO(csharp): Remove once Autofill test flakiness is fixed.
+  LOG(INFO) << "AutofillExternalDelegate::OnQuery";
+
   autofill_query_form_ = form;
   autofill_query_field_ = field;
   display_warning_if_disabled_ = display_warning_if_disabled;
@@ -61,6 +64,9 @@ void AutofillExternalDelegate::OnSuggestionsReturned(
     const std::vector<base::string16>& autofill_labels,
     const std::vector<base::string16>& autofill_icons,
     const std::vector<int>& autofill_unique_ids) {
+  // TODO(csharp): Remove once Autofill test flakiness is fixed.
+  LOG(INFO) << "AutofillExternalDelegate::OnSuggestionsReturned";
+
   if (query_id != autofill_query_id_)
     return;