diff options
author | jochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-24 17:35:41 +0000 |
---|---|---|
committer | jochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-24 17:35:41 +0000 |
commit | 057d14c00642bcd2bf108bd2ccfff7357eff99e5 (patch) | |
tree | 47cf9e4c58fac89d9cd6e620ad3fee40cfe22d5b | |
parent | 54c8d287d92857d997bf399991cb27dd6cd2e632 (diff) | |
download | chromium_src-057d14c00642bcd2bf108bd2ccfff7357eff99e5.zip chromium_src-057d14c00642bcd2bf108bd2ccfff7357eff99e5.tar.gz chromium_src-057d14c00642bcd2bf108bd2ccfff7357eff99e5.tar.bz2 |
Only generate symbols for binaries that were updated since the last time
To wipe all symbols, you can use the --clear option
BUG=329827
R=dpranke@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/134193003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246917 0039d316-1c4b-4281-b951-d872f2087c98
-rwxr-xr-x | components/breakpad/tools/generate_breakpad_symbols.py | 22 |
1 files changed, 20 insertions, 2 deletions
diff --git a/components/breakpad/tools/generate_breakpad_symbols.py b/components/breakpad/tools/generate_breakpad_symbols.py index 3a3db67..4007d1d 100755 --- a/components/breakpad/tools/generate_breakpad_symbols.py +++ b/components/breakpad/tools/generate_breakpad_symbols.py @@ -147,9 +147,27 @@ def GenerateSymbols(options, binaries): while True: binary = queue.get() + should_dump_syms = True + reason = "no reason" + + output_path = os.path.join( + options.symbols_dir, os.path.basename(binary)) + if os.path.isdir(output_path): + dir_stat = os.stat(output_path) + bin_stat = os.stat(binary) + if os.path.getmtime(binary) < os.path.getmtime(output_path): + should_dump_syms = False + reason = "symbols are more current than binary" + + if not should_dump_syms: + with print_lock: + print "Skipping %s (%s)" % (binary, reason) + queue.task_done() + continue + if options.verbose: - with print_lock: - print "Generating symbols for %s" % binary + with print_lock: + print "Generating symbols for %s" % binary syms = GetCommandOutput([GetDumpSymsBinary(options.build_dir), '-r', binary]) |