diff options
| author | jvoung@google.com <jvoung@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-29 23:58:38 +0000 |
|---|---|---|
| committer | jvoung@google.com <jvoung@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-29 23:58:38 +0000 |
| commit | 8374e72ee4b470687b14ab6924783244ace7b927 (patch) | |
| tree | cb5411df5b26668e553ddc5f70dc97ce72e66a34 | |
| parent | dbf64363e3a27981313a15366ec7fc96d53edd11 (diff) | |
| download | chromium_src-8374e72ee4b470687b14ab6924783244ace7b927.zip chromium_src-8374e72ee4b470687b14ab6924783244ace7b927.tar.gz chromium_src-8374e72ee4b470687b14ab6924783244ace7b927.tar.bz2 | |
Flip condition for using specific temp_dir for PNaCl temp files.
The condition on the location for tempfile creation was reversed, so the tests passed (but leaked temp files) and the browser failed to create temp files entirely.
BUG=264311
R=dschuff@chromium.org
Review URL: https://codereview.chromium.org/21103005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214265 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/nacl_host/pnacl_host.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/chrome/browser/nacl_host/pnacl_host.cc b/chrome/browser/nacl_host/pnacl_host.cc index f3b7de2..6eb3ea0 100644 --- a/chrome/browser/nacl_host/pnacl_host.cc +++ b/chrome/browser/nacl_host/pnacl_host.cc @@ -101,8 +101,9 @@ IPC::PlatformFileForTransit PnaclHost::DoCreateTemporaryFile( base::FilePath file_path; bool rv = temp_dir.empty() - ? file_util::CreateTemporaryFileInDir(temp_dir, &file_path) - : file_util::CreateTemporaryFile(&file_path); + ? file_util::CreateTemporaryFile(&file_path) + : file_util::CreateTemporaryFileInDir(temp_dir, &file_path); + if (!rv) return IPC::InvalidPlatformFileForTransit(); |