diff options
| author | shrikant <shrikant@chromium.org> | 2015-03-31 18:35:55 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-01 01:36:33 +0000 |
| commit | 98322129c764d4c8f39df2a8e8ae770939ec1d9a (patch) | |
| tree | a32229ecb105cae4e78ec16745438f325765be75 | |
| parent | ce8969517c091252c32c9af5b3dcb57eb17d431f (diff) | |
| download | chromium_src-98322129c764d4c8f39df2a8e8ae770939ec1d9a.zip chromium_src-98322129c764d4c8f39df2a8e8ae770939ec1d9a.tar.gz chromium_src-98322129c764d4c8f39df2a8e8ae770939ec1d9a.tar.bz2 | |
Added metrics to track sandboxed process launch errors.
Have already added metrics to track create process errors when lowbox token is present (https://codereview.chromium.org/1024463005/), which still remains a mystery.
Now adding general sandboxed create process error so that we can establish a baseline.
BUG=468922
R=jschuh@chromium.org,cpu@chromium.org,isherman@chromium.org
Review URL: https://codereview.chromium.org/1040223002
Cr-Commit-Position: refs/heads/master@{#323165}
| -rw-r--r-- | content/common/sandbox_win.cc | 8 | ||||
| -rw-r--r-- | tools/metrics/histograms/histograms.xml | 8 |
2 files changed, 12 insertions, 4 deletions
diff --git a/content/common/sandbox_win.cc b/content/common/sandbox_win.cc index 7749d7b..0211a1c 100644 --- a/content/common/sandbox_win.cc +++ b/content/common/sandbox_win.cc @@ -741,10 +741,10 @@ base::Process StartSandboxedProcess( // cause for lowbox/createprocess errors. sandbox::PolicyBase* policy_base = static_cast<sandbox::PolicyBase*>(policy); - if (policy_base->GetLowBoxSid()) { - UMA_HISTOGRAM_SPARSE_SLOWLY("Process.Sandbox.Lowbox.Launch.Error", - last_error); - } + UMA_HISTOGRAM_SPARSE_SLOWLY(policy_base->GetLowBoxSid() ? + "Process.Sandbox.Lowbox.Launch.Error" : + "Process.Sandbox.Launch.Error", + last_error); } else DLOG(ERROR) << "Failed to launch process. Error: " << result; return base::Process(); diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml index e9ef9b8..f1f3809 100644 --- a/tools/metrics/histograms/histograms.xml +++ b/tools/metrics/histograms/histograms.xml @@ -29356,6 +29356,14 @@ Therefore, the affected-histogram name has to have at least one dot in it. </summary> </histogram> +<histogram name="Process.Sandbox.Launch.Error" units="GetLastError"> + <owner>shrikant@chromium.org</owner> + <summary> + Errors returned while launching sandboxed process on Windows. For decoding + error code please refer to http://goo.gl/fJJiAv. + </summary> +</histogram> + <histogram name="Process.Sandbox.Lowbox.Launch.Error" units="GetLastError"> <owner>shrikant@chromium.org</owner> <summary> |