diff options
author | binjin <binjin@chromium.org> | 2015-02-23 03:21:03 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-02-23 11:21:42 +0000 |
commit | 34cd1a9f17f7b4509753b0184e7ac3463ab43d13 (patch) | |
tree | 925659decabce33e7047d0402cb6969dce23f770 | |
parent | f06ba4746099cf5ad3c381e9cbdfa66c1aa26c1b (diff) | |
download | chromium_src-34cd1a9f17f7b4509753b0184e7ac3463ab43d13.zip chromium_src-34cd1a9f17f7b4509753b0184e7ac3463ab43d13.tar.gz chromium_src-34cd1a9f17f7b4509753b0184e7ac3463ab43d13.tar.bz2 |
Revert of Add AwAssets into android_webview/native/public (patchset #4 id:70009 of https://codereview.chromium.org/937863003/)
Reason for revert:
Suspected to cause 'checkdeps' failures on Linux bot:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/20990/steps/checkdeps/logs/stdio
ERROR in /mnt/data/b/build/slave/Linux_Tests/build/src/android_webview/browser/aw_dev_tools_manager_delegate.cc
Illegal include: "android_webview/native/aw_contents.h"
Because of "-android_webview" from android_webview/browser's include_rules.
Original issue's description:
> Add AwAssets into android_webview/native/public
>
> This is done so that android_webview/browser doesn't need to depend on
> android_webview/native
>
> BUG=459779
>
> Committed: https://crrev.com/a08360b39730751c5f85797bdff5b748d907c11a
> Cr-Commit-Position: refs/heads/master@{#317475}
TBR=boliu@chromium.org,sgurun@chromium.org,hush@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459779
Review URL: https://codereview.chromium.org/947113002
Cr-Commit-Position: refs/heads/master@{#317567}
-rw-r--r-- | android_webview/browser/DEPS | 2 | ||||
-rw-r--r-- | android_webview/browser/aw_browser_main_parts.cc | 2 | ||||
-rw-r--r-- | android_webview/lib/main/aw_main_delegate.cc | 2 | ||||
-rw-r--r-- | android_webview/native/android_webview_jni_registrar.cc | 2 | ||||
-rw-r--r-- | android_webview/native/aw_assets.cc (renamed from android_webview/native/public/aw_assets.cc) | 2 | ||||
-rw-r--r-- | android_webview/native/aw_assets.h (renamed from android_webview/native/public/aw_assets.h) | 6 | ||||
-rw-r--r-- | android_webview/native/aw_media_url_interceptor.cc | 2 | ||||
-rw-r--r-- | android_webview/native/webview_native.gyp | 4 |
8 files changed, 11 insertions, 11 deletions
diff --git a/android_webview/browser/DEPS b/android_webview/browser/DEPS index e633368..217bfa7 100644 --- a/android_webview/browser/DEPS +++ b/android_webview/browser/DEPS @@ -2,7 +2,7 @@ include_rules = [ "-android_webview", "+android_webview/browser", "+android_webview/common", - "+android_webview/native/public", + "+android_webview/native", "+android_webview/public/browser", "+cc", diff --git a/android_webview/browser/aw_browser_main_parts.cc b/android_webview/browser/aw_browser_main_parts.cc index db47f02..8bbdb85 100644 --- a/android_webview/browser/aw_browser_main_parts.cc +++ b/android_webview/browser/aw_browser_main_parts.cc @@ -6,7 +6,7 @@ #include "android_webview/browser/aw_browser_context.h" #include "android_webview/browser/aw_result_codes.h" -#include "android_webview/native/public/aw_assets.h" +#include "android_webview/native/aw_assets.h" #include "base/android/build_info.h" #include "base/android/locale_utils.h" #include "base/android/memory_pressure_listener_android.h" diff --git a/android_webview/lib/main/aw_main_delegate.cc b/android_webview/lib/main/aw_main_delegate.cc index b96f208..5a24c0f 100644 --- a/android_webview/lib/main/aw_main_delegate.cc +++ b/android_webview/lib/main/aw_main_delegate.cc @@ -9,13 +9,13 @@ #include "android_webview/browser/scoped_allow_wait_for_legacy_web_view_api.h" #include "android_webview/crash_reporter/aw_microdump_crash_reporter.h" #include "android_webview/lib/aw_browser_dependency_factory_impl.h" +#include "android_webview/native/aw_assets.h" #include "android_webview/native/aw_media_url_interceptor.h" #include "android_webview/native/aw_message_port_service_impl.h" #include "android_webview/native/aw_quota_manager_bridge_impl.h" #include "android_webview/native/aw_web_contents_view_delegate.h" #include "android_webview/native/aw_web_preferences_populater_impl.h" #include "android_webview/native/external_video_surface_container_impl.h" -#include "android_webview/native/public/aw_assets.h" #include "android_webview/renderer/aw_content_renderer_client.h" #include "base/command_line.h" #include "base/cpu.h" diff --git a/android_webview/native/android_webview_jni_registrar.cc b/android_webview/native/android_webview_jni_registrar.cc index 1de8c4c..a9aa621 100644 --- a/android_webview/native/android_webview_jni_registrar.cc +++ b/android_webview/native/android_webview_jni_registrar.cc @@ -5,6 +5,7 @@ #include "android_webview/native/android_webview_jni_registrar.h" #include "android_webview/native/android_protocol_handler.h" +#include "android_webview/native/aw_assets.h" #include "android_webview/native/aw_autofill_client.h" #include "android_webview/native/aw_contents.h" #include "android_webview/native/aw_contents_client_bridge.h" @@ -26,7 +27,6 @@ #include "android_webview/native/input_stream_impl.h" #include "android_webview/native/java_browser_view_renderer_helper.h" #include "android_webview/native/permission/aw_permission_request.h" -#include "android_webview/native/public/aw_assets.h" #include "base/android/jni_android.h" #include "base/android/jni_registrar.h" #include "base/trace_event/trace_event.h" diff --git a/android_webview/native/public/aw_assets.cc b/android_webview/native/aw_assets.cc index e13d04e..ba734ae 100644 --- a/android_webview/native/public/aw_assets.cc +++ b/android_webview/native/aw_assets.cc @@ -4,7 +4,7 @@ #include <jni.h> -#include "android_webview/native/public/aw_assets.h" +#include "android_webview/native/aw_assets.h" #include "base/android/jni_array.h" #include "base/android/jni_string.h" diff --git a/android_webview/native/public/aw_assets.h b/android_webview/native/aw_assets.h index 9eacabf..16fcafb 100644 --- a/android_webview/native/public/aw_assets.h +++ b/android_webview/native/aw_assets.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef ANDROID_WEBVIEW_NATIVE_PUBLIC_AW_ASSETS_H_ -#define ANDROID_WEBVIEW_NATIVE_PUBLIC_AW_ASSETS_H_ +#ifndef ANDROID_WEBVIEW_NATIVE_AW_ASSETS_H_ +#define ANDROID_WEBVIEW_NATIVE_AW_ASSETS_H_ #include <string> @@ -33,4 +33,4 @@ bool RegisterAwAssets(JNIEnv* env); } // namsespace android_webview -#endif // ANDROID_WEBVIEW_NATIVE_PUBLIC_AW_ASSETS_H_ +#endif // ANDROID_WEBVIEW_NATIVE_AW_ASSETS_H_ diff --git a/android_webview/native/aw_media_url_interceptor.cc b/android_webview/native/aw_media_url_interceptor.cc index 3f52d9c..1b214da 100644 --- a/android_webview/native/aw_media_url_interceptor.cc +++ b/android_webview/native/aw_media_url_interceptor.cc @@ -5,8 +5,8 @@ #include <string> #include "android_webview/common/url_constants.h" +#include "android_webview/native/aw_assets.h" #include "android_webview/native/aw_media_url_interceptor.h" -#include "android_webview/native/public/aw_assets.h" #include "base/strings/string_util.h" #include "content/public/common/url_constants.h" diff --git a/android_webview/native/webview_native.gyp b/android_webview/native/webview_native.gyp index 121a876..34889e1 100644 --- a/android_webview/native/webview_native.gyp +++ b/android_webview/native/webview_native.gyp @@ -36,6 +36,8 @@ 'android_protocol_handler.h', 'android_webview_jni_registrar.cc', 'android_webview_jni_registrar.h', + 'aw_assets.cc', + 'aw_assets.h', 'aw_autofill_client.cc', 'aw_autofill_client.h', 'aw_browser_dependency_factory.cc', @@ -95,8 +97,6 @@ 'permission/permission_request_handler_client.h', 'permission/simple_permission_request.cc', 'permission/simple_permission_request.h', - 'public/aw_assets.cc', - 'public/aw_assets.h', 'state_serializer.cc', 'state_serializer.h', ], |