diff options
| author | peter <peter@chromium.org> | 2014-11-11 11:56:37 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-11-11 19:57:26 +0000 |
| commit | 9b199faebfa69908859b9069cbb3e5b207c8e825 (patch) | |
| tree | 559d1d4e00b6c480c3afe99b2011a77e85cdd669 | |
| parent | 9382542aab227a43adef11b240f1661054b8deb0 (diff) | |
| download | chromium_src-9b199faebfa69908859b9069cbb3e5b207c8e825.zip chromium_src-9b199faebfa69908859b9069cbb3e5b207c8e825.tar.gz chromium_src-9b199faebfa69908859b9069cbb3e5b207c8e825.tar.bz2 | |
Remove the NetworkPortalNotificationController error metric.
This metric is no longer being used now that NotificationDelegate::OnError
went away. However, since it's being used for UMA statistics, the values
of all other metrics in the enumeration must stay the same.
BUG=431307
Review URL: https://codereview.chromium.org/691103003
Cr-Commit-Position: refs/heads/master@{#303699}
| -rw-r--r-- | chrome/browser/chromeos/net/network_portal_notification_controller.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chrome/browser/chromeos/net/network_portal_notification_controller.h b/chrome/browser/chromeos/net/network_portal_notification_controller.h index 6716db8..597bdb0 100644 --- a/chrome/browser/chromeos/net/network_portal_notification_controller.h +++ b/chrome/browser/chromeos/net/network_portal_notification_controller.h @@ -16,11 +16,11 @@ class NetworkState; class NetworkPortalNotificationController { public: + // The values of these metrics are being used for UMA gathering, so it is + // important that they don't change between releases. enum NotificationMetric { NOTIFICATION_METRIC_DISPLAYED = 0, - // TODO(peter): The ERROR metric is not being used anymore, remove it. - NOTIFICATION_METRIC_ERROR, - NOTIFICATION_METRIC_COUNT + NOTIFICATION_METRIC_COUNT = 2 }; enum UserActionMetric { |