summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorhaitaol@chromium.org <haitaol@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-02-04 19:25:33 +0000
committerhaitaol@chromium.org <haitaol@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-02-04 19:25:33 +0000
commit284b46d4be13d5f0e4b5cabbc80711b51c7af2d6 (patch)
tree6d06a9fe3f77c369f602886e7d5fce32cd627b7a
parent45936acf357193d351b0a39da85a7d9fa4f2d632 (diff)
downloadchromium_src-284b46d4be13d5f0e4b5cabbc80711b51c7af2d6.zip
chromium_src-284b46d4be13d5f0e4b5cabbc80711b51c7af2d6.tar.gz
chromium_src-284b46d4be13d5f0e4b5cabbc80711b51c7af2d6.tar.bz2
Add time range to GlobalIdDirective for deleting additional local navigations
to URLs that has at least one visit that match with global ID. BUG=141245 Review URL: https://chromiumcodereview.appspot.com/12088074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180471 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--sync/protocol/history_delete_directive_specifics.proto6
-rw-r--r--sync/protocol/proto_value_conversions.cc2
2 files changed, 8 insertions, 0 deletions
diff --git a/sync/protocol/history_delete_directive_specifics.proto b/sync/protocol/history_delete_directive_specifics.proto
index 557de8d..d647ddd 100644
--- a/sync/protocol/history_delete_directive_specifics.proto
+++ b/sync/protocol/history_delete_directive_specifics.proto
@@ -29,6 +29,12 @@ message HistoryDeleteDirectiveSpecifics {
message GlobalIdDirective {
// The global IDs of the navigations to delete.
repeated int64 global_id = 1;
+
+ // Time range for searching for navigations to delete. Client should delete
+ // all navigations to a URL between [start_time_usec, end_time_usec]
+ // if one of them matches a |global_id|.
+ optional int64 start_time_usec = 2;
+ optional int64 end_time_usec = 3;
}
message TimeRangeDirective {
diff --git a/sync/protocol/proto_value_conversions.cc b/sync/protocol/proto_value_conversions.cc
index fb5f568..b675674 100644
--- a/sync/protocol/proto_value_conversions.cc
+++ b/sync/protocol/proto_value_conversions.cc
@@ -212,6 +212,8 @@ base::DictionaryValue* GlobalIdDirectiveToValue(
const sync_pb::GlobalIdDirective& proto) {
DictionaryValue* value = new DictionaryValue();
SET_INT64_REP(global_id);
+ SET_INT64(start_time_usec);
+ SET_INT64(end_time_usec);
return value;
}