diff options
author | dmikurube@chromium.org <dmikurube@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-07 18:45:59 +0000 |
---|---|---|
committer | dmikurube@chromium.org <dmikurube@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-07 18:45:59 +0000 |
commit | 2fa89ef4d24b0cb46be663192f058677d7637f9d (patch) | |
tree | c43d254638247bfdad05305fcfcd6a28f0ba5cce | |
parent | 8c550bd1caf59ea05e0c975f0841a357f2360a5b (diff) | |
download | chromium_src-2fa89ef4d24b0cb46be663192f058677d7637f9d.zip chromium_src-2fa89ef4d24b0cb46be663192f058677d7637f9d.tar.gz chromium_src-2fa89ef4d24b0cb46be663192f058677d7637f9d.tar.bz2 |
Remove {linux|android}_use_tcmalloc and switch to use_allocator in Chromium.
If this change breaks some bots, please try restarting the
bot before reverting it. http://crrev.com/264460 may not be
effective yet until restarting.
See the bug and http://crrev.com/255129 for the details.
BUG=345554
Review URL: https://codereview.chromium.org/258433005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268876 0039d316-1c4b-4281-b951-d872f2087c98
44 files changed, 72 insertions, 135 deletions
diff --git a/ash/ash.gyp b/ash/ash.gyp index 3592dbb..1cd7748 100644 --- a/ash/ash.gyp +++ b/ash/ash.gyp @@ -1063,8 +1063,7 @@ ['exclude', 'display/resolution_notification_controller_unittest.cc'], ], }], - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS=="linux" and component=="shared_library" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', { + ['OS=="linux" and component=="shared_library" and use_allocator!="none"', { 'dependencies': [ '<(DEPTH)/base/allocator/allocator.gyp:allocator', ], diff --git a/base/base.gyp b/base/base.gyp index e8b7d30..85f0a94 100644 --- a/base/base.gyp +++ b/base/base.gyp @@ -143,8 +143,7 @@ ], }, 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['use_allocator!="tcmalloc" and (use_allocator!="see_use_tcmalloc" or linux_use_tcmalloc==0)', { + ['use_allocator!="tcmalloc"', { 'defines': [ 'NO_TCMALLOC', ], @@ -700,8 +699,7 @@ 'message_loop/message_pump_glib_unittest.cc', ] }], - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS == "linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', { + ['OS == "linux" and use_allocator!="none"', { 'dependencies': [ 'allocator/allocator.gyp:allocator', ], diff --git a/build/common.gypi b/build/common.gypi index efb8063..def3eaf 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -820,10 +820,7 @@ ['OS=="linux" and target_arch=="arm" and chromeos==0', { # Set some defaults for arm/linux chrome builds - # TODO(dmikurube): Change the default of use_allocator to "none". - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - 'linux_use_tcmalloc%': 0, - 'use_allocator%': 'see_use_tcmalloc', + 'use_allocator%': 'none', # sysroot needs to be an absolute path otherwise it generates # incorrect results when passed to pkg-config 'sysroot%': '<!(cd <(DEPTH) && pwd -P)/arm-sysroot', @@ -1222,15 +1219,8 @@ 'binutils_dir%': '', # Enable TCMalloc. - # TODO(dmikurube): Change Linux default of use_allocator to "tcmalloc". - # TODO(dmikurube): Change Android default of use_allocator to "none". - # TODO(dmikurube): Kill {linux|android}_use_tcmalloc. http://crbug.com/345554 - # {linux|android}_use_tcmalloc are to be replaced with use_allocator. - # They are now used only if use_allocator=="see_use_tcmalloc" (default). - # TODO(dmikurube): Assert when {linux|android}_use_tcmalloc is explicitly specified. - 'linux_use_tcmalloc%': 1, - 'android_use_tcmalloc%': 0, - 'use_allocator%': 'see_use_tcmalloc', + # Default of 'use_allocator' is set to 'none' if OS=='android' later. + 'use_allocator%': 'tcmalloc', # Set to 1 to link against libgnome-keyring instead of using dlopen(). 'linux_link_gnome_keyring%': 0, @@ -1460,10 +1450,7 @@ 'werror%': '', 'disable_nacl%': 1, 'nacl_untrusted_build%': 0, - # TODO(dmikurube): Change the default of use_allocator to "none". - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - 'linux_use_tcmalloc%': 0, - 'use_allocator%': 'see_use_tcmalloc', + 'use_allocator%': 'none', }], ['OS=="linux" and target_arch=="mipsel"', { 'sysroot%': '<(sysroot)', @@ -1650,10 +1637,7 @@ 'input_speech%': 0, 'java_bridge%': 1, 'build_ffmpegsumo%': 0, - # TODO(dmikurube): Change the default of use_allocator to "none". - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - 'linux_use_tcmalloc%': 0, - 'use_allocator%': 'see_use_tcmalloc', + 'use_allocator%': 'none', # Disable Native Client. 'disable_nacl%': 1, @@ -2043,10 +2027,7 @@ 'win_release_InlineFunctionExpansion': '0', 'win_release_OmitFramePointers': '0', - # TODO(dmikurube): Change the default of use_allocator to "tcmalloc". - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - 'linux_use_tcmalloc%': 1, - 'use_allocator': 'see_use_tcmalloc', + 'use_allocator': 'tcmalloc', 'release_valgrind_build': 1, 'werror': '', 'component': 'static_library', @@ -2299,8 +2280,7 @@ '<(DEPTH)/build/mac/asan.gyp:asan_dynamic_runtime', ], }], - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS=="linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)) and clang_type_profiler==1', { + ['OS=="linux" and use_allocator!="none" and clang_type_profiler==1', { 'cflags_cc!': ['-fno-rtti'], 'cflags_cc+': [ '-frtti', @@ -3865,8 +3845,7 @@ }], ], }], - # TODO(dmikurube): Kill {linux|android}_use_tcmalloc. http://crbug.com/345554 - ['use_allocator!="tcmalloc" and (use_allocator!="see_use_tcmalloc" or ((OS=="linux" and linux_use_tcmalloc==0) or (OS=="android" and android_use_tcmalloc==0)))', { + ['use_allocator!="tcmalloc"', { 'defines': ['NO_TCMALLOC'], }], ['linux_use_gold_flags==1', { diff --git a/build/gyp_chromium b/build/gyp_chromium index 201e5a0..26028dc 100755 --- a/build/gyp_chromium +++ b/build/gyp_chromium @@ -277,6 +277,17 @@ if __name__ == '__main__': supplemental_includes = GetSupplementalFiles() gyp_vars_dict = GetGypVars(supplemental_includes) + # TODO(dmikurube): Remove these checks and messages after a while. + if ('linux_use_tcmalloc' in gyp_vars_dict or + 'android_use_tcmalloc' in gyp_vars_dict): + print '*****************************************************************' + print '"linux_use_tcmalloc" and "android_use_tcmalloc" are deprecated!' + print '-----------------------------------------------------------------' + print 'You specify "linux_use_tcmalloc" or "android_use_tcmalloc" in' + print 'your GYP_DEFINES. Please switch them into "use_allocator" now.' + print 'See http://crbug.com/345554 for the details.' + print '*****************************************************************' + # Automatically turn on crosscompile support for platforms that need it. # (The Chrome OS build sets CC_host / CC_target which implicitly enables # this mode.) diff --git a/cc/cc_tests.gyp b/cc/cc_tests.gyp index be7145e..25fb760 100644 --- a/cc/cc_tests.gyp +++ b/cc/cc_tests.gyp @@ -268,8 +268,7 @@ [ 'os_posix == 1 and OS != "mac" and OS != "android" and OS != "ios"', { 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - [ '(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', + [ 'use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', @@ -328,8 +327,7 @@ } ], # See http://crbug.com/162998#c4 for why this is needed. - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS=="linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', + ['OS=="linux" and use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', diff --git a/chrome/chrome_android.gypi b/chrome/chrome_android.gypi index 00a3af2..8ba1f24 100644 --- a/chrome/chrome_android.gypi +++ b/chrome/chrome_android.gypi @@ -39,8 +39,7 @@ }], ], }], - # TODO(dmikurube): Kill android_use_tcmalloc. http://crbug.com/345554 - [ '(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and android_use_tcmalloc==1)', { + [ 'use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], }], diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi index 7e1e83f..b7a23b1 100644 --- a/chrome/chrome_exe.gypi +++ b/chrome/chrome_exe.gypi @@ -141,8 +141,7 @@ }, ], 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + ['use_allocator!="none"', { 'dependencies': [ '<(allocator_target)', ], diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi index 9b94b27..c0a0d44 100644 --- a/chrome/chrome_tests.gypi +++ b/chrome/chrome_tests.gypi @@ -1875,8 +1875,7 @@ }], ['os_posix == 1 and OS != "mac" and OS != "android"', { 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + ['use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], @@ -2148,8 +2147,7 @@ }], ['os_posix == 1 and OS != "mac" and OS != "android"', { 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + ['use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], @@ -2659,8 +2657,7 @@ }], ['os_posix == 1 and OS != "mac" and OS != "android"', { 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + ['use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi index 4066c4e..f8b3b81 100644 --- a/chrome/chrome_tests_unit.gypi +++ b/chrome/chrome_tests_unit.gypi @@ -2349,8 +2349,7 @@ }], ['os_posix == 1 and OS != "mac" and OS != "ios" and OS != "android"', { 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + ['use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/chromeos/chromeos.gyp b/chromeos/chromeos.gyp index 8ab802a..e2e332a 100644 --- a/chromeos/chromeos.gyp +++ b/chromeos/chromeos.gyp @@ -547,8 +547,7 @@ '..', ], 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - [ '(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + [ 'use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/cloud_print/cloud_print.gyp b/cloud_print/cloud_print.gyp index feb8311..e54dc86 100644 --- a/cloud_print/cloud_print.gyp +++ b/cloud_print/cloud_print.gyp @@ -52,8 +52,7 @@ ], }], # See http://crbug.com/162998#c4 for why this is needed. - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS=="linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', { + ['OS=="linux" and use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/components/components_tests.gyp b/components/components_tests.gyp index 77be272..6875cec 100644 --- a/components/components_tests.gyp +++ b/components/components_tests.gyp @@ -445,8 +445,7 @@ '../base/allocator/allocator.gyp:allocator', ], }], - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS=="linux" and component=="shared_library" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', { + ['OS=="linux" and component=="shared_library" and use_allocator!="none"', { 'dependencies': [ '<(DEPTH)/base/allocator/allocator.gyp:allocator', ], diff --git a/components/nacl.gyp b/components/nacl.gyp index 2c70b7d..7b3b096 100644 --- a/components/nacl.gyp +++ b/components/nacl.gyp @@ -307,8 +307,7 @@ }], ['os_posix == 1 and OS != "mac"', { 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + ['use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/content/content_app.gypi b/content/content_app.gypi index 4d10317..0a873a4 100644 --- a/content/content_app.gypi +++ b/content/content_app.gypi @@ -35,8 +35,7 @@ 'public/app/startup_helper_win.h', ], 'conditions': [ - # TODO(dmikurube): Kill {linux|android}_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and ((OS=="linux" and os_posix==1 and use_aura==1 and linux_use_tcmalloc==1) or (OS=="android" and android_use_tcmalloc==1)))', { + ['((OS=="linux" and os_posix==1 and use_aura==1) or OS=="android") and use_allocator!="none"', { 'dependencies': [ # This is needed by app/content_main_runner.cc '../base/allocator/allocator.gyp:allocator', diff --git a/content/content_shell.gypi b/content/content_shell.gypi index bb385ae3..3b14649 100644 --- a/content/content_shell.gypi +++ b/content/content_shell.gypi @@ -299,8 +299,7 @@ '../components/components.gyp:breakpad_host', ], }], - # TODO(dmikurube): Kill {linux|android}_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and ((OS=="linux" and linux_use_tcmalloc==1) or (OS=="android" and android_use_tcmalloc==1)))', { + ['(OS=="linux" or OS=="android") and use_allocator!="none"', { 'dependencies': [ # This is needed by content/app/content_main_runner.cc '../base/allocator/allocator.gyp:allocator', diff --git a/content/content_tests.gypi b/content/content_tests.gypi index 2f29ec3..3f7c94b 100644 --- a/content/content_tests.gypi +++ b/content/content_tests.gypi @@ -1411,10 +1411,9 @@ '<(angle_path)/src/build_angle.gyp:libGLESv2', ], }], - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 ['(OS=="win" and win_use_allocator_shim==1) or ' '(os_posix == 1 and OS != "android" and ' - ' ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)))', { + ' use_allocator!="none")', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/courgette/courgette.gyp b/courgette/courgette.gyp index 00c2088..52db0fb 100644 --- a/courgette/courgette.gyp +++ b/courgette/courgette.gyp @@ -121,8 +121,7 @@ 'conditions': [ [ 'os_posix == 1 and OS != "mac" and OS != "android" and OS != "ios"', { 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + ['use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/crypto/crypto.gyp b/crypto/crypto.gyp index e43f976..ec1e278 100644 --- a/crypto/crypto.gyp +++ b/crypto/crypto.gyp @@ -180,8 +180,7 @@ 'conditions': [ [ 'os_posix == 1 and OS != "mac" and OS != "android" and OS != "ios"', { 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - [ '(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + [ 'use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/device/device_tests.gyp b/device/device_tests.gyp index b28f475..46c8f3d 100644 --- a/device/device_tests.gyp +++ b/device/device_tests.gyp @@ -59,8 +59,7 @@ }], ['os_posix == 1 and OS != "mac" and OS != "android" and OS != "ios"', { 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + ['use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/gpu/gles2_conform_support/gles2_conform_support.gyp b/gpu/gles2_conform_support/gles2_conform_support.gyp index d34996e..92af9d9 100644 --- a/gpu/gles2_conform_support/gles2_conform_support.gyp +++ b/gpu/gles2_conform_support/gles2_conform_support.gyp @@ -107,8 +107,7 @@ ], 'conditions': [ # See http://crbug.com/162998#c4 for why this is needed. - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS=="linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', { + ['OS=="linux" and use_allocator!="none"', { 'dependencies': [ '../../base/allocator/allocator.gyp:allocator', ], diff --git a/gpu/gpu.gyp b/gpu/gpu.gyp index bfac7da..b0ccb99 100644 --- a/gpu/gpu.gyp +++ b/gpu/gpu.gyp @@ -287,8 +287,7 @@ ], }], # See http://crbug.com/162998#c4 for why this is needed. - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS=="linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', { + ['OS=="linux" and use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/ipc/BUILD.gn b/ipc/BUILD.gn index cccbb58..9d9e49a 100644 --- a/ipc/BUILD.gn +++ b/ipc/BUILD.gn @@ -114,8 +114,7 @@ if (!is_android) { # TODO(brettw) hook up tcmalloc to this target. #if (is_posix && !is_mac && !is_android) { - # # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - # if ((use_allocator!="none" && use_allocator!="see_use_tcmalloc") || (use_allocator=="see_use_tcmalloc" && linux_use_tcmalloc)) { + # if (use_allocator!="none") { # deps += "/base/allocator" # } #} @@ -145,8 +144,7 @@ if (!is_android) { # TODO(brettw) hook up tcmalloc to this target. #if (is_posix && !is_mac && !is_android) { - # # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - # if ((use_allocator!="none" && use_allocator!="see_use_tcmalloc") || (use_allocator=="see_use_tcmalloc" && linux_use_tcmalloc)) { + # if (use_allocator!="none") { # deps += "//base/allocator" # } #} diff --git a/ipc/ipc.gyp b/ipc/ipc.gyp index dac7cfa..c5a8c0b 100644 --- a/ipc/ipc.gyp +++ b/ipc/ipc.gyp @@ -74,8 +74,7 @@ }], ['os_posix == 1 and OS != "mac" and OS != "android"', { 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + ['use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], @@ -113,8 +112,7 @@ }], ['os_posix == 1 and OS != "mac" and OS != "android"', { 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + ['use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/media/media.gyp b/media/media.gyp index 38dfcc5..9da80d8 100644 --- a/media/media.gyp +++ b/media/media.gyp @@ -1105,8 +1105,7 @@ }], ['os_posix==1 and OS!="mac"', { 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + ['use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], @@ -1699,8 +1698,7 @@ 'conditions': [ ['os_posix==1 and OS!="mac"', { 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + ['use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/net/net.gyp b/net/net.gyp index b7bd047..50520b9 100644 --- a/net/net.gyp +++ b/net/net.gyp @@ -551,8 +551,7 @@ }], [ 'os_posix == 1 and OS != "mac" and OS != "android" and OS != "ios"', { 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + ['use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], @@ -911,8 +910,7 @@ }], ['os_posix == 1 and OS != "mac" and OS != "android" and OS != "ios"', { 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + ['use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/ppapi/ppapi_tests.gypi b/ppapi/ppapi_tests.gypi index da4b026..6fe9d90 100644 --- a/ppapi/ppapi_tests.gypi +++ b/ppapi/ppapi_tests.gypi @@ -126,8 +126,7 @@ ], 'conditions': [ # See http://crbug.com/162998#c4 for why this is needed. - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS=="linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', { + ['OS=="linux" and use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], @@ -191,8 +190,7 @@ 'conditions': [ [ 'os_posix == 1 and OS != "mac" and OS != "android" and OS != "ios"', { 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - [ '(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + [ 'use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/printing/printing.gyp b/printing/printing.gyp index aea2c2e..792f5df 100644 --- a/printing/printing.gyp +++ b/printing/printing.gyp @@ -247,8 +247,7 @@ }], [ 'os_posix == 1 and OS != "mac" and OS != "android" and OS != "ios"', { 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + ['use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/remoting/remoting_host.gypi b/remoting/remoting_host.gypi index 3782fff..ff1996f 100644 --- a/remoting/remoting_host.gypi +++ b/remoting/remoting_host.gypi @@ -752,8 +752,7 @@ }], # mac_breakpad==1 ], # conditions }], # OS=mac - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS=="linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', { + ['OS=="linux" and use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], @@ -784,8 +783,7 @@ 'host/setup/me2me_native_messaging_host_main.h', ], 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS=="linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', { + ['OS=="linux" and use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], @@ -877,8 +875,7 @@ '../build/linux/system.gyp:gtk', ], }], - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS=="linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', { + ['OS=="linux" and use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/remoting/remoting_host_linux.gypi b/remoting/remoting_host_linux.gypi index 770e764..5187bd2 100644 --- a/remoting/remoting_host_linux.gypi +++ b/remoting/remoting_host_linux.gypi @@ -128,8 +128,7 @@ 'host/setup/start_host.cc', ], 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + ['use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/remoting/remoting_test.gypi b/remoting/remoting_test.gypi index 65160c3..5d8e62a 100644 --- a/remoting/remoting_test.gypi +++ b/remoting/remoting_test.gypi @@ -230,8 +230,7 @@ ['exclude', '^base/resources_unittest\\.cc$'], ] }], - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - [ 'OS == "linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', { + [ 'OS == "linux" and use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/sql/sql.gyp b/sql/sql.gyp index f62a2eb..6245940 100644 --- a/sql/sql.gyp +++ b/sql/sql.gyp @@ -99,8 +99,7 @@ 'conditions': [ ['os_posix==1 and OS!="mac" and OS!="ios"', { 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + ['use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/sync/sync_tests.gypi b/sync/sync_tests.gypi index b7cee38..2b69d68 100644 --- a/sync/sync_tests.gypi +++ b/sync/sync_tests.gypi @@ -505,8 +505,7 @@ # TODO(akalin): This is needed because histogram.cc uses # leak_annotations.h, which pulls this in. Make 'base' # propagate this dependency. - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS=="linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', { + ['OS=="linux" and use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/ui/app_list/app_list.gyp b/ui/app_list/app_list.gyp index 6665742..3dda480 100644 --- a/ui/app_list/app_list.gyp +++ b/ui/app_list/app_list.gyp @@ -258,8 +258,7 @@ ], }], # See http://crbug.com/162998#c4 for why this is needed. - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS=="linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', { + ['OS=="linux" and use_allocator!="none"', { 'dependencies': [ '../../base/allocator/allocator.gyp:allocator', # The following two dependencies provide the missing diff --git a/ui/aura/aura.gyp b/ui/aura/aura.gyp index a8900f8..9e5200e3 100644 --- a/ui/aura/aura.gyp +++ b/ui/aura/aura.gyp @@ -285,8 +285,7 @@ '<(DEPTH)/third_party/mesa/mesa.gyp:osmesa', ], }], - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS=="linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', { + ['OS=="linux" and use_allocator!="none"', { 'dependencies': [ # See http://crbug.com/162998#c4 for why this is needed. '../../base/allocator/allocator.gyp:allocator', diff --git a/ui/compositor/compositor.gyp b/ui/compositor/compositor.gyp index 1145e8e..2822397 100644 --- a/ui/compositor/compositor.gyp +++ b/ui/compositor/compositor.gyp @@ -162,8 +162,7 @@ }], ['os_posix == 1 and OS != "mac"', { 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + ['use_allocator!="none"', { 'dependencies': [ '<(DEPTH)/base/allocator/allocator.gyp:allocator', ], diff --git a/ui/events/events.gyp b/ui/events/events.gyp index fed04fb..faf21ee 100644 --- a/ui/events/events.gyp +++ b/ui/events/events.gyp @@ -363,8 +363,7 @@ 'x/events_x_unittest.cc', ], 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS=="linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', { + ['OS=="linux" and use_allocator!="none"', { 'dependencies': [ '<(DEPTH)/base/allocator/allocator.gyp:allocator', ], diff --git a/ui/keyboard/keyboard.gyp b/ui/keyboard/keyboard.gyp index c4ca714..e780048 100644 --- a/ui/keyboard/keyboard.gyp +++ b/ui/keyboard/keyboard.gyp @@ -99,8 +99,7 @@ 'keyboard_controller_unittest.cc', ], 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS=="linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', { + ['OS=="linux" and use_allocator!="none"', { 'dependencies': [ '<(DEPTH)/base/allocator/allocator.gyp:allocator', ], diff --git a/ui/message_center/message_center.gyp b/ui/message_center/message_center.gyp index 8812eb9..0ae2876 100644 --- a/ui/message_center/message_center.gyp +++ b/ui/message_center/message_center.gyp @@ -235,8 +235,7 @@ ], }], # See http://crbug.com/162998#c4 for why this is needed. - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS=="linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', { + ['OS=="linux" and use_allocator!="none"', { 'dependencies': [ '../../base/allocator/allocator.gyp:allocator', ], diff --git a/ui/snapshot/snapshot.gyp b/ui/snapshot/snapshot.gyp index e34b0c2..a6a997e 100644 --- a/ui/snapshot/snapshot.gyp +++ b/ui/snapshot/snapshot.gyp @@ -72,8 +72,7 @@ ], }], # See http://crbug.com/162998#c4 for why this is needed. - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS=="linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', { + ['OS=="linux" and use_allocator!="none"', { 'dependencies': [ '../../base/allocator/allocator.gyp:allocator', ], diff --git a/ui/ui_unittests.gyp b/ui/ui_unittests.gyp index 4e91338..87f227e 100644 --- a/ui/ui_unittests.gyp +++ b/ui/ui_unittests.gyp @@ -154,8 +154,7 @@ 'gfx/platform_font_pango_unittest.cc', ], 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + ['use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', ], diff --git a/ui/views/views.gyp b/ui/views/views.gyp index 59f8c5a..883c035 100644 --- a/ui/views/views.gyp +++ b/ui/views/views.gyp @@ -700,8 +700,7 @@ '../../base/allocator/allocator.gyp:allocator', ], }], - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['OS=="linux" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', { + ['OS=="linux" and use_allocator!="none"', { # See http://crbug.com/162998#c4 for why this is needed. 'dependencies': [ '../../base/allocator/allocator.gyp:allocator', diff --git a/url/BUILD.gn b/url/BUILD.gn index df7da69..3736b9c 100644 --- a/url/BUILD.gn +++ b/url/BUILD.gn @@ -101,8 +101,7 @@ if (!is_android) { ] #if (is_posix && !is_mac && !is_ios) { - # # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - # if ((use_allocator!="none" && use_allocator!="see_use_tcmalloc") || (use_allocator=="see_use_tcmalloc" && linux_use_tcmalloc) { + # if (use_allocator!="none") { # deps += "//base/allocator" # } #} diff --git a/url/url.gyp b/url/url.gyp index d1c3bf1..0ffc51a 100644 --- a/url/url.gyp +++ b/url/url.gyp @@ -77,8 +77,7 @@ 'url_util_unittest.cc', ], 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - ['os_posix==1 and OS!="mac" and OS!="ios" and ((use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1))', + ['os_posix==1 and OS!="mac" and OS!="ios" and use_allocator!="none"', { 'dependencies': [ '../base/allocator/allocator.gyp:allocator', diff --git a/webkit/renderer/compositor_bindings/compositor_bindings_tests.gyp b/webkit/renderer/compositor_bindings/compositor_bindings_tests.gyp index 53978a2..f29a985 100644 --- a/webkit/renderer/compositor_bindings/compositor_bindings_tests.gyp +++ b/webkit/renderer/compositor_bindings/compositor_bindings_tests.gyp @@ -39,8 +39,7 @@ }], [ 'os_posix == 1 and OS != "mac" and OS != "android" and OS != "ios"', { 'conditions': [ - # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 - [ '(use_allocator!="none" and use_allocator!="see_use_tcmalloc") or (use_allocator=="see_use_tcmalloc" and linux_use_tcmalloc==1)', { + [ 'use_allocator!="none"', { 'dependencies': [ '<(DEPTH)/base/allocator/allocator.gyp:allocator', ], |