summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorsievers <sievers@chromium.org>2015-02-27 13:18:55 -0800
committerCommit bot <commit-bot@chromium.org>2015-02-27 21:20:07 +0000
commita86baaf1c19c35a3962bb8f2192b2c8a5d780a33 (patch)
tree4ecbef9f4f2ec1735caffb106ee78577403a5112
parentc60ae9f919f8866866b233998962c9bfeda67d51 (diff)
downloadchromium_src-a86baaf1c19c35a3962bb8f2192b2c8a5d780a33.zip
chromium_src-a86baaf1c19c35a3962bb8f2192b2c8a5d780a33.tar.gz
chromium_src-a86baaf1c19c35a3962bb8f2192b2c8a5d780a33.tar.bz2
Android: Hide unused (and broken) Compositor::SetVisible API
This is not used, and it looks like it will almost certainly do the wrong thing if combined with SetSurface(). TBR=dtrainor@chromium.org Review URL: https://codereview.chromium.org/964503005 Cr-Commit-Position: refs/heads/master@{#318517}
-rw-r--r--content/browser/renderer_host/compositor_impl_android.h2
-rw-r--r--content/public/browser/android/compositor.h5
2 files changed, 1 insertions, 6 deletions
diff --git a/content/browser/renderer_host/compositor_impl_android.h b/content/browser/renderer_host/compositor_impl_android.h
index 151b1ee..568dfd1 100644
--- a/content/browser/renderer_host/compositor_impl_android.h
+++ b/content/browser/renderer_host/compositor_impl_android.h
@@ -55,7 +55,6 @@ class CONTENT_EXPORT CompositorImpl
// Compositor implementation.
void SetRootLayer(scoped_refptr<cc::Layer> root) override;
void SetSurface(jobject surface) override;
- void SetVisible(bool visible) override;
void setDeviceScaleFactor(float factor) override;
void SetWindowBounds(const gfx::Size& size) override;
void SetHasTransparentBackground(bool flag) override;
@@ -101,6 +100,7 @@ class CONTENT_EXPORT CompositorImpl
void SetNeedsAnimate() override;
void SetWindowSurface(ANativeWindow* window);
+ void SetVisible(bool visible);
enum CompositingTrigger {
DO_NOT_COMPOSITE,
diff --git a/content/public/browser/android/compositor.h b/content/public/browser/android/compositor.h
index 3cff0ea..1a96ee6 100644
--- a/content/public/browser/android/compositor.h
+++ b/content/public/browser/android/compositor.h
@@ -54,11 +54,6 @@ class CONTENT_EXPORT Compositor {
// Set the output surface bounds.
virtual void SetWindowBounds(const gfx::Size& size) = 0;
- // Sets the window visibility. When becoming invisible, resources will get
- // freed and other calls into the compositor are not allowed until after
- // having been made visible again.
- virtual void SetVisible(bool visible) = 0;
-
// Set the output surface which the compositor renders into.
virtual void SetSurface(jobject surface) = 0;