summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormiguelg <miguelg@chromium.org>2015-03-20 05:29:51 -0700
committerCommit bot <commit-bot@chromium.org>2015-03-20 12:31:00 +0000
commitd7cdbb34768054953761fd487fa5165dcb4e6505 (patch)
tree84f3c1cee71699d5fe147d9da1f8b2571efa4ba9
parent60d4e9484cdf91ab6dcd2b5ddfbdc6538d93ca27 (diff)
downloadchromium_src-d7cdbb34768054953761fd487fa5165dcb4e6505.zip
chromium_src-d7cdbb34768054953761fd487fa5165dcb4e6505.tar.gz
chromium_src-d7cdbb34768054953761fd487fa5165dcb4e6505.tar.bz2
Add rappor metrics for messages received
BUG=466091 Review URL: https://codereview.chromium.org/1017183002 Cr-Commit-Position: refs/heads/master@{#321559}
-rw-r--r--chrome/browser/push_messaging/push_messaging_service_impl.cc6
-rw-r--r--tools/metrics/rappor/rappor.xml7
2 files changed, 13 insertions, 0 deletions
diff --git a/chrome/browser/push_messaging/push_messaging_service_impl.cc b/chrome/browser/push_messaging/push_messaging_service_impl.cc
index ba3e2da..251e85a 100644
--- a/chrome/browser/push_messaging/push_messaging_service_impl.cc
+++ b/chrome/browser/push_messaging/push_messaging_service_impl.cc
@@ -34,6 +34,7 @@
#include "components/content_settings/core/common/permission_request_id.h"
#include "components/gcm_driver/gcm_driver.h"
#include "components/pref_registry/pref_registry_syncable.h"
+#include "components/rappor/rappor_utils.h"
#include "content/public/browser/browser_context.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/render_frame_host.h"
@@ -200,6 +201,11 @@ void PushMessagingServiceImpl::OnMessage(
return;
}
+ rappor::SampleDomainAndRegistryFromGURL(
+ g_browser_process->rappor_service(),
+ "PushMessaging.MessageReceived.Origin",
+ application_id.origin());
+
// The Push API only exposes a single string of data in the push event fired
// on the Service Worker. When developers send messages using GCM to the Push
// API and want to include a message payload, they must pass a single key-
diff --git a/tools/metrics/rappor/rappor.xml b/tools/metrics/rappor/rappor.xml
index 5e3fa07..99d3c71 100644
--- a/tools/metrics/rappor/rappor.xml
+++ b/tools/metrics/rappor/rappor.xml
@@ -173,6 +173,13 @@ components/rappor/rappor_service.cc.
</summary>
</rappor-metric>
+<rappor-metric name="PushMessaging.MessageReceived.Origin" type="ETLD_PLUS_ONE">
+ <owner>miguelg@chromium.org</owner>
+ <summary>
+ Push Messages received per Origin.
+ </summary>
+</rappor-metric>
+
<rappor-metric name="Search.DefaultSearchProvider" type="ETLD_PLUS_ONE">
<owner>holte@chromium.org</owner>
<summary>