summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authortedchoc <tedchoc@chromium.org>2015-06-26 12:06:19 -0700
committerCommit bot <commit-bot@chromium.org>2015-06-26 19:06:51 +0000
commit471a38d440a00b2e3f1c8a880774b6ad31c2e369 (patch)
tree9bbdbc50fe6a13b4000779b4e420d956e214fc20
parent5977b7ae2cc864964f314de71bdc5f0058aa862d (diff)
downloadchromium_src-471a38d440a00b2e3f1c8a880774b6ad31c2e369.zip
chromium_src-471a38d440a00b2e3f1c8a880774b6ad31c2e369.tar.gz
chromium_src-471a38d440a00b2e3f1c8a880774b6ad31c2e369.tar.bz2
Change UrlBar#isInBatchEditMode to something that does not conflict with TextView.
BUG= Review URL: https://codereview.chromium.org/1221433003 Cr-Commit-Position: refs/heads/master@{#336435}
-rw-r--r--chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java2
-rw-r--r--chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java4
2 files changed, 4 insertions, 2 deletions
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
index 65f204b..7fdc186 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
@@ -1763,7 +1763,7 @@ public class LocationBarLayout extends FrameLayout implements OnClickListener,
Editable text = mUrlBar.getText();
return mUrlBar.isCursorAtEndOfTypedText()
- && !mUrlBar.isInBatchEditMode()
+ && !mUrlBar.isHandlingBatchInput()
&& BaseInputConnection.getComposingSpanEnd(text)
== BaseInputConnection.getComposingSpanStart(text);
}
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
index 6696bc5..7d344a5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
@@ -277,7 +277,9 @@ public class UrlBar extends VerticallyFixedEditText {
* @return Whether the URL is currently in batch edit mode triggered by an IME. No external
* text changes should be triggered while this is true.
*/
- public boolean isInBatchEditMode() {
+ // isInBatchEditMode is a package protected method on TextView, so we intentionally chose
+ // a different name.
+ public boolean isHandlingBatchInput() {
return mInBatchEditMode;
}