summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorkaliamoorthi <kaliamoorthi@chromium.org>2015-02-13 04:51:54 -0800
committerCommit bot <commit-bot@chromium.org>2015-02-13 12:52:36 +0000
commit38cc6c50282732ff5805681b96860742377148fb (patch)
tree5a275777a608cd07d4720eccc0217f049ca4d456
parent34feb66fd7cadba0b35504269cdaa923f79f210d (diff)
downloadchromium_src-38cc6c50282732ff5805681b96860742377148fb.zip
chromium_src-38cc6c50282732ff5805681b96860742377148fb.tar.gz
chromium_src-38cc6c50282732ff5805681b96860742377148fb.tar.bz2
Revert of bookmarks: Remove url_database.h entry from DEPS list. (patchset #2 id:20001 of https://codereview.chromium.org/912653005/)
Reason for revert: Seem to cause a failure related to bookmark dependencies. Original issue's description: > bookmarks: Remove DEPS file now that componentization is almost done. > > Since the componentization of bookmarks is mostly done, we don't need the rules forbidding usage of //chrome/browser anymore, as the files still in > //chrome/browser/bookmarks won't be moved in the component (factories, > client, etc, all belongs to the embedder, not the component). > > BUG=383597 > TEST=checkdeps > R=sky@chromium.org,sdefresne@chromium.org > > Committed: https://crrev.com/de85300a1986e3ce43f89a56b08dbd5e2049c041 > Cr-Commit-Position: refs/heads/master@{#316201} TBR=sdefresne@chromium.org,sky@chromium.org,tfarina@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=383597 Review URL: https://codereview.chromium.org/920403002 Cr-Commit-Position: refs/heads/master@{#316208}
-rw-r--r--chrome/browser/bookmarks/DEPS43
1 files changed, 43 insertions, 0 deletions
diff --git a/chrome/browser/bookmarks/DEPS b/chrome/browser/bookmarks/DEPS
new file mode 100644
index 0000000..73aa9a2
--- /dev/null
+++ b/chrome/browser/bookmarks/DEPS
@@ -0,0 +1,43 @@
+include_rules = [
+ # Bookmarks is being made into a component (it will end up at
+ # //components/bookmarks and not depend on //chrome), so we have these basic
+ # rules followed by temporary exceptions. Please don't add to the list of
+ # exceptions!
+ "-chrome/browser",
+ "+chrome/browser/bookmarks",
+ "+chrome/browser/browser_process.h",
+ "+chrome/browser/favicon",
+ "+chrome/browser/chrome_notification_types.h",
+ "+chrome/browser/policy/profile_policy_connector.h",
+ "+chrome/browser/policy/profile_policy_connector_factory.h",
+ "+chrome/browser/profiles/incognito_helpers.h",
+ "+chrome/browser/profiles/profile.h",
+ "+chrome/browser/profiles/startup_task_runner_service.h",
+ "+chrome/browser/profiles/startup_task_runner_service_factory.h",
+ "+chrome/browser/signin/signin_manager_factory.h",
+ "+chrome/browser/undo/bookmark_undo_service.h",
+ "+chrome/browser/undo/bookmark_undo_service_factory.h",
+
+ # TODO(tfarina): Bring this list to zero. crbug.com/144783
+ # Do not add to the list of temporarily-allowed dependencies below,
+ # and please do not introduce more #includes of these files.
+ "!chrome/browser/history/history_service.h",
+ "!chrome/browser/history/history_service_factory.h",
+ "!chrome/browser/history/url_database.h",
+ # Do not add to the list of temporarily-allowed dependencies above,
+ # and please do not introduce more #includes of these files.
+]
+
+specific_include_rules = {
+ # For unit tests, it's fine to include utility process code.
+ '.*test\.cc': [
+ "+chrome/test/base/testing_profile.h",
+ "+chrome/utility/importer/bookmark_html_reader.h",
+ ],
+ # Allow to include flags_storage into enhanced_bookmarks_features.cc because
+ # it has a function used by about_flags.cc and it needs flags_storage.
+ # This should be removed after enhanced bookmarks experiment is over.
+ 'enhanced_bookmarks_features\.cc': [
+ "+chrome/browser/flags_storage.h",
+ ],
+}