diff options
| author | deanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-13 18:19:37 +0000 |
|---|---|---|
| committer | deanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-13 18:19:37 +0000 |
| commit | 44204526eb0e866920d2a67f1d7350f330cc5d83 (patch) | |
| tree | 20e835900049001a1c3fa0070b2b639ae6e50ae1 | |
| parent | 48a35da4da4318109eaa08e62b26085828327bb0 (diff) | |
| download | chromium_src-44204526eb0e866920d2a67f1d7350f330cc5d83.zip chromium_src-44204526eb0e866920d2a67f1d7350f330cc5d83.tar.gz chromium_src-44204526eb0e866920d2a67f1d7350f330cc5d83.tar.bz2 | |
Fix ownership error with GtkTextTagTable and GtkTextTag.
When we create with gtk_text_buffer_create_tag:
"""
The returned tag is owned by the buffer's tag table, so the ref count will be equal to one.
"""
We do not own the tags, only the table.
Review URL: http://codereview.chromium.org/46044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11647 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc b/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc index af8ac3fc..d957f47 100644 --- a/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc +++ b/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc @@ -65,9 +65,8 @@ AutocompleteEditViewGtk::~AutocompleteEditViewGtk() { gtk_widget_destroy(text_view_); g_object_unref(text_buffer_); g_object_unref(tag_table_); - g_object_unref(insecure_scheme_tag_); - g_object_unref(secure_scheme_tag_); - g_object_unref(base_tag_); + // The tags we created are owned by the tag_table, and should be destroyed + // along with it. We don't hold our own reference to them. } } |