diff options
| author | tfarina <tfarina@chromium.org> | 2015-08-12 16:20:22 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-08-12 23:41:07 +0000 |
| commit | 5132ba00872ecc7a9f1a71238bf390e09359ff5b (patch) | |
| tree | 74a8eae8522e7ee3e2e523a211893a0a102775c0 | |
| parent | c49c4d737138b87c7e33629e62b271e0c23ecee8 (diff) | |
| download | chromium_src-5132ba00872ecc7a9f1a71238bf390e09359ff5b.zip chromium_src-5132ba00872ecc7a9f1a71238bf390e09359ff5b.tar.gz chromium_src-5132ba00872ecc7a9f1a71238bf390e09359ff5b.tar.bz2 | |
Fix some gn_visibility TODOs.
Tested on Mac with the following command lines:
$ gn gen out-gn/Release --args='is_debug=false is_component_build=false symbol_level=1'
$ ninja -C out-gn/Release gn_visibility
BUG=504076
TEST=see above
R=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1283133002
Cr-Commit-Position: refs/heads/master@{#343120}
| -rw-r--r-- | BUILD.gn | 7 |
1 files changed, 2 insertions, 5 deletions
@@ -472,9 +472,6 @@ group("both_gn_and_gyp") { "//ui/snapshot:snapshot_unittests", "//ui/views/examples:views_examples_with_content_exe", - # "//v8:v8_snapshot", # TODO(GYP): visibility? - # "//v8:postmortem-metadata", # TODO(GYP): visibility? - "//third_party/codesighs:nm2tsv", "//third_party/sqlite:sqlite_shell", ] @@ -743,8 +740,8 @@ group("gn_visibility") { "//ui/resources:repack_ui_test_mac_locale_pack", - # "//v8:v8_snapshot", # TODO(GYP): visibility? - # "//v8:postmortem-metadata", # TODO(GYP): visibility? + "//v8:v8_snapshot", + "//v8:postmortem-metadata", ] } |