diff options
| author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-27 17:16:29 +0000 |
|---|---|---|
| committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-27 17:16:29 +0000 |
| commit | 82d0646664cda7278163dffad687eb4e95e7e84d (patch) | |
| tree | b56f9576f23d965857a934e09fb0010fb47669b2 | |
| parent | ceda1872370a8d99d4f03cbc6b297088b192f14d (diff) | |
| download | chromium_src-82d0646664cda7278163dffad687eb4e95e7e84d.zip chromium_src-82d0646664cda7278163dffad687eb4e95e7e84d.tar.gz chromium_src-82d0646664cda7278163dffad687eb4e95e7e84d.tar.bz2 | |
Add TODOs.
BUG=TEST=none
Review URL: http://codereview.chromium.org/334029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30210 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/cocoa/bookmark_bar_controller.mm | 2 | ||||
| -rw-r--r-- | chrome/browser/cocoa/download_shelf_controller.mm | 3 |
2 files changed, 5 insertions, 0 deletions
diff --git a/chrome/browser/cocoa/bookmark_bar_controller.mm b/chrome/browser/cocoa/bookmark_bar_controller.mm index 5d2a6d1..2ee2e53 100644 --- a/chrome/browser/cocoa/bookmark_bar_controller.mm +++ b/chrome/browser/cocoa/bookmark_bar_controller.mm @@ -82,7 +82,9 @@ - (void)dealloc { // Remove our view from its superview so it doesn't attempt to reference // it when the controller is gone. + //TODO(dmaclach): Remove -- http://crbug.com/25845 [[self view] removeFromSuperview]; + bridge_.reset(NULL); [[NSNotificationCenter defaultCenter] removeObserver:self]; [super dealloc]; diff --git a/chrome/browser/cocoa/download_shelf_controller.mm b/chrome/browser/cocoa/download_shelf_controller.mm index 64c887f..122a132 100644 --- a/chrome/browser/cocoa/download_shelf_controller.mm +++ b/chrome/browser/cocoa/download_shelf_controller.mm @@ -147,7 +147,10 @@ const NSTimeInterval kDownloadItemOpenDuration = 0.8; // DownloadItem. We don't want to wait for autorelease since the DownloadItem // we are observing will likely be gone by then. [[NSNotificationCenter defaultCenter] removeObserver:download]; + + // TODO(dmaclach): Remove -- http://crbug.com/25845 [[download view] removeFromSuperview]; + [downloadItemControllers_ removeObject:download]; [self layoutItems]; |