diff options
| author | shess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-03 16:16:08 +0000 |
|---|---|---|
| committer | shess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-03 16:16:08 +0000 |
| commit | 9e0f7b623f298795a2b9c949926ca4183a37d999 (patch) | |
| tree | d9584dc39305cb1727459e9afbf04fd22fdf1f32 | |
| parent | 4d647bd18a68fc0c91e7c1a06cdeb615311e0274 (diff) | |
| download | chromium_src-9e0f7b623f298795a2b9c949926ca4183a37d999.zip chromium_src-9e0f7b623f298795a2b9c949926ca4183a37d999.tar.gz chromium_src-9e0f7b623f298795a2b9c949926ca4183a37d999.tar.bz2 | |
Make AboutCrash handler crash directly.
Was inadvertantly changed to use CHECK(false). Reverting to crash
directly so that the crash signature is more useful
(AboutHandler::AboutCrash rather than BreakDebugger).
BUG=none
TEST=about:crash still crashes the renderer.
Review URL: http://codereview.chromium.org/7301003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91448 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/renderer/about_handler.cc | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/chrome/renderer/about_handler.cc b/chrome/renderer/about_handler.cc index de4b57a..c8e1604 100644 --- a/chrome/renderer/about_handler.cc +++ b/chrome/renderer/about_handler.cc @@ -43,7 +43,14 @@ bool AboutHandler::MaybeHandle(const GURL& url) { // static void AboutHandler::AboutCrash() { - CHECK(false); + // NOTE(shess): Crash directly rather than using NOTREACHED() so + // that the signature is easier to triage in crash reports. + volatile int* zero = NULL; + *zero = 0; + + // Just in case the compiler decides the above is undefined and + // optimizes it away. + NOTREACHED(); } // static |