diff options
| author | csharrison <csharrison@chromium.org> | 2015-10-21 15:43:21 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-10-21 22:44:09 +0000 |
| commit | bf4f138d997debcac746660d474a9bc458764fc4 (patch) | |
| tree | d759df30cea2243b240b9a865dd4f91cef72bd6e | |
| parent | ad5bd2d4ae4ea0ada750b5d1532a06296450f554 (diff) | |
| download | chromium_src-bf4f138d997debcac746660d474a9bc458764fc4.zip chromium_src-bf4f138d997debcac746660d474a9bc458764fc4.tar.gz chromium_src-bf4f138d997debcac746660d474a9bc458764fc4.tar.bz2 | |
DidFinishNavigation should always be preceded with DidStartNavigation. We CHECK this fact make crash logs more informative and force this invariant on releases.
BUG=545373
Review URL: https://codereview.chromium.org/1415083002
Cr-Commit-Position: refs/heads/master@{#355417}
| -rw-r--r-- | components/page_load_metrics/browser/metrics_web_contents_observer.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer.cc b/components/page_load_metrics/browser/metrics_web_contents_observer.cc index 70ae3ca..d19d332 100644 --- a/components/page_load_metrics/browser/metrics_web_contents_observer.cc +++ b/components/page_load_metrics/browser/metrics_web_contents_observer.cc @@ -267,7 +267,7 @@ void MetricsWebContentsObserver::DidFinishNavigation( scoped_ptr<PageLoadTracker> finished_nav( provisional_loads_.take_and_erase(navigation_handle)); - DCHECK(finished_nav); + CHECK(finished_nav); // Handle a pre-commit error here. Navigations that result in an error page // will be ignored. Note that downloads/204s will result in HasCommitted() |