summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordbeam@chromium.org <dbeam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-12-29 05:07:57 +0000
committerdbeam@chromium.org <dbeam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-12-29 05:07:57 +0000
commitc86366769a7d791dd956c7155bee6de8dcbe2504 (patch)
treec919b479bbc4c69843b4e676656e908320811189
parent6aecb665e42c8cd1ad9db849471efa42b82a951c (diff)
downloadchromium_src-c86366769a7d791dd956c7155bee6de8dcbe2504.zip
chromium_src-c86366769a7d791dd956c7155bee6de8dcbe2504.tar.gz
chromium_src-c86366769a7d791dd956c7155bee6de8dcbe2504.tar.bz2
[Coverity] More pass by val -> pass by const ref.
CID=101510 R=groby@chromium.org,msw@chromium.org,sky@chromium.org Review URL: http://codereview.chromium.org/8999004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115951 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--ui/gfx/render_text.cc4
-rw-r--r--ui/gfx/render_text.h2
2 files changed, 3 insertions, 3 deletions
diff --git a/ui/gfx/render_text.cc b/ui/gfx/render_text.cc
index 94bfd23..2badc05 100644
--- a/ui/gfx/render_text.cc
+++ b/ui/gfx/render_text.cc
@@ -42,7 +42,7 @@ void CheckStyleRanges(const gfx::StyleRanges& style_ranges, size_t length) {
#endif
void ApplyStyleRangeImpl(gfx::StyleRanges* style_ranges,
- gfx::StyleRange style_range) {
+ const gfx::StyleRange& style_range) {
const ui::Range& new_range = style_range.range;
// Follow StyleRanges invariant conditions: sorted and non-overlapping ranges.
gfx::StyleRanges::iterator i;
@@ -395,7 +395,7 @@ void RenderText::SetCompositionRange(const ui::Range& composition_range) {
UpdateLayout();
}
-void RenderText::ApplyStyleRange(StyleRange style_range) {
+void RenderText::ApplyStyleRange(const StyleRange& style_range) {
const ui::Range& new_range = style_range.range;
if (!new_range.IsValid() || new_range.is_empty())
return;
diff --git a/ui/gfx/render_text.h b/ui/gfx/render_text.h
index d59be09..260bee8 100644
--- a/ui/gfx/render_text.h
+++ b/ui/gfx/render_text.h
@@ -180,7 +180,7 @@ class UI_EXPORT RenderText {
void SetCompositionRange(const ui::Range& composition_range);
// Apply |style_range| to the internal style model.
- void ApplyStyleRange(StyleRange style_range);
+ void ApplyStyleRange(const StyleRange& style_range);
// Apply |default_style_| over the entire text range.
void ApplyDefaultStyle();