diff options
| author | limasdf <limasdf@gmail.com> | 2015-12-10 16:10:55 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-12-11 00:11:39 +0000 |
| commit | 317bf9f09ff96df79dec6aa453e74528bba77ef7 (patch) | |
| tree | 99dabc9bd5bdb9753d3d01c1e40a27976ee40460 | |
| parent | 44945a9f88dbf87ec82543d8dab9718084cd60e2 (diff) | |
| download | chromium_src-317bf9f09ff96df79dec6aa453e74528bba77ef7.zip chromium_src-317bf9f09ff96df79dec6aa453e74528bba77ef7.tar.gz chromium_src-317bf9f09ff96df79dec6aa453e74528bba77ef7.tar.bz2 | |
extensions::ListBuilder move constructor doesn't transfer to a raw pointer.
This is mentioned on https://codereview.chromium.org/1497753002/.
extensions::ListBuilder's move constructor should not transfer ownership to a raw pointer(not to another scoped_ptr).
BUG=563649
Review URL: https://codereview.chromium.org/1510233005
Cr-Commit-Position: refs/heads/master@{#364536}
| -rw-r--r-- | extensions/common/value_builder.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/extensions/common/value_builder.cc b/extensions/common/value_builder.cc index 6e73f36..b15bca8 100644 --- a/extensions/common/value_builder.cc +++ b/extensions/common/value_builder.cc @@ -81,10 +81,10 @@ ListBuilder::ListBuilder(const base::ListValue& init) : list_(init.DeepCopy()) { ListBuilder::~ListBuilder() {} ListBuilder::ListBuilder(ListBuilder&& other) - : list_(other.Build().release()) {} + : list_(other.Build()) {} ListBuilder& ListBuilder::operator=(ListBuilder&& other) { - list_.reset(other.Build().release()); + list_ = other.Build(); return *this; } |