diff options
| author | dglazkov@google.com <dglazkov@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-06 19:53:37 +0000 |
|---|---|---|
| committer | dglazkov@google.com <dglazkov@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-06 19:53:37 +0000 |
| commit | 106382abe3a15a53d9cc0e0a842e6c517d64acf0 (patch) | |
| tree | 04c96c6131c68f6b60782f3f88e576fe8bff2dec | |
| parent | ae0991b41289778be0c2369e7c67f836fa960b4f (diff) | |
| download | chromium_src-106382abe3a15a53d9cc0e0a842e6c517d64acf0.zip chromium_src-106382abe3a15a53d9cc0e0a842e6c517d64acf0.tar.gz chromium_src-106382abe3a15a53d9cc0e0a842e6c517d64acf0.tar.bz2 | |
Start with a PolicyIgnore when determining navigation action policy in WebFrameLoaderClient.
This ensures that we never attempt loading an empty URL and fixes the crash in the layout test, mentioned below.
BUG=16754
TEST=LayoutTests/fast/loader/empty-embed-src-attribute.html
R=darin
Review URL: http://codereview.chromium.org/164078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22642 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | webkit/glue/webframeloaderclient_impl.cc | 2 | ||||
| -rw-r--r-- | webkit/tools/layout_tests/test_expectations.txt | 3 |
2 files changed, 1 insertions, 4 deletions
diff --git a/webkit/glue/webframeloaderclient_impl.cc b/webkit/glue/webframeloaderclient_impl.cc index 2bc9d2c..7455107 100644 --- a/webkit/glue/webframeloaderclient_impl.cc +++ b/webkit/glue/webframeloaderclient_impl.cc @@ -822,7 +822,7 @@ void WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction( const WebCore::NavigationAction& action, const WebCore::ResourceRequest& request, PassRefPtr<WebCore::FormState> form_state) { - PolicyAction policy_action = PolicyUse; + PolicyAction policy_action = PolicyIgnore; WebViewImpl* wv = webframe_->GetWebViewImpl(); WebViewDelegate* d = wv->delegate(); diff --git a/webkit/tools/layout_tests/test_expectations.txt b/webkit/tools/layout_tests/test_expectations.txt index d73e5f50..d7f1f59 100644 --- a/webkit/tools/layout_tests/test_expectations.txt +++ b/webkit/tools/layout_tests/test_expectations.txt @@ -2834,9 +2834,6 @@ BUG16240 MAC : LayoutTests/http/tests/cache/subresource-expiration.html = PASS T // Failing due to r20652. BUG16779 BUG16742 : LayoutTests/media/video-error-abort.html = FAIL CRASH -// Failing approximately starting from 20629 -BUG16754 : LayoutTests/fast/loader/empty-embed-src-attribute.html = CRASH - // HTML5 DataGrid bindings are not enabled yet because the feature's not fully implemented. BUG17585 : LayoutTests/fast/dom/HTMLDataGridElement/DataGridColumns-basic.html = FAIL BUG17585 : LayoutTests/fast/dom/HTMLDataGridElement/DataGridColumns-dom.html = FAIL |